From dc6305e8c19f5fa1f8969a2c3e12e121ec10a64d Mon Sep 17 00:00:00 2001 From: Peter Nelson Date: Mon, 11 Mar 2024 08:09:44 +0000 Subject: [PATCH] Codechange: Use std::make_unique instead of passing new into a unique_ptr. (#12263) std::make_unique will also initialise the data so MemSetT is not needed. --- src/gfx.cpp | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/src/gfx.cpp b/src/gfx.cpp index 4601d444da..4b6b7b8d0c 100644 --- a/src/gfx.cpp +++ b/src/gfx.cpp @@ -1169,9 +1169,7 @@ std::unique_ptr DrawSpriteToRgbaBuffer(SpriteID spriteId, ZoomLevel const Sprite *sprite = GetSprite(real_sprite, SpriteType::Normal); Dimension dim = GetSpriteSize(real_sprite, nullptr, zoom); size_t dim_size = static_cast(dim.width) * dim.height; - std::unique_ptr result(new uint32_t[dim_size]); - /* Set buffer to fully transparent. */ - MemSetT(result.get(), 0, dim_size); + std::unique_ptr result = std::make_unique(dim_size); /* Prepare new DrawPixelInfo - Normally this would be the screen but we want to draw to another buffer here. * Normally, pitch would be scaled screen width, but in our case our "screen" is only the sprite width wide. */ @@ -1189,9 +1187,7 @@ std::unique_ptr DrawSpriteToRgbaBuffer(SpriteID spriteId, ZoomLevel /* If the current blitter is a paletted blitter, we have to render to an extra buffer and resolve the palette later. */ std::unique_ptr pal_buffer{}; if (blitter->GetScreenDepth() == 8) { - pal_buffer.reset(new byte[dim_size]); - MemSetT(pal_buffer.get(), 0, dim_size); - + pal_buffer = std::make_unique(dim_size); dpi.dst_ptr = pal_buffer.get(); }