From e93d081a4af01cb55a0c27b288a74c61d1789ea7 Mon Sep 17 00:00:00 2001 From: Peter Nelson Date: Tue, 27 Feb 2024 18:18:57 +0000 Subject: [PATCH] Codechange: Use range-for instead of indexed loop. (#12191) --- src/vehicle_cmd.cpp | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/src/vehicle_cmd.cpp b/src/vehicle_cmd.cpp index 97ecf8432f..57a66b5cb6 100644 --- a/src/vehicle_cmd.cpp +++ b/src/vehicle_cmd.cpp @@ -670,9 +670,7 @@ CommandCost CmdMassStartStopVehicle(DoCommandFlag flags, TileIndex tile, bool do BuildDepotVehicleList(vli.vtype, tile, &list, nullptr); } - for (uint i = 0; i < list.size(); i++) { - const Vehicle *v = list[i]; - + for (const Vehicle *v : list) { if (!!(v->vehstatus & VS_STOPPED) != do_start) continue; if (!vehicle_list_window && !v->IsChainInDepot()) continue; @@ -705,8 +703,8 @@ CommandCost CmdDepotSellAllVehicles(DoCommandFlag flags, TileIndex tile, Vehicle CommandCost last_error = CMD_ERROR; bool had_success = false; - for (uint i = 0; i < list.size(); i++) { - CommandCost ret = Command::Do(flags, list[i]->index, true, false, INVALID_CLIENT_ID); + for (const Vehicle *v : list) { + CommandCost ret = Command::Do(flags, v->index, true, false, INVALID_CLIENT_ID); if (ret.Succeeded()) { cost.AddCost(ret); had_success = true; @@ -736,9 +734,7 @@ CommandCost CmdDepotMassAutoReplace(DoCommandFlag flags, TileIndex tile, Vehicle /* Get the list of vehicles in the depot */ BuildDepotVehicleList(vehicle_type, tile, &list, &list, true); - for (uint i = 0; i < list.size(); i++) { - const Vehicle *v = list[i]; - + for (const Vehicle *v : list) { /* Ensure that the vehicle completely in the depot */ if (!v->IsChainInDepot()) continue;