Fix double free, thanks to @disaykin

Bug found by Svace static analyzer

src/log.c

@@ -1561,10 +1561,8 @@ log_cert_submit(const char *fn, X509 *crt)
 	if (!(pem = ssl_x509_to_pem(crt)))
 		goto errout2;
 	if (!(lb = logbuf_new(0, pem, strlen(pem), NULL)))
-		goto errout3;
+		goto errout2;
 	return logger_submit(cert_log, fh, 0, lb);
-errout3:
-	free(pem);
 errout2:
 	free(fh);
 errout1:

src/logger.c

@@ -210,11 +210,14 @@ logger_thread(void *arg)
 		if (logbuf_ctl_isset(lb, LBFLAG_REOPEN)) {
 			if (logger->reopen() != 0)
 				e = 1;
+			logbuf_free(lb);
 		} else if (logbuf_ctl_isset(lb, LBFLAG_OPEN)) {
 			if (logger->open(lb->fh) != 0)
 				e = 1;
+			logbuf_free(lb);
 		} else if (logbuf_ctl_isset(lb, LBFLAG_CLOSE)) {
 			logger->close(lb->fh, lb->ctl);
+			logbuf_free(lb);
 		} else {
 			if (logbuf_write_free(lb, logger->write) < 0)
 				e = 1;
@@ -303,7 +306,6 @@ logger_printf(logger_t *logger, void *fh, unsigned long prepflags,
 
 	if (!(lb = logbuf_new(0, NULL, 0, NULL)))
 		return -1;
-	lb->fh = fh;
 	va_start(ap, fmt);
 	lb->sz = vasprintf((char**)&lb->buf, fmt, ap);
 	va_end(ap);
@@ -321,7 +323,6 @@ logger_write(logger_t *logger, void *fh, unsigned long prepflags,
 
 	if (!(lb = logbuf_new_copy(buf, sz, NULL)))
 		return -1;
-	lb->fh = fh;
 	return logger_submit(logger, fh, prepflags, lb);
 }
 int
@@ -332,7 +333,6 @@ logger_print(logger_t *logger, void *fh, unsigned long prepflags,
 
 	if (!(lb = logbuf_new_copy(s, strlen(s), NULL)))
 		return -1;
-	lb->fh = fh;
 	return logger_submit(logger, fh, prepflags, lb);
 }
 int
@@ -343,19 +343,13 @@ logger_write_freebuf(logger_t *logger, int level, void *fh, unsigned long prepfl
 
 	if (!(lb = logbuf_new(level, buf, sz, NULL)))
 		return -1;
-	lb->fh = fh;
 	return logger_submit(logger, fh, prepflags, lb);
 }
 int
 logger_print_freebuf(logger_t *logger, void *fh, unsigned long prepflags,
                      char *s)
 {
-	logbuf_t *lb;
-
-	if (!(lb = logbuf_new(0, s, strlen(s), NULL)))
-		return -1;
-	lb->fh = fh;
-	return logger_submit(logger, fh, prepflags, lb);
+	return logger_write_freebuf(logger, 0, fh, prepflags, s, strlen(s));
 }
 
 /* vim: set noet ft=c: */

src/protohttp.c

@@ -152,7 +152,6 @@ protohttp_log_connect(pxy_conn_ctx_t *ctx)
 	}
 	if (ctx->global->connectlog) {
 		if (log_connect_print_free(msg) == -1) {
-			free(msg);
 			log_err_level_printf(LOG_WARNING, "Connection logging failed\n");
 		}
 	} else {

src/pxyconn.c

@@ -529,7 +529,6 @@ pxy_log_connect_nonhttp(pxy_conn_ctx_t *ctx)
 	}
 	if (ctx->global->connectlog) {
 		if (log_connect_print_free(msg) == -1) {
-			free(msg);
 			log_err_level_printf(LOG_WARNING, "Connection logging failed\n");
 		}
 	} else {

tests/testproxy/lp/pxyconn.c

@@ -149,7 +149,6 @@ pxy_log_connect_tcp(pxy_conn_ctx_t *ctx)
 	}
 	if (ctx->opts->connectlog) {
 		if (log_connect_print_free(msg) == -1) {
-			free(msg);
 			log_err_level_printf(LOG_WARNING, "Connection logging failed\n");
 		}
 	} else {