Fix all Shellcheck SC2059 violations.

lib/init/init.sh

@@ -67,7 +67,8 @@ append () {
 appendf () {
   local fmt="$1"
   shift
-  buf+="$(printf "${fmt}" "${@}")"
+  # shellcheck disable=SC2059
+ buf+="$(printf "${fmt}" "${@}")"
 }
 
 ## wraps each argument in quotes

lib/install/install.sh

@@ -15,9 +15,7 @@ BPKG_USER="${BPKG_USER:-bpkg}"
 ## check parameter consistency
 validate_parameters () {
   if [[ ${#BPKG_GIT_REMOTES[@]} -ne ${#BPKG_REMOTES[@]} ]]; then
-    mesg='BPKG_GIT_REMOTES[%d] differs in size from BPKG_REMOTES[%d] array'
-    fmesg=$(printf "$mesg" "${#BPKG_GIT_REMOTES[@]}" "${#BPKG_REMOTES[@]}")
-    error "$fmesg"
+    error "$(printf 'BPKG_GIT_REMOTES[%d] differs in size from BPKG_REMOTES[%d] array' "${#BPKG_GIT_REMOTES[@]}" "${#BPKG_REMOTES[@]}")"
     return 1
   fi
   return 0
@@ -37,7 +35,7 @@ message () {
   fi
 
   shift
-  printf "    ${1}"
+  echo -n "    ${1}"
   shift
 
   if type -f bpkg-term > /dev/null 2>&1; then

lib/term/term.sh

@@ -24,7 +24,7 @@ term_write () {
   if [ -z "${c}" ]; then
     return 1
   fi
-  printf "\e[${c}"
+  echo -en "\e[${c}"
   return 0
 }
 
@@ -78,19 +78,18 @@ term_transition () {
 ## set terminal color
 term_color () {
   local color="${1}"
-  local fmt="\e[3%dm"
   if [ -z "${color}" ]; then
     return 1
   fi
   case "${color}" in
-    black) printf "${fmt}" "0" ;;
-    red) printf "${fmt}" "1" ;;
-    green) printf "${fmt}" "2" ;;
-    yellow) printf "${fmt}" "3" ;;
-    blue) printf "${fmt}" "4" ;;
-    magenta) printf "${fmt}" "5" ;;
-    cyan) printf "${fmt}" "6" ;;
-    white) printf "${fmt}" "7" ;;
+    black) printf "\e[30m" ;;
+    red) printf "\e[31m" ;;
+    green) printf "\e[32m" ;;
+    yellow) printf "\e[33m" ;;
+    blue) printf "\e[34m" ;;
+    magenta) printf "\e[35m" ;;
+    cyan) printf "\e[36m" ;;
+    white) printf "\e[37m" ;;
     gray|grey) printf "\e[90m" ;;
     *) return 1 ;;
   esac
@@ -100,19 +99,18 @@ term_color () {
 ## set term background color
 term_background () {
   local color="${1}"
-  local fmt="\e[4%dm"
   if [ -z "${color}" ]; then
     return 1
   fi
   case "${color}" in
-    black) printf "${fmt}" "0" ;;
-    red) printf "${fmt}" "1" ;;
-    green) printf "${fmt}" "2" ;;
-    yellow) printf "${fmt}" "3" ;;
-    blue) printf "${fmt}" "4" ;;
-    magenta) printf "${fmt}" "5" ;;
-    cyan) printf "${fmt}" "6" ;;
-    white) printf "${fmt}" "7" ;;
+    black) printf "\e[40m" ;;
+    red) printf "\e[41m" ;;
+    green) printf "\e[42m" ;;
+    yellow) printf "\e[43m" ;;
+    blue) printf "\e[44m" ;;
+    magenta) printf "\e[45m" ;;
+    cyan) printf "\e[46m" ;;
+    white) printf "\e[47m" ;;
     *) return 1 ;;
   esac
   return 0
@@ -156,16 +154,15 @@ term_hidden () {
 ## clear a terminal section by name
 term_clear () {
   local section="${1}"
-  local fmt="\e[%s"
   if [ -z "${section}" ]; then
     return 1
   fi
   case "${section}" in
-    start) printf "${fmt}" "1K";;
-    end) printf "${fmt}" "K";;
-    line) printf "${fmt}" "2K";;
-    screen|up) printf "${fmt}" "1J";;
-    down) printf "${fmt}" "J";;
+    start) printf "\e[1K";;
+    end) printf "\e[K";;
+    line) printf "\e[2K";;
+    screen|up) printf "\e[1J";;
+    down) printf "\e[J";;
     *) return 1 ;;
   esac
   return 0

lib/utils/utils.sh

@@ -23,9 +23,7 @@ bpkg_initrc() {
 bpkg_validate () {
   bpkg_initrc
   if [ ${#BPKG_GIT_REMOTES[@]} -ne ${#BPKG_REMOTES[@]} ]; then
-    mesg='BPKG_GIT_REMOTES[%d] differs in size from BPKG_REMOTES[%d] array'
-    fmesg=$(printf "$mesg" "${#BPKG_GIT_REMOTES[@]}" "${#BPKG_REMOTES[@]}")
-    error "$fmesg"
+    error "$(printf 'BPKG_GIT_REMOTES[%d] differs in size from BPKG_REMOTES[%d] array' "${#BPKG_GIT_REMOTES[@]}" "${#BPKG_REMOTES[@]}")"
     return 1
   fi
   return 0
@@ -38,7 +36,7 @@ bpkg_message () {
   fi
 
   shift
-  printf "    ${1}"
+  echo -n "    ${1}"
   shift
 
   if type -f bpkg-term > /dev/null 2>&1; then