From 8dd6f4f4b8255898ecd358c5719ec52b219ad045 Mon Sep 17 00:00:00 2001
From: "Casper Ti. Vector" <CasperVector@gmail.com>
Date: Sat, 25 Aug 2012 00:39:54 +0800
Subject: [PATCH 1/4] Fix yesno() implementation.

---
 src/cdm | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/src/cdm b/src/cdm
index 6d0562d..0f11bba 100755
--- a/src/cdm
+++ b/src/cdm
@@ -43,11 +43,12 @@ exiterror() { sleep 1; exit 1; }
 yesno()
 {
 	[ -z "$1" ] && return 1
+	eval value=\$${1}
 
-	case "$1" in
+	case "$value" in
 	    [Yy][Ee][Ss]|[Tt][Rr][Uu][Ee]|[Oo][Nn]|1) return 0;; 
 	    [Nn][Oo]|[Ff][Aa][Ll][Ss][Ee]|[Oo][Ff][Ff]|0) return 1;; 
-		*) warn "\`$1' is not a valid argument for \`yesno'; using \`no' for now."
+		*) warn "Invalid value for \`$1'; falling back to \`no' for now.";;
 	esac
 }
 

From e14c9fdaf5021be4c0fec3aaa81e14f14dc734ac Mon Sep 17 00:00:00 2001
From: "Casper Ti. Vector" <CasperVector@gmail.com>
Date: Sat, 25 Aug 2012 00:41:52 +0800
Subject: [PATCH 2/4] Redirect all output of warn() and error() to stderr.

---
 src/cdm         | 4 ++--
 src/cdm-xlaunch | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/cdm b/src/cdm
index 0f11bba..2ed630a 100755
--- a/src/cdm
+++ b/src/cdm
@@ -36,8 +36,8 @@ trap '' SIGINT SIGTSTP
 
 # Helper functions.
 
-warn() { printf ' \033[01;33m*\033[00m '; echo "$name: $*" > /dev/stderr; }
-error() { printf ' \033[01;31m*\033[00m '; echo "$name: $*" > /dev/stderr; }
+warn() { (printf ' \033[01;33m*\033[00m '; echo "$name: $*") > /dev/stderr; }
+error() { (printf ' \033[01;31m*\033[00m '; echo "$name: $*") > /dev/stderr; }
 exitnormal() { exit 0; }
 exiterror() { sleep 1; exit 1; }
 yesno()
diff --git a/src/cdm-xlaunch b/src/cdm-xlaunch
index 8e197cd..5aa3714 100755
--- a/src/cdm-xlaunch
+++ b/src/cdm-xlaunch
@@ -33,7 +33,7 @@ consolekit=false
 cktimeout=30
 
 info() { printf ' \033[01;32m*\033[00m '; echo "$name: $*"; }
-error() { printf ' \033[01;31m*\033[00m '; echo "$name: $*" > /dev/stderr; }
+error() { (printf ' \033[01;31m*\033[00m '; echo "$name: $*") > /dev/stderr; }
 
 args=$(getopt -n "$name" -o ct: -l consolekit,timeout: -- "$@") || exit 1
 eval set -- "$args"

From 98dca034c3835a977c91e29b77eaf84cbe3a00ef Mon Sep 17 00:00:00 2001
From: "Casper Ti. Vector" <CasperVector@gmail.com>
Date: Sat, 25 Aug 2012 00:43:00 +0800
Subject: [PATCH 3/4] Make better use of exitnormal().

---
 src/cdm | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/src/cdm b/src/cdm
index 2ed630a..4457118 100755
--- a/src/cdm
+++ b/src/cdm
@@ -162,6 +162,8 @@ case ${flaglist[$binindex]} in
 		if ! eval cdm-xlaunch $launchflags -- $bin -- $serverargs; then
 			warn "\`cdm-xlaunch' exited unsuccessfully."
 			exiterror
+		else
+			exitnormal
 		fi
 		;;
 

From 4c5742336ba90754447e68a61fc7852d2545513b Mon Sep 17 00:00:00 2001
From: "Casper Ti. Vector" <CasperVector@gmail.com>
Date: Sat, 25 Aug 2012 00:44:16 +0800
Subject: [PATCH 4/4] consolekit -> ConsoleKit in comments.

---
 src/cdmrc | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/cdmrc b/src/cdmrc
index 067bbed..3631ffe 100644
--- a/src/cdmrc
+++ b/src/cdmrc
@@ -48,9 +48,9 @@ locktty=no
 #   /usr/bin/X :$display $serverargs vt$((xtty+display))
 serverargs='-nolisten tcp'
 
-# Use consolekit for X session?
+# Use ConsoleKit for X session?
 consolekit=yes
 
-# Timeout for waiting for X session to register with consolekit.
+# Timeout for waiting for X session to register with ConsoleKit.
 cktimeout=30