Temp dir fixes (#449)

* perform our test install into TMPDIR
* fix typo
* remove duplicate entry in CHANGELOG.md
* improve commenting

CHANGELOG.md

@@ -39,7 +39,6 @@
 - Document SECRETS_VERBOSE and improve env var docs (#396)
 - Update CHANGELOG.md to mention fix for #281 in v0.2.5 (#311)
 - Add text explaining git-secret Style Guide and Development Philosophy
-- Experimental SECRETS_TEST_VERBOSE env var shows debug info during tests (may be removed)
 - Upgrade bats-core to v1.1.0, import bats-core into vendor/bats-core (#377)
 - Improve git-secret user messaging.
 - Setting SECRETS_TEST_VERBOSE env var shows debug info during tests (EXPERIMENTAL)

tests/_test_base.bash

@@ -13,7 +13,7 @@ FIXTURES_DIR="$BATS_TEST_DIRNAME/fixtures"
 
 TEST_GPG_HOMEDIR="$BATS_TMPDIR"
 
-TEST_GPG_OUTPUT_FILE=$(TMPDIR="$BATS_TMP_DIR" mktemp -t '_git_secret_test_output_XXX')
+TEST_GPG_OUTPUT_FILE=$(TMPDIR="$BATS_TMPDIR" mktemp -t '_git_secret_test_output_XXX')
 
 # shellcheck disable=SC2016
 AWK_GPG_GET_FP='

tests/test_make_install.bats

@@ -1,7 +1,8 @@
 #!/usr/bin/env bats
 
+: "${TMPDIR:=/tmp}"
 
-INSTALL_BASE="/tmp/git-secret-test-install"
+INSTALL_BASE="${TMPDIR}/git-secret-test-install"
 
 @test "install git-secret to '$INSTALL_BASE'" {
 

utils/tests.sh

@@ -18,7 +18,7 @@ chmod 0700 "${TEST_DIR}"
     export SECRETS_EXTENSION=.secret2
     #export SECRETS_VERBOSE=''
 
-    #export TMPDIR="${TEST_DIR}"
+    #export TMPDIR="${TEST_DIR}"    # uncommenting this line seems to cause #451
     #echo "# TMPDIR is $TMPDIR" 
 
     # bats expects diagnostic lines to be sent to fd 3, matching regex '^ #' (IE, like: `echo '# message here' >&3`)