diff --git a/config/detekt.yml b/config/detekt.yml
index f9ea511c9..4d811a8f3 100644
--- a/config/detekt.yml
+++ b/config/detekt.yml
@@ -134,7 +134,7 @@ complexity:
threshold: 75 # (Default: 60) Increased in https://github.com/mozilla-mobile/android-components/issues/6350
LongParameterList:
active: true
- functionThreshold: 6
+ functionThreshold: 8 # (Default: 6) Increased in https://bugzilla.mozilla.org/show_bug.cgi?id=1872996
constructorThreshold: 7
ignoreDefaultParameters: true # Enabled in https://github.com/mozilla-mobile/android-components/issues/10835
ignoreDataClasses: true
diff --git a/detekt-baseline.xml b/detekt-baseline.xml
index 095460896..eaeec3bfa 100644
--- a/detekt-baseline.xml
+++ b/detekt-baseline.xml
@@ -41,7 +41,6 @@
UndocumentedPublicClass:AccountSettingsInteractor.kt$AccountSettingsUserActions
UndocumentedPublicClass:AccountUiView.kt$AccountUiView
UndocumentedPublicClass:ActivationPing.kt$ActivationPing
- UndocumentedPublicClass:AddSearchEngineFragment.kt$AddSearchEngineFragment : FragmentOnCheckedChangeListenerMenuProvider
UndocumentedPublicClass:AddonDetailsBindingDelegate.kt$AddonDetailsInteractor
UndocumentedPublicClass:AddonPermissionDetailsBindingDelegate.kt$AddonPermissionsDetailsInteractor
UndocumentedPublicClass:AdjustMetricsService.kt$AdjustMetricsService : MetricsService
@@ -168,8 +167,6 @@
UndocumentedPublicClass:FirstSessionPing.kt$FirstSessionPing
UndocumentedPublicClass:GeckoProvider.kt$GeckoProvider
UndocumentedPublicClass:GroupableRadioButton.kt$GroupableRadioButton
- UndocumentedPublicClass:HistoryController.kt$DefaultHistoryController : HistoryController
- UndocumentedPublicClass:HistoryController.kt$HistoryController
UndocumentedPublicClass:HistoryFragment.kt$HistoryFragment : LibraryPageFragmentUserInteractionHandlerMenuProvider
UndocumentedPublicClass:HistoryFragmentStore.kt$HistoryFragmentAction$AddItemForRemoval : HistoryFragmentAction
UndocumentedPublicClass:HistoryFragmentStore.kt$HistoryFragmentAction$EnterDeletionMode : HistoryFragmentAction
@@ -191,9 +188,6 @@
UndocumentedPublicClass:HistoryMetadataGroupFragmentStore.kt$HistoryMetadataGroupFragmentAction$Select : HistoryMetadataGroupFragmentAction
UndocumentedPublicClass:HistoryMetadataGroupFragmentStore.kt$HistoryMetadataGroupFragmentAction$UpdateHistoryItems : HistoryMetadataGroupFragmentAction
UndocumentedPublicClass:HistoryMetadataService.kt$DefaultHistoryMetadataService : HistoryMetadataService
- UndocumentedPublicClass:HistorySearchController.kt$HistorySearchDialogController : HistorySearchController
- UndocumentedPublicClass:HistorySearchDialogFragment.kt$HistorySearchDialogFragment : AppCompatDialogFragmentUserInteractionHandler
- UndocumentedPublicClass:HistorySearchFragmentStore.kt$HistorySearchFragmentAction$UpdateQuery : HistorySearchFragmentAction
UndocumentedPublicClass:HomeFragment.kt$HomeFragment : Fragment
UndocumentedPublicClass:HomeMenu.kt$HomeMenu
UndocumentedPublicClass:HomeMenu.kt$HomeMenu$Item
@@ -251,8 +245,6 @@
UndocumentedPublicClass:MetricsService.kt$MetricServiceType
UndocumentedPublicClass:MetricsService.kt$MetricsService
UndocumentedPublicClass:MetricsUtils.kt$MetricsUtils
- UndocumentedPublicClass:Mode.kt$Mode$Normal : Mode
- UndocumentedPublicClass:Mode.kt$Mode$Private : Mode
UndocumentedPublicClass:MozillaProductDetector.kt$MozillaProductDetector
UndocumentedPublicClass:MozillaProductDetector.kt$MozillaProductDetector$MozillaProducts
UndocumentedPublicClass:NewTabShortcutIntentProcessor.kt$NewTabShortcutIntentProcessor : IntentProcessor
@@ -439,7 +431,6 @@
UndocumentedPublicClass:ToolbarMenu.kt$ToolbarMenu.Item$Share : Item
UndocumentedPublicClass:ToolbarMenu.kt$ToolbarMenu.Item$Stop : Item
UndocumentedPublicClass:ToolbarMenu.kt$ToolbarMenu.Item$SyncAccount : Item
- UndocumentedPublicClass:ToolbarPopupWindow.kt$ToolbarPopupWindow
UndocumentedPublicClass:TopSiteItemMenu.kt$TopSiteItemMenu$Item
UndocumentedPublicClass:TopSiteItemMenu.kt$TopSiteItemMenu.Item$OpenInPrivateTab : Item
UndocumentedPublicClass:TopSiteItemMenu.kt$TopSiteItemMenu.Item$RemoveTopSite : Item
@@ -480,7 +471,6 @@
UndocumentedPublicFunction:AddonPermissionDetailsBindingDelegate.kt$AddonPermissionDetailsBindingDelegate$fun bind(addon: Addon)
UndocumentedPublicFunction:AppRequestInterceptor.kt$AppRequestInterceptor$fun setNavigationController(navController: NavController)
UndocumentedPublicFunction:AppViewHolder.kt$AppViewHolder$fun bind(item: AppShareOption)
- UndocumentedPublicFunction:AwesomeBarView.kt$AwesomeBarView$fun update(state: HistorySearchFragmentState)
UndocumentedPublicFunction:AwesomeBarView.kt$AwesomeBarView$fun update(state: SearchFragmentState)
UndocumentedPublicFunction:AwesomeBarView.kt$AwesomeBarView$fun updateSuggestionProvidersVisibility( state: SearchProviderState, )
UndocumentedPublicFunction:AwesomeBarView.kt$fun SearchFragmentState.toSearchProviderState()
@@ -620,22 +610,9 @@
UndocumentedPublicFunction:GroupableRadioButton.kt$GroupableRadioButton$fun updateRadioValue(isChecked: Boolean)
UndocumentedPublicFunction:GroupableRadioButton.kt$fun Iterable<GroupableRadioButton>.uncheckAll()
UndocumentedPublicFunction:HistoryAdapter.kt$HistoryAdapter$fun updateMode(mode: HistoryFragmentState.Mode)
- UndocumentedPublicFunction:HistoryController.kt$HistoryController$fun handleBackPressed(): Boolean
- UndocumentedPublicFunction:HistoryController.kt$HistoryController$fun handleDeleteSome(items: Set<History>)
- UndocumentedPublicFunction:HistoryController.kt$HistoryController$fun handleDeselect(item: History)
- UndocumentedPublicFunction:HistoryController.kt$HistoryController$fun handleEnterRecentlyClosed()
- UndocumentedPublicFunction:HistoryController.kt$HistoryController$fun handleModeSwitched()
- UndocumentedPublicFunction:HistoryController.kt$HistoryController$fun handleOpen(item: History)
- UndocumentedPublicFunction:HistoryController.kt$HistoryController$fun handleRequestSync()
- UndocumentedPublicFunction:HistoryController.kt$HistoryController$fun handleSearch()
- UndocumentedPublicFunction:HistoryController.kt$HistoryController$fun handleSelect(item: History)
UndocumentedPublicFunction:HistoryItemTimeGroup.kt$HistoryItemTimeGroup$fun humanReadable(context: Context): String
UndocumentedPublicFunction:HistoryMetadataGroupAdapter.kt$HistoryMetadataGroupAdapter$fun updateData(items: List<History.Metadata>)
UndocumentedPublicFunction:HistoryMetadataService.kt$fun TabSessionState.toHistoryMetadataKey(searchTerms: String?, referrerUrl: String?): HistoryMetadataKey
- UndocumentedPublicFunction:HistorySearchController.kt$HistorySearchController$fun handleEditingCancelled()
- UndocumentedPublicFunction:HistorySearchController.kt$HistorySearchController$fun handleTextChanged(text: String)
- UndocumentedPublicFunction:HistorySearchController.kt$HistorySearchController$fun handleUrlTapped(url: String, flags: LoadUrlFlags = LoadUrlFlags.none())
- UndocumentedPublicFunction:HistorySearchFragmentStore.kt$fun createInitialHistorySearchFragmentState(): HistorySearchFragmentState
UndocumentedPublicFunction:HistoryView.kt$HistoryView$fun update(state: HistoryFragmentState)
UndocumentedPublicFunction:HomeActivity.kt$HomeActivity$@Suppress("SpreadOperator") fun setupNavigationToolbar(vararg topLevelDestinationIds: Int)
UndocumentedPublicFunction:HomeActivity.kt$HomeActivity$fun finishActionMode()
@@ -683,7 +660,6 @@
UndocumentedPublicFunction:MetricsService.kt$MetricsService$fun start()
UndocumentedPublicFunction:MetricsService.kt$MetricsService$fun stop()
UndocumentedPublicFunction:MetricsService.kt$MetricsService$fun track(event: Event)
- UndocumentedPublicFunction:Mode.kt$Mode.Companion$fun fromBrowsingMode(browsingMode: BrowsingMode)
UndocumentedPublicFunction:MozillaProductDetector.kt$MozillaProductDetector$fun getInstalledMozillaProducts(context: Context): List<String>
UndocumentedPublicFunction:MozillaProductDetector.kt$MozillaProductDetector$fun packageIsInstalled(context: Context, packageName: String): Boolean
UndocumentedPublicFunction:NavController.kt$fun NavController.alreadyOnDestination(@IdRes destId: Int?): Boolean
@@ -759,7 +735,6 @@
UndocumentedPublicFunction:SearchDialogController.kt$SearchController$fun handleExistingSessionSelected(tabId: String)
UndocumentedPublicFunction:SearchDialogController.kt$SearchController$fun handleSearchEngineSuggestionClicked(searchEngine: SearchEngine)
UndocumentedPublicFunction:SearchDialogController.kt$SearchController$fun handleSearchShortcutEngineSelected(searchEngine: SearchEngine)
- UndocumentedPublicFunction:SearchDialogController.kt$SearchController$fun handleSearchShortcutsButtonClicked()
UndocumentedPublicFunction:SearchDialogController.kt$SearchController$fun handleSearchTermsTapped(searchTerms: String)
UndocumentedPublicFunction:SearchDialogController.kt$SearchController$fun handleTextChanged(text: String)
UndocumentedPublicFunction:SearchDialogController.kt$SearchController$fun handleUrlCommitted(url: String, fromHomeScreen: Boolean = false)
@@ -830,7 +805,6 @@
UndocumentedPublicFunction:StartupTypeTelemetry.kt$StartupTypeTelemetry$fun attachOnHomeActivityOnCreate(lifecycle: Lifecycle)
UndocumentedPublicFunction:StorageStatsMetrics.kt$StorageStatsMetrics$@OptIn(DelicateCoroutinesApi::class) // GlobalScope usage fun report(context: Context)
UndocumentedPublicFunction:StorageStatsMetrics.kt$StorageStatsMetrics$@VisibleForTesting(otherwise = PRIVATE) @WorkerThread // queryStatsForUid fun reportSync(context: Context)
- UndocumentedPublicFunction:StoreProvider.kt$StoreProvider.Companion$fun <T : Store<*, *>> get(owner: ViewModelStoreOwner, createStore: () -> T): T
UndocumentedPublicFunction:StudiesView.kt$StudiesView$@Suppress("TooGenericExceptionCaught", "ApplySharedPref") fun bind()
UndocumentedPublicFunction:SupportUtils.kt$SupportUtils$fun createAuthCustomTabIntent(context: Context, url: String): Intent
UndocumentedPublicFunction:SupportUtils.kt$SupportUtils$fun createCustomTabIntent(context: Context, url: String): Intent
@@ -863,7 +837,6 @@
UndocumentedPublicFunction:ToolbarIntegration.kt$ToolbarIntegration$fun invalidateMenu()
UndocumentedPublicFunction:ToolbarPopupWindow.kt$ToolbarPopupWindow$fun show( view: WeakReference<View>, customTabId: String? = null, handlePasteAndGo: (String) -> Unit, handlePaste: (String) -> Unit, copyVisible: Boolean = true, )
UndocumentedPublicFunction:ToolbarView.kt$ToolbarView$fun update(searchState: SearchFragmentState)
- UndocumentedPublicFunction:ToolbarView.kt$ToolbarView$fun update(state: HistorySearchFragmentState)
UndocumentedPublicFunction:TopPlaceholderViewHolder.kt$TopPlaceholderViewHolder$fun bind()
UndocumentedPublicFunction:TopSiteItemViewHolder.kt$TopSiteItemViewHolder$fun bind(topSite: TopSite, position: Int)
UndocumentedPublicFunction:TopSitePagerViewHolder.kt$TopSitePagerViewHolder$fun bind(topSites: List<TopSite>)