Bug 1822447 - Upgrade RecyclerView Library and remove tab tray thumbnail placeholder (#1691)

* Bug 1822447 - upgrade androidx_recyclerview to 1.3.0

* Bug 1822447 - remove default placeholder imageview from tab tray items

* Bug 1822447 - upgrade androidx_recyclerview in AC to 1.3.0

app/src/androidTest/java/org/mozilla/fenix/ui/robots/TabDrawerRobot.kt

@@ -103,7 +103,7 @@ class TabDrawerRobot {
     fun verifyHalfExpandedRatio() = assertMinisculeHalfExpandedRatio()
     fun verifyBehaviorState(expectedState: Int) = assertBehaviorState(expectedState)
     fun verifyOpenedTabThumbnail() =
-        assertItemWithResIdExists(itemWithResId("$packageName:id/default_tab_thumbnail"))
+        assertItemWithResIdExists(itemWithResId("$packageName:id/mozac_browser_tabstray_thumbnail"))
 
     fun closeTab() {
         closeTabButton().waitForExists(waitingTime)

app/src/main/java/org/mozilla/fenix/compose/ComposeViewHolder.kt

@@ -6,7 +6,6 @@ package org.mozilla.fenix.compose
 
 import androidx.compose.runtime.Composable
 import androidx.compose.ui.platform.ComposeView
-import androidx.compose.ui.platform.ViewCompositionStrategy
 import androidx.lifecycle.LifecycleOwner
 import androidx.lifecycle.setViewTreeLifecycleOwner
 import androidx.recyclerview.widget.RecyclerView
@@ -38,9 +37,6 @@ abstract class ComposeViewHolder(
     open val allowPrivateTheme: Boolean = true
 
     init {
-        composeView.setViewCompositionStrategy(
-            ViewCompositionStrategy.DisposeOnViewTreeLifecycleDestroyed,
-        )
         composeView.setContent {
             FirefoxTheme(theme = Theme.getTheme(allowPrivateTheme = allowPrivateTheme)) {
                 Content()

app/src/main/res/layout/tab_tray_grid_item.xml

@@ -96,15 +96,6 @@ A FrameLayout here is an efficient way of having a views stack while allowing:
                 app:layout_constraintStart_toStartOf="parent"
                 app:layout_constraintTop_toBottomOf="@+id/horizonatal_divider">
 
-                <ImageView
-                    android:id="@+id/default_tab_thumbnail"
-                    android:layout_width="match_parent"
-                    android:layout_height="match_parent"
-                    android:importantForAccessibility="no"
-                    android:padding="22dp"
-                    app:srcCompat="@drawable/mozac_ic_globe"
-                    app:tint="?iconSecondary" />
-
                 <mozilla.components.browser.tabstray.thumbnail.TabThumbnailView
                     android:id="@+id/mozac_browser_tabstray_thumbnail"
                     android:layout_width="match_parent"

app/src/main/res/layout/tab_tray_item.xml

@@ -37,15 +37,6 @@
         app:layout_constraintStart_toStartOf="parent"
         app:layout_constraintTop_toTopOf="parent">
 
-        <ImageView
-            android:id="@+id/default_tab_thumbnail"
-            android:layout_width="match_parent"
-            android:layout_height="match_parent"
-            android:importantForAccessibility="no"
-            android:padding="22dp"
-            app:srcCompat="@drawable/mozac_ic_globe"
-            app:tint="?iconSecondary" />
-
         <mozilla.components.browser.tabstray.thumbnail.TabThumbnailView
             android:id="@+id/mozac_browser_tabstray_thumbnail"
             android:layout_width="match_parent"

buildSrc/src/main/java/FenixDependencies.kt

@@ -3,7 +3,7 @@
  * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
 
 // If you ever need to force a toolchain rebuild (taskcluster) then edit the following comment.
-// FORCE REBUILD 2023-05-04
+// FORCE REBUILD 2023-05-05
 
 object FenixVersions {
     const val kotlin = "1.8.21"
@@ -34,7 +34,7 @@ object FenixVersions {
     const val androidx_lifecycle = "2.6.1"
     const val androidx_fragment = "1.5.7"
     const val androidx_navigation = "2.5.3"
-    const val androidx_recyclerview = "1.2.1"
+    const val androidx_recyclerview = "1.3.0"
     const val androidx_core = "1.10.0"
     const val androidx_paging = "3.1.1"
     const val androidx_transition = "1.4.1"