diff --git a/app/src/main/java/org/mozilla/fenix/GlobalDirections.kt b/app/src/main/java/org/mozilla/fenix/GlobalDirections.kt index 315f673b4..86987b08e 100644 --- a/app/src/main/java/org/mozilla/fenix/GlobalDirections.kt +++ b/app/src/main/java/org/mozilla/fenix/GlobalDirections.kt @@ -13,7 +13,7 @@ import androidx.navigation.NavDirections * @property destinationId fragment ID of the fragment being navigated to */ enum class GlobalDirections(val navDirections: NavDirections, val destinationId: Int) { - Home(NavGraphDirections.actionGlobalHomeFragment(), R.id.homeFragment), + Home(NavGraphDirections.actionGlobalHome(), R.id.homeFragment), Settings( NavGraphDirections.actionGlobalSettingsFragment(), R.id.settingsFragment diff --git a/app/src/main/java/org/mozilla/fenix/HomeActivity.kt b/app/src/main/java/org/mozilla/fenix/HomeActivity.kt index bd5a521b0..627826a3a 100644 --- a/app/src/main/java/org/mozilla/fenix/HomeActivity.kt +++ b/app/src/main/java/org/mozilla/fenix/HomeActivity.kt @@ -328,31 +328,23 @@ open class HomeActivity : LocaleAwareAppCompatActivity() { BrowserDirection.FromHome -> HomeFragmentDirections.actionHomeFragmentToBrowserFragment(customTabSessionId, true) BrowserDirection.FromSearch -> - SearchFragmentDirections.actionSearchFragmentToBrowserFragment(customTabSessionId) + SearchFragmentDirections.actionGlobalBrowser(customTabSessionId) BrowserDirection.FromSettings -> - SettingsFragmentDirections.actionSettingsFragmentToBrowserFragment(customTabSessionId) + SettingsFragmentDirections.actionGlobalBrowser(customTabSessionId) BrowserDirection.FromBookmarks -> - BookmarkFragmentDirections.actionBookmarkFragmentToBrowserFragment(customTabSessionId) + BookmarkFragmentDirections.actionGlobalBrowser(customTabSessionId) BrowserDirection.FromHistory -> - HistoryFragmentDirections.actionHistoryFragmentToBrowserFragment(customTabSessionId) + HistoryFragmentDirections.actionGlobalBrowser(customTabSessionId) BrowserDirection.FromExceptions -> - ExceptionsFragmentDirections.actionExceptionsFragmentToBrowserFragment( - customTabSessionId - ) + ExceptionsFragmentDirections.actionGlobalBrowser(customTabSessionId) BrowserDirection.FromAbout -> - AboutFragmentDirections.actionAboutFragmentToBrowserFragment(customTabSessionId) + AboutFragmentDirections.actionGlobalBrowser(customTabSessionId) BrowserDirection.FromTrackingProtection -> - TrackingProtectionFragmentDirections.actionTrackingProtectionFragmentToBrowserFragment( - customTabSessionId - ) + TrackingProtectionFragmentDirections.actionGlobalBrowser(customTabSessionId) BrowserDirection.FromDefaultBrowserSettingsFragment -> - DefaultBrowserSettingsFragmentDirections.actionDefaultBrowserSettingsFragmentToBrowserFragment( - customTabSessionId - ) + DefaultBrowserSettingsFragmentDirections.actionGlobalBrowser(customTabSessionId) BrowserDirection.FromSavedLoginsFragment -> - SavedLoginsFragmentDirections.actionSavedLoginsFragmentToBrowserFragment( - customTabSessionId - ) + SavedLoginsFragmentDirections.actionGlobalBrowser(customTabSessionId) } private fun load( diff --git a/app/src/main/java/org/mozilla/fenix/browser/BaseBrowserFragment.kt b/app/src/main/java/org/mozilla/fenix/browser/BaseBrowserFragment.kt index 67ce80675..f4796dbd4 100644 --- a/app/src/main/java/org/mozilla/fenix/browser/BaseBrowserFragment.kt +++ b/app/src/main/java/org/mozilla/fenix/browser/BaseBrowserFragment.kt @@ -766,7 +766,7 @@ abstract class BaseBrowserFragment : Fragment(), UserInteractionHandler, Session withContext(Main) { nav( R.id.browserFragment, - BrowserFragmentDirections.actionBrowserFragmentToBookmarkEditFragment(existing.guid) + BrowserFragmentDirections.actionGlobalBookmarkEditFragment(existing.guid) ) } } else { @@ -791,9 +791,7 @@ abstract class BaseBrowserFragment : Fragment(), UserInteractionHandler, Session .setAction(getString(R.string.edit_bookmark_snackbar_action)) { nav( R.id.browserFragment, - BrowserFragmentDirections.actionBrowserFragmentToBookmarkEditFragment( - guid - ) + BrowserFragmentDirections.actionGlobalBookmarkEditFragment(guid) ) } .show() diff --git a/app/src/main/java/org/mozilla/fenix/components/toolbar/BrowserToolbarController.kt b/app/src/main/java/org/mozilla/fenix/components/toolbar/BrowserToolbarController.kt index bc0cc121a..4879e7bef 100644 --- a/app/src/main/java/org/mozilla/fenix/components/toolbar/BrowserToolbarController.kt +++ b/app/src/main/java/org/mozilla/fenix/components/toolbar/BrowserToolbarController.kt @@ -221,8 +221,7 @@ class DefaultBrowserToolbarController( ToolbarMenu.Item.AddonsManager -> { navController.nav( R.id.browserFragment, - BrowserFragmentDirections - .actionBrowserFragmentToAddonsManagementFragment() + BrowserFragmentDirections.actionGlobalAddonsManagementFragment() ) } ToolbarMenu.Item.SaveToCollection -> { @@ -231,7 +230,7 @@ class DefaultBrowserToolbarController( currentSession?.let { currentSession -> val directions = - BrowserFragmentDirections.actionBrowserFragmentToCreateCollectionFragment( + BrowserFragmentDirections.actionGlobalCollectionCreationFragment( previousFragmentId = R.id.browserFragment, tabIds = arrayOf(currentSession.id), selectedTabIds = arrayOf(currentSession.id), @@ -316,11 +315,9 @@ class DefaultBrowserToolbarController( // before we transition the fragment. This makes the animation feel smoother delay(ANIMATION_DELAY) if (!navController.popBackStack(R.id.homeFragment, false)) { - val directions = BrowserFragmentDirections.actionBrowserFragmentToHomeFragment() navController.nav( R.id.browserFragment, - directions, - null + BrowserFragmentDirections.actionGlobalHome() ) } } diff --git a/app/src/main/java/org/mozilla/fenix/crashes/CrashReporterController.kt b/app/src/main/java/org/mozilla/fenix/crashes/CrashReporterController.kt index 795101d2b..fba8d2f39 100644 --- a/app/src/main/java/org/mozilla/fenix/crashes/CrashReporterController.kt +++ b/app/src/main/java/org/mozilla/fenix/crashes/CrashReporterController.kt @@ -55,9 +55,10 @@ class CrashReporterController( components.useCases.tabsUseCases.removeTab(session) components.useCases.sessionUseCases.crashRecovery.invoke() + navController.nav( R.id.crashReporterFragment, - CrashReporterFragmentDirections.actionCrashReporterFragmentToHomeFragment() + CrashReporterFragmentDirections.actionGlobalHome() ) return job diff --git a/app/src/main/java/org/mozilla/fenix/customtabs/ExternalAppBrowserFragment.kt b/app/src/main/java/org/mozilla/fenix/customtabs/ExternalAppBrowserFragment.kt index b6bc5b364..c23c72e5b 100644 --- a/app/src/main/java/org/mozilla/fenix/customtabs/ExternalAppBrowserFragment.kt +++ b/app/src/main/java/org/mozilla/fenix/customtabs/ExternalAppBrowserFragment.kt @@ -172,7 +172,7 @@ class ExternalAppBrowserFragment : BaseBrowserFragment(), UserInteractionHandler override fun navToQuickSettingsSheet(session: Session, sitePermissions: SitePermissions?) { val directions = ExternalAppBrowserFragmentDirections - .actionExternalAppBrowserFragmentToQuickSettingsSheetDialogFragment( + .actionGlobalQuickSettingsSheetDialogFragment( sessionId = session.id, url = session.url, title = session.title, @@ -193,7 +193,7 @@ class ExternalAppBrowserFragment : BaseBrowserFragment(), UserInteractionHandler val isEnabled = session.trackerBlockingEnabled && !contains val directions = ExternalAppBrowserFragmentDirections - .actionExternalAppBrowserFragmentToTrackingProtectionPanelDialogFragment( + .actionGlobalTrackingProtectionPanelDialogFragment( sessionId = session.id, url = session.url, trackingProtectionEnabled = isEnabled, diff --git a/app/src/main/java/org/mozilla/fenix/home/HomeFragment.kt b/app/src/main/java/org/mozilla/fenix/home/HomeFragment.kt index e315b94a7..e1837f497 100644 --- a/app/src/main/java/org/mozilla/fenix/home/HomeFragment.kt +++ b/app/src/main/java/org/mozilla/fenix/home/HomeFragment.kt @@ -582,7 +582,7 @@ class HomeFragment : Fragment() { } private fun navigateToSearch() { - val directions = HomeFragmentDirections.actionHomeFragmentToSearchFragment( + val directions = HomeFragmentDirections.actionGlobalSearch( sessionId = null ) @@ -590,7 +590,7 @@ class HomeFragment : Fragment() { } private fun openSettingsScreen() { - val directions = HomeFragmentDirections.actionHomeFragmentToPrivateBrowsingFragment() + val directions = HomeFragmentDirections.actionGlobalPrivateBrowsingFragment() nav(R.id.homeFragment, directions) } @@ -612,7 +612,7 @@ class HomeFragment : Fragment() { hideOnboardingIfNeeded() nav( R.id.homeFragment, - HomeFragmentDirections.actionHomeFragmentToSettingsFragment() + HomeFragmentDirections.actionGlobalSettingsFragment() ) } HomeMenu.Item.Bookmarks -> { @@ -620,7 +620,7 @@ class HomeFragment : Fragment() { hideOnboardingIfNeeded() nav( R.id.homeFragment, - HomeFragmentDirections.actionHomeFragmentToBookmarksFragment(BookmarkRoot.Mobile.id) + HomeFragmentDirections.actionGlobalBookmarkFragment(BookmarkRoot.Mobile.id) ) } HomeMenu.Item.History -> { @@ -628,7 +628,7 @@ class HomeFragment : Fragment() { hideOnboardingIfNeeded() nav( R.id.homeFragment, - HomeFragmentDirections.actionHomeFragmentToHistoryFragment() + HomeFragmentDirections.actionGlobalHistoryFragment() ) } HomeMenu.Item.Help -> { @@ -673,7 +673,7 @@ class HomeFragment : Fragment() { hideOnboardingIfNeeded() nav( R.id.homeFragment, - HomeFragmentDirections.actionHomeFragmentToAccountProblemFragment() + HomeFragmentDirections.actionGlobalAccountProblemFragment() ) } } diff --git a/app/src/main/java/org/mozilla/fenix/home/sessioncontrol/SessionControlController.kt b/app/src/main/java/org/mozilla/fenix/home/sessioncontrol/SessionControlController.kt index 74c89da65..e568c1457 100644 --- a/app/src/main/java/org/mozilla/fenix/home/sessioncontrol/SessionControlController.kt +++ b/app/src/main/java/org/mozilla/fenix/home/sessioncontrol/SessionControlController.kt @@ -408,7 +408,7 @@ class DefaultSessionControlController( } private fun showShareFragment(data: List) { - val directions = HomeFragmentDirections.actionHomeFragmentToShareFragment( + val directions = HomeFragmentDirections.actionGlobalShareFragment( data = data.toTypedArray() ) navController.nav(R.id.homeFragment, directions) diff --git a/app/src/main/java/org/mozilla/fenix/home/sessioncontrol/viewholders/onboarding/OnboardingManualSignInViewHolder.kt b/app/src/main/java/org/mozilla/fenix/home/sessioncontrol/viewholders/onboarding/OnboardingManualSignInViewHolder.kt index db5ff8c6b..9b1189d2d 100644 --- a/app/src/main/java/org/mozilla/fenix/home/sessioncontrol/viewholders/onboarding/OnboardingManualSignInViewHolder.kt +++ b/app/src/main/java/org/mozilla/fenix/home/sessioncontrol/viewholders/onboarding/OnboardingManualSignInViewHolder.kt @@ -17,7 +17,7 @@ import org.mozilla.fenix.home.HomeFragmentDirections class OnboardingManualSignInViewHolder(private val view: View) : RecyclerView.ViewHolder(view) { init { view.turn_on_sync_button.setOnClickListener { - val directions = HomeFragmentDirections.actionHomeFragmentToTurnOnSyncFragment() + val directions = HomeFragmentDirections.actionGlobalTurnOnSync() Navigation.findNavController(view).navigate(directions) } } diff --git a/app/src/main/java/org/mozilla/fenix/library/bookmarks/BookmarkController.kt b/app/src/main/java/org/mozilla/fenix/library/bookmarks/BookmarkController.kt index a8c1caefb..8c4d191db 100644 --- a/app/src/main/java/org/mozilla/fenix/library/bookmarks/BookmarkController.kt +++ b/app/src/main/java/org/mozilla/fenix/library/bookmarks/BookmarkController.kt @@ -85,7 +85,7 @@ class DefaultBookmarkController( override fun handleBookmarkSharing(item: BookmarkNode) { navigate( - BookmarkFragmentDirections.actionBookmarkFragmentToShareFragment( + BookmarkFragmentDirections.actionGlobalShareFragment( data = arrayOf(ShareData(url = item.url, title = item.title)) ) ) diff --git a/app/src/main/java/org/mozilla/fenix/library/bookmarks/BookmarkFragment.kt b/app/src/main/java/org/mozilla/fenix/library/bookmarks/BookmarkFragment.kt index 7075a1951..054394561 100644 --- a/app/src/main/java/org/mozilla/fenix/library/bookmarks/BookmarkFragment.kt +++ b/app/src/main/java/org/mozilla/fenix/library/bookmarks/BookmarkFragment.kt @@ -186,14 +186,14 @@ class BookmarkFragment : LibraryPageFragment(), UserInteractionHan R.id.open_bookmarks_in_new_tabs_multi_select -> { openItemsInNewTab { node -> node.url } - navigate(BookmarkFragmentDirections.actionBookmarkFragmentToHomeFragment()) + navigate(BookmarkFragmentDirections.actionGlobalHome()) metrics?.track(Event.OpenedBookmarksInNewTabs) true } R.id.open_bookmarks_in_private_tabs_multi_select -> { openItemsInNewTab(private = true) { node -> node.url } - navigate(BookmarkFragmentDirections.actionBookmarkFragmentToHomeFragment()) + navigate(BookmarkFragmentDirections.actionGlobalHome()) metrics?.track(Event.OpenedBookmarksInPrivateTabs) true } @@ -202,7 +202,7 @@ class BookmarkFragment : LibraryPageFragment(), UserInteractionHan ShareData(url = it.url, title = it.title) } navigate( - BookmarkFragmentDirections.actionBookmarkFragmentToShareFragment( + BookmarkFragmentDirections.actionGlobalShareFragment( data = shareTabs.toTypedArray() ) ) @@ -218,7 +218,10 @@ class BookmarkFragment : LibraryPageFragment(), UserInteractionHan private fun navigate(directions: NavDirections) { invokePendingDeletion() - nav(R.id.bookmarkFragment, directions) + findNavController().nav( + R.id.bookmarkFragment, + directions + ) } override fun onBackPressed(): Boolean { diff --git a/app/src/main/java/org/mozilla/fenix/library/history/HistoryController.kt b/app/src/main/java/org/mozilla/fenix/library/history/HistoryController.kt index 48733b5ca..0d47d73f7 100644 --- a/app/src/main/java/org/mozilla/fenix/library/history/HistoryController.kt +++ b/app/src/main/java/org/mozilla/fenix/library/history/HistoryController.kt @@ -82,7 +82,7 @@ class DefaultHistoryController( override fun handleShare(item: HistoryItem) { navController.navigate( - HistoryFragmentDirections.actionHistoryFragmentToShareFragment( + HistoryFragmentDirections.actionGlobalShareFragment( data = arrayOf(ShareData(url = item.url, title = item.title)) ) ) diff --git a/app/src/main/java/org/mozilla/fenix/library/history/HistoryFragment.kt b/app/src/main/java/org/mozilla/fenix/library/history/HistoryFragment.kt index 4c9ec5caa..460435f5c 100644 --- a/app/src/main/java/org/mozilla/fenix/library/history/HistoryFragment.kt +++ b/app/src/main/java/org/mozilla/fenix/library/history/HistoryFragment.kt @@ -170,7 +170,7 @@ class HistoryFragment : LibraryPageFragment(), UserInteractionHandl nav( R.id.historyFragment, - HistoryFragmentDirections.actionHistoryFragmentToHomeFragment() + HistoryFragmentDirections.actionGlobalHome() ) true } @@ -186,7 +186,7 @@ class HistoryFragment : LibraryPageFragment(), UserInteractionHandl } nav( R.id.historyFragment, - HistoryFragmentDirections.actionHistoryFragmentToHomeFragment() + HistoryFragmentDirections.actionGlobalHome() ) true } @@ -245,7 +245,7 @@ class HistoryFragment : LibraryPageFragment(), UserInteractionHandl private fun share(data: List) { requireComponents.analytics.metrics.track(Event.HistoryItemShared) - val directions = HistoryFragmentDirections.actionHistoryFragmentToShareFragment( + val directions = HistoryFragmentDirections.actionGlobalShareFragment( data = data.toTypedArray() ) nav(R.id.historyFragment, directions) diff --git a/app/src/main/java/org/mozilla/fenix/search/SearchController.kt b/app/src/main/java/org/mozilla/fenix/search/SearchController.kt index 49f66e301..a1f0a5e51 100644 --- a/app/src/main/java/org/mozilla/fenix/search/SearchController.kt +++ b/app/src/main/java/org/mozilla/fenix/search/SearchController.kt @@ -160,7 +160,7 @@ class DefaultSearchController( } override fun handleClickSearchEngineSettings() { - val directions = SearchFragmentDirections.actionSearchFragmentToSearchEngineFragment() + val directions = SearchFragmentDirections.actionGlobalSearchEngineFragment() navController.navigateSafe(R.id.searchFragment, directions) } diff --git a/app/src/main/java/org/mozilla/fenix/settings/LoginsFragment.kt b/app/src/main/java/org/mozilla/fenix/settings/LoginsFragment.kt index 4337f41f4..4d9f8c467 100644 --- a/app/src/main/java/org/mozilla/fenix/settings/LoginsFragment.kt +++ b/app/src/main/java/org/mozilla/fenix/settings/LoginsFragment.kt @@ -271,12 +271,12 @@ class LoginsFragment : PreferenceFragmentCompat(), AccountObserver { private fun navigateToAccountSettingsFragment() { val directions = - LoginsFragmentDirections.actionLoginsFragmentToAccountSettingsFragment() + LoginsFragmentDirections.actionGlobalAccountSettingsFragment() findNavController().navigate(directions) } private fun navigateToAccountProblemFragment() { - val directions = LoginsFragmentDirections.actionLoginsFragmentToAccountProblemFragment() + val directions = LoginsFragmentDirections.actionGlobalAccountProblemFragment() findNavController().navigate(directions) } diff --git a/app/src/main/java/org/mozilla/fenix/settings/deletebrowsingdata/DeleteBrowsingDataFragment.kt b/app/src/main/java/org/mozilla/fenix/settings/deletebrowsingdata/DeleteBrowsingDataFragment.kt index 6a5692b3a..64b71e130 100644 --- a/app/src/main/java/org/mozilla/fenix/settings/deletebrowsingdata/DeleteBrowsingDataFragment.kt +++ b/app/src/main/java/org/mozilla/fenix/settings/deletebrowsingdata/DeleteBrowsingDataFragment.kt @@ -147,7 +147,13 @@ class DeleteBrowsingDataFragment : Fragment(R.layout.fragment_delete_browsing_da if (popAfter) viewLifecycleOwner.lifecycleScope.launch( Dispatchers.Main ) { - returnToDeletionOrigin() + + findNavController().apply { + // If the user deletes all open tabs we need to make sure we remove + // the BrowserFragment from the backstack. + popBackStack(R.id.homeFragment, false) + navigate(DeleteBrowsingDataFragmentDirections.actionGlobalSettingsFragment()) + } } } @@ -214,11 +220,6 @@ class DeleteBrowsingDataFragment : Fragment(R.layout.fragment_delete_browsing_da ) } - private fun returnToDeletionOrigin() { - val directions = DeleteBrowsingDataFragmentDirections.actionDeleteBrowsingDataFragmentToSettingsFragment() - findNavController().navigate(directions) - } - companion object { private const val ENABLED_ALPHA = 1f private const val DISABLED_ALPHA = 0.6f diff --git a/app/src/main/java/org/mozilla/fenix/settings/quicksettings/QuickSettingsController.kt b/app/src/main/java/org/mozilla/fenix/settings/quicksettings/QuickSettingsController.kt index ba8b92a1a..5503334b5 100644 --- a/app/src/main/java/org/mozilla/fenix/settings/quicksettings/QuickSettingsController.kt +++ b/app/src/main/java/org/mozilla/fenix/settings/quicksettings/QuickSettingsController.kt @@ -208,7 +208,7 @@ class DefaultQuickSettingsController( */ private fun navigateToManagePhoneFeature(phoneFeature: PhoneFeature) { val directions = QuickSettingsSheetDialogFragmentDirections - .actionQuickSettingsSheetDialogFragmentToSitePermissionsManagePhoneFeature(phoneFeature.id) + .actionGlobalSitePermissionsManagePhoneFeature(phoneFeature.id) navController.navigate(directions) } } diff --git a/app/src/main/java/org/mozilla/fenix/share/ShareController.kt b/app/src/main/java/org/mozilla/fenix/share/ShareController.kt index 553ee877c..fd5df71a7 100644 --- a/app/src/main/java/org/mozilla/fenix/share/ShareController.kt +++ b/app/src/main/java/org/mozilla/fenix/share/ShareController.kt @@ -73,7 +73,7 @@ class DefaultShareController( ) : ShareController { override fun handleReauth() { - val directions = ShareFragmentDirections.actionShareFragmentToAccountProblemFragment() + val directions = ShareFragmentDirections.actionGlobalAccountProblemFragment() navController.nav(R.id.shareFragment, directions) dismiss(ShareController.Result.DISMISSED) } @@ -123,7 +123,7 @@ class DefaultShareController( override fun handleSignIn() { context.metrics.track(Event.SignInToSendTab) val directions = - ShareFragmentDirections.actionShareFragmentToTurnOnSyncFragment(padSnackbar = true) + ShareFragmentDirections.actionGlobalTurnOnSync(padSnackbar = true) navController.nav(R.id.shareFragment, directions) dismiss(ShareController.Result.DISMISSED) } diff --git a/app/src/main/java/org/mozilla/fenix/trackingprotection/TrackingProtectionPanelDialogFragment.kt b/app/src/main/java/org/mozilla/fenix/trackingprotection/TrackingProtectionPanelDialogFragment.kt index aa6773eb4..8791d3e07 100644 --- a/app/src/main/java/org/mozilla/fenix/trackingprotection/TrackingProtectionPanelDialogFragment.kt +++ b/app/src/main/java/org/mozilla/fenix/trackingprotection/TrackingProtectionPanelDialogFragment.kt @@ -143,8 +143,7 @@ class TrackingProtectionPanelDialogFragment : AppCompatDialogFragment(), UserInt requireContext().metrics.track(Event.TrackingProtectionSettingsPanel) nav( R.id.trackingProtectionPanelDialogFragment, - TrackingProtectionPanelDialogFragmentDirections - .actionTrackingProtectionPanelDialogFragmentToTrackingProtectionFragment() + TrackingProtectionPanelDialogFragmentDirections.actionGlobalTrackingProtectionFragment() ) } diff --git a/app/src/main/res/navigation/nav_graph.xml b/app/src/main/res/navigation/nav_graph.xml index 7691cfb3b..afac71fe8 100644 --- a/app/src/main/res/navigation/nav_graph.xml +++ b/app/src/main/res/navigation/nav_graph.xml @@ -5,11 +5,16 @@ android:id="@+id/nav_graph" app:startDestination="@id/homeFragment"> + + + app:popUpToInclusive="false" /> - - - - - - - - - - - - - - - - - + + + + + + + + + + + + + + + + + + + + + + - - - - - - - - - - - - - - - - - - - - - - - + tools:layout="@layout/fragment_history" /> - - - @@ -342,9 +250,6 @@ android:name="visitedAddBookmark" android:defaultValue="false" app:argType="boolean" /> - - - - - - + android:name="org.mozilla.fenix.settings.about.AboutFragment"/> - @@ -637,29 +516,15 @@ app:popEnterAnim="@anim/slide_in_left" app:popExitAnim="@anim/slide_out_right" app:destination="@id/trackingProtectionBlockingFragment" /> - - - + android:label="@string/preferences_delete_browsing_data" /> - - + android:label="@string/preference_exceptions"/> - - @@ -754,10 +611,6 @@ android:name="certificateName" android:defaultValue=" " app:argType="string" /> - - @@ -788,9 +638,6 @@ android:name="gravity" android:defaultValue="80" app:argType="integer" /> - - - + android:name="org.mozilla.fenix.settings.DefaultBrowserSettingsFragment"/> - ).size) assertEquals(historyItem.title, (directions.captured.arguments["data"] as Array)[0].title) diff --git a/app/src/test/java/org/mozilla/fenix/search/DefaultSearchControllerTest.kt b/app/src/test/java/org/mozilla/fenix/search/DefaultSearchControllerTest.kt index cef1a0d39..6a36bcd9d 100644 --- a/app/src/test/java/org/mozilla/fenix/search/DefaultSearchControllerTest.kt +++ b/app/src/test/java/org/mozilla/fenix/search/DefaultSearchControllerTest.kt @@ -236,7 +236,7 @@ class DefaultSearchControllerTest { @Test fun handleClickSearchEngineSettings() { val directions: NavDirections = - SearchFragmentDirections.actionSearchFragmentToSearchEngineFragment() + SearchFragmentDirections.actionGlobalSearchEngineFragment() controller.handleClickSearchEngineSettings() diff --git a/app/src/test/java/org/mozilla/fenix/search/SearchInteractorTest.kt b/app/src/test/java/org/mozilla/fenix/search/SearchInteractorTest.kt index bf70de493..e92a38f9b 100644 --- a/app/src/test/java/org/mozilla/fenix/search/SearchInteractorTest.kt +++ b/app/src/test/java/org/mozilla/fenix/search/SearchInteractorTest.kt @@ -276,7 +276,7 @@ class SearchInteractorTest { verify { navController.navigateSafe( R.id.searchFragment, - SearchFragmentDirections.actionSearchFragmentToSearchEngineFragment() + SearchFragmentDirections.actionGlobalSearchEngineFragment() ) } } diff --git a/app/src/test/java/org/mozilla/fenix/share/ShareControllerTest.kt b/app/src/test/java/org/mozilla/fenix/share/ShareControllerTest.kt index ba25848ce..9494430e6 100644 --- a/app/src/test/java/org/mozilla/fenix/share/ShareControllerTest.kt +++ b/app/src/test/java/org/mozilla/fenix/share/ShareControllerTest.kt @@ -191,7 +191,7 @@ class ShareControllerTest { metrics.track(Event.SignInToSendTab) navController.nav( R.id.shareFragment, - ShareFragmentDirections.actionShareFragmentToTurnOnSyncFragment() + ShareFragmentDirections.actionGlobalTurnOnSync() ) dismiss(ShareController.Result.DISMISSED) } @@ -204,7 +204,7 @@ class ShareControllerTest { verifyOrder { navController.nav( R.id.shareFragment, - ShareFragmentDirections.actionShareFragmentToAccountProblemFragment() + ShareFragmentDirections.actionGlobalAccountProblemFragment() ) dismiss(ShareController.Result.DISMISSED) }