From 51d10734c7e51fe2cf23d8a5e6fa5a557dc94501 Mon Sep 17 00:00:00 2001 From: Michael Comella <759372+mcomella@users.noreply.github.com> Date: Thu, 13 May 2021 18:18:59 -0700 Subject: [PATCH] Closes #19496: Remove glean metrics docs check from pre-push hook. (#19497) --- config/pre-push-recommended.sh | 18 ------------------ 1 file changed, 18 deletions(-) diff --git a/config/pre-push-recommended.sh b/config/pre-push-recommended.sh index 9d140ce3d..aae279a29 100755 --- a/config/pre-push-recommended.sh +++ b/config/pre-push-recommended.sh @@ -14,24 +14,6 @@ # Descriptions for each gradle task below can be found in the # output of `./gradlew tasks`. -# Prevent push if generated glean docs are not committed. -# A better implementation would make sure these doc updates -# only came from this commit. -./gradlew -q \ - gleanGenerateMetricsDocsForDebug \ - gleanGenerateMetricsSourceForDebug -if git status --porcelain=v1 | grep -q "docs/metrics.md"; then - echo " -FAIL pre-push hook: generated glean file, docs/metrics.md, has uncommitted changes. -Please commit these files and try again. - -This check tries to prevent these generated files from being uncommitted on master. -However, it may fail unintuitively if we're in that state. If this happens often -and is disruptive to your workflow, please notify mcomella so we can improve this -check." >&2 - exit 1 -fi - # Run core checks. ./gradlew -q \ ktlint \