For #18270 - Adds ellipses+last 4 digits to CC display (#19420)

* For #18270 - Adds ellipses+last 4 digits to CC display

app/src/main/java/org/mozilla/fenix/settings/creditcards/view/CreditCardItemViewHolder.kt

@@ -23,9 +23,7 @@ class CreditCardItemViewHolder(
 ) : ViewHolder(view) {
 
     fun bind(creditCard: CreditCard) {
-        // TODO this should be last4 instead...
-        //  and option to explicitly decrypt if necessary to show full number
-        credit_card_number.text = creditCard.encryptedCardNumber.number
+        credit_card_number.text = creditCard.obfuscatedCardNumber
 
         bindCreditCardExpiryDate(creditCard)
 

app/src/test/java/org/mozilla/fenix/settings/creditcards/CreditCardItemViewHolderTest.kt

@@ -50,7 +50,7 @@ class CreditCardItemViewHolderTest {
     fun `GIVEN a new credit card item on bind THEN set the card number and expiry date text`() {
         CreditCardItemViewHolder(view, interactor).bind(creditCard)
 
-        assertEquals(creditCard.encryptedCardNumber.number, view.credit_card_number.text)
+        assertEquals(creditCard.obfuscatedCardNumber, view.credit_card_number.text)
         assertEquals("0${creditCard.expiryMonth}/${creditCard.expiryYear}", view.expiry_date.text)
     }