For #21574: disabled the homescreen onboarding dialog.

upstream-sync
Arturo Mejia 3 years ago committed by mergify[bot]
parent fb732cc953
commit 7e3a2ba89d

@ -12,7 +12,7 @@
"value": {
"sections-enabled": {
"topSites": true,
"recentExplorations": true,
"recentExplorations": false,
"recentlySaved": false,
"jumpBackIn": false,
"pocket": false

@ -85,4 +85,9 @@ object FeatureFlags {
return "en-US" == LocaleManager.getCurrentLocale(context)
?.toLanguageTag() ?: getSystemDefault().toLanguageTag()
}
/**
* Enables showing the homescreen onboarding card.
*/
const val showHomeOnboarding = false
}

@ -27,6 +27,7 @@ import mozilla.components.feature.top.sites.TopSite
import mozilla.components.support.ktx.android.view.showKeyboard
import mozilla.components.support.ktx.kotlin.isUrl
import org.mozilla.fenix.BrowserDirection
import org.mozilla.fenix.FeatureFlags
import org.mozilla.fenix.HomeActivity
import org.mozilla.fenix.R
import org.mozilla.fenix.browser.BrowserFragmentDirections
@ -454,10 +455,12 @@ class DefaultSessionControlController(
}
override fun handleShowOnboardingDialog() {
navController.nav(
R.id.homeFragment,
HomeFragmentDirections.actionGlobalHomeOnboardingDialog()
)
if (FeatureFlags.showHomeOnboarding) {
navController.nav(
R.id.homeFragment,
HomeFragmentDirections.actionGlobalHomeOnboardingDialog()
)
}
}
override fun handleReadPrivacyNoticeClicked() {

@ -178,6 +178,7 @@ class DefaultSessionControlControllerTest {
}
@Test
@Ignore("Until the feature is enabled again")
fun handleShowOnboardingDialog() {
createController().handleShowOnboardingDialog()

Loading…
Cancel
Save