diff --git a/app/src/main/java/org/mozilla/fenix/library/history/viewholders/HistoryListItemViewHolder.kt b/app/src/main/java/org/mozilla/fenix/library/history/viewholders/HistoryListItemViewHolder.kt
index 8e4a177282..720c90d093 100644
--- a/app/src/main/java/org/mozilla/fenix/library/history/viewholders/HistoryListItemViewHolder.kt
+++ b/app/src/main/java/org/mozilla/fenix/library/history/viewholders/HistoryListItemViewHolder.kt
@@ -33,10 +33,13 @@ class HistoryListItemViewHolder(
historyInteractor.onRecentlyClosedClicked()
}
- binding.historyLayout.overflowView.setImageResource(R.drawable.ic_close)
- binding.historyLayout.overflowView.setOnClickListener {
- val item = this.item ?: return@setOnClickListener
- historyInteractor.onDeleteSome(setOf(item))
+ binding.historyLayout.overflowView.apply {
+ setImageResource(R.drawable.ic_close)
+ contentDescription = view.context.getString(R.string.history_delete_item)
+ setOnClickListener {
+ val item = item ?: return@setOnClickListener
+ historyInteractor.onDeleteSome(setOf(item))
+ }
}
}
diff --git a/app/src/main/java/org/mozilla/fenix/library/historymetadata/view/HistoryMetadataGroupItemViewHolder.kt b/app/src/main/java/org/mozilla/fenix/library/historymetadata/view/HistoryMetadataGroupItemViewHolder.kt
index 1f5c9fc65d..e721a461bb 100644
--- a/app/src/main/java/org/mozilla/fenix/library/historymetadata/view/HistoryMetadataGroupItemViewHolder.kt
+++ b/app/src/main/java/org/mozilla/fenix/library/historymetadata/view/HistoryMetadataGroupItemViewHolder.kt
@@ -28,10 +28,13 @@ class HistoryMetadataGroupItemViewHolder(
private var item: History.Metadata? = null
init {
- binding.historyLayout.overflowView.setImageResource(R.drawable.ic_close)
- binding.historyLayout.overflowView.setOnClickListener {
- val item = this.item ?: return@setOnClickListener
- interactor.onDelete(setOf(item))
+ binding.historyLayout.overflowView.apply {
+ setImageResource(R.drawable.ic_close)
+ contentDescription = view.context.getString(R.string.history_delete_item)
+ setOnClickListener {
+ val item = item ?: return@setOnClickListener
+ interactor.onDelete(setOf(item))
+ }
}
}
diff --git a/app/src/main/java/org/mozilla/fenix/library/recentlyclosed/RecentlyClosedItemViewHolder.kt b/app/src/main/java/org/mozilla/fenix/library/recentlyclosed/RecentlyClosedItemViewHolder.kt
index becc98fc1d..4d6e20deac 100644
--- a/app/src/main/java/org/mozilla/fenix/library/recentlyclosed/RecentlyClosedItemViewHolder.kt
+++ b/app/src/main/java/org/mozilla/fenix/library/recentlyclosed/RecentlyClosedItemViewHolder.kt
@@ -24,10 +24,13 @@ class RecentlyClosedItemViewHolder(
private var item: RecoverableTab? = null
init {
- binding.historyLayout.overflowView.setImageResource(R.drawable.ic_close)
- binding.historyLayout.overflowView.setOnClickListener {
- val item = this.item ?: return@setOnClickListener
- recentlyClosedFragmentInteractor.onDelete(item)
+ binding.historyLayout.overflowView.apply {
+ setImageResource(R.drawable.ic_close)
+ contentDescription = view.context.getString(R.string.history_delete_item)
+ setOnClickListener {
+ val item = item ?: return@setOnClickListener
+ recentlyClosedFragmentInteractor.onDelete(item)
+ }
}
}
diff --git a/app/src/main/res/values/strings.xml b/app/src/main/res/values/strings.xml
index f7157fb798..d6bad9266b 100644
--- a/app/src/main/res/values/strings.xml
+++ b/app/src/main/res/values/strings.xml
@@ -863,8 +863,8 @@
Open in new tab
Open in private tab
-
- Delete
+
+ Delete
%1$d selected