Closes #20650: Revert to manually close tab as default setting

upstream-sync
Roger Yang 3 years ago committed by mergify[bot]
parent 525e5e7c25
commit c55c252f9a

@ -332,7 +332,7 @@ class Settings(private val appContext: Context) : PreferencesHolder {
var manuallyCloseTabs by booleanPreference(
appContext.getPreferenceKey(R.string.pref_key_close_tabs_manually),
default = FeatureFlags.inactiveTabs.not()
default = true
)
var closeTabsAfterOneDay by booleanPreference(
@ -347,7 +347,7 @@ class Settings(private val appContext: Context) : PreferencesHolder {
var closeTabsAfterOneMonth by booleanPreference(
appContext.getPreferenceKey(R.string.pref_key_close_tabs_after_one_month),
default = FeatureFlags.inactiveTabs
default = false
)
var allowThirdPartyRootCerts by booleanPreference(

@ -225,21 +225,21 @@ class SettingsTest {
fun shouldManuallyCloseTabs() {
// When just created
// Then
assertFalse(settings.manuallyCloseTabs)
assertTrue(settings.manuallyCloseTabs)
// When
settings.manuallyCloseTabs = true
settings.manuallyCloseTabs = false
// Then
assertTrue(settings.manuallyCloseTabs)
assertFalse(settings.manuallyCloseTabs)
}
@Test
fun getTabTimeout() {
// When just created
// Then
assertTrue(settings.closeTabsAfterOneMonth)
assertEquals(Settings.ONE_MONTH_MS, settings.getTabTimeout())
assertTrue(settings.manuallyCloseTabs)
assertEquals(Long.MAX_VALUE, settings.getTabTimeout())
// When
settings.manuallyCloseTabs = false

Loading…
Cancel
Save