From c82af0a97a81205f176d148736c197deedad1259 Mon Sep 17 00:00:00 2001 From: rxu Date: Wed, 19 May 2021 14:49:57 +0800 Subject: [PATCH] Add event ping telemetry for the Baidu top site click --- app/metrics.yaml | 13 +++++++++++++ .../org/mozilla/fenix/components/metrics/Event.kt | 1 + .../fenix/components/metrics/GleanMetricsService.kt | 3 +++ .../home/sessioncontrol/SessionControlController.kt | 4 ++++ 4 files changed, 21 insertions(+) diff --git a/app/metrics.yaml b/app/metrics.yaml index 000949e83..a61ec0ea5 100644 --- a/app/metrics.yaml +++ b/app/metrics.yaml @@ -3886,6 +3886,19 @@ top_sites: notification_emails: - android-probes@mozilla.com expires: "2022-02-01" + open_baidu_search_attribution: + type: event + description: | + A user opened the baidu top site + bugs: + - https://github.com/mozilla-mobile/fenix/issues/19490 + data_reviews: + - https://github.com/mozilla-mobile/fenix/pull/20705 + data_sensitivity: + - interaction + notification_emails: + - android-probes@mozilla.com + expires: "2022-02-01" open_frecency: type: event description: | diff --git a/app/src/main/java/org/mozilla/fenix/components/metrics/Event.kt b/app/src/main/java/org/mozilla/fenix/components/metrics/Event.kt index da0b88137..c204c981f 100644 --- a/app/src/main/java/org/mozilla/fenix/components/metrics/Event.kt +++ b/app/src/main/java/org/mozilla/fenix/components/metrics/Event.kt @@ -129,6 +129,7 @@ sealed class Event { object NotificationMediaPause : Event() object TopSiteOpenDefault : Event() object TopSiteOpenGoogle : Event() + object TopSiteOpenBaidu : Event() object TopSiteOpenFrecent : Event() object TopSiteOpenPinned : Event() object TopSiteOpenInNewTab : Event() diff --git a/app/src/main/java/org/mozilla/fenix/components/metrics/GleanMetricsService.kt b/app/src/main/java/org/mozilla/fenix/components/metrics/GleanMetricsService.kt index 596eca8b7..def4eb848 100644 --- a/app/src/main/java/org/mozilla/fenix/components/metrics/GleanMetricsService.kt +++ b/app/src/main/java/org/mozilla/fenix/components/metrics/GleanMetricsService.kt @@ -544,6 +544,9 @@ private val Event.wrapper: EventWrapper<*>? is Event.TopSiteOpenGoogle -> EventWrapper( { TopSites.openGoogleSearchAttribution.record(it) } ) + is Event.TopSiteOpenBaidu -> EventWrapper( + { TopSites.openBaiduSearchAttribution.record(it) } + ) is Event.TopSiteOpenFrecent -> EventWrapper( { TopSites.openFrecency.record(it) } ) diff --git a/app/src/main/java/org/mozilla/fenix/home/sessioncontrol/SessionControlController.kt b/app/src/main/java/org/mozilla/fenix/home/sessioncontrol/SessionControlController.kt index 73de575ea..9c189857c 100644 --- a/app/src/main/java/org/mozilla/fenix/home/sessioncontrol/SessionControlController.kt +++ b/app/src/main/java/org/mozilla/fenix/home/sessioncontrol/SessionControlController.kt @@ -372,6 +372,10 @@ class DefaultSessionControlController( metrics.track(Event.TopSiteOpenGoogle) } + if (url == SupportUtils.BAIDU_URL) { + metrics.track(Event.TopSiteOpenBaidu) + } + if (url == SupportUtils.POCKET_TRENDING_URL) { metrics.track(Event.PocketTopSiteClicked) }