MR2 Telemetry: Homescreen view count (#22377)

* For #22146 - Added counter for home screen views

* For #22146 - Added PR number to metrics

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
upstream-sync
Noah Bond 3 years ago committed by GitHub
parent d4a6facd81
commit dde916038d
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

@ -5639,6 +5639,19 @@ home_screen:
notification_emails:
- android-probes@mozilla.com
expires: "2022-04-01"
home_screen_view_count:
type: counter
description: |
The number of times the home screen was displayed to the user.
bugs:
- https://github.com/mozilla-mobile/fenix/issues/22146
data_reviews:
- https://github.com/mozilla-mobile/fenix/pull/22377
data_sensitivity:
- interaction
notification_emails:
- android-probes@mozilla.com
expires: "2022-11-01"
customize_home_clicked:
type: event
description: A user clicked on Customize home from the home screen menu.

@ -230,7 +230,7 @@ open class HomeActivity : LocaleAwareAppCompatActivity(), NavHostActivity {
}
if (!shouldStartOnHome() &&
shouldNavigateBrowserFragmentOnCouldStart(savedInstanceState)
shouldNavigateBrowserFragmentOnColdStart(savedInstanceState)
) {
navigateToBrowserOnColdStart()
} else if (FeatureFlags.showStartOnHomeSettings) {
@ -1001,7 +1001,7 @@ open class HomeActivity : LocaleAwareAppCompatActivity(), NavHostActivity {
@VisibleForTesting
internal fun getSettings(): Settings = settings()
private fun shouldNavigateBrowserFragmentOnCouldStart(savedInstanceState: Bundle?): Boolean {
private fun shouldNavigateBrowserFragmentOnColdStart(savedInstanceState: Bundle?): Boolean {
return isActivityColdStarted(intent, savedInstanceState) &&
!externalSourceIntentProcessors.any {
it.process(

@ -262,6 +262,7 @@ sealed class Event {
// Home menu interaction
object HomeMenuSettingsItemClicked : Event()
object HomeScreenDisplayed : Event()
object HomeScreenViewCount : Event()
object HomeScreenCustomizedHomeClicked : Event()
// Browser Toolbar

@ -779,6 +779,9 @@ private val Event.wrapper: EventWrapper<*>?
is Event.HomeScreenDisplayed -> EventWrapper<NoExtraKeys>(
{ HomeScreen.homeScreenDisplayed.record(it) }
)
is Event.HomeScreenViewCount -> EventWrapper<NoExtraKeys>(
{ HomeScreen.homeScreenViewCount.add() }
)
is Event.HomeScreenCustomizedHomeClicked -> EventWrapper<NoExtraKeys>(
{ HomeScreen.customizeHomeClicked.record(it) }
)

@ -480,7 +480,10 @@ class HomeFragment : Fragment() {
val profilerStartTime = requireComponents.core.engine.profiler?.getProfilerTime()
super.onViewCreated(view, savedInstanceState)
context?.metrics?.track(Event.HomeScreenDisplayed)
context?.metrics?.apply {
track(Event.HomeScreenDisplayed)
track(Event.HomeScreenViewCount)
}
observeSearchEngineChanges()
createHomeMenu(requireContext(), WeakReference(binding.menuButton))

Loading…
Cancel
Save