For #21921 - post: switch generic marker skip to BaseBrowserFragment.

Since we instrument the marker with the duration in BaseBrowserFragment,
we should skip on BaseBrowserFragment too, not its subclass,
BrowserFragment.
upstream-sync
Michael Comella 3 years ago committed by mergify[bot]
parent 788eb2c5de
commit ec1a25dfcf

@ -11,7 +11,7 @@ import androidx.fragment.app.Fragment
import androidx.fragment.app.FragmentManager
import kotlinx.coroutines.ExperimentalCoroutinesApi
import mozilla.components.concept.engine.Engine
import org.mozilla.fenix.browser.BrowserFragment
import org.mozilla.fenix.browser.BaseBrowserFragment
import org.mozilla.fenix.home.HomeFragment
/**
@ -85,7 +85,7 @@ class MarkersFragmentLifecycleCallbacks(
if (shouldSkip() ||
// These methods are manually instrumented with duration.
f is HomeFragment ||
f is BrowserFragment // instrumented in BaseBrowserFragment.
f is BaseBrowserFragment
) {
return
}

Loading…
Cancel
Save