For #21292: Remove unused MetricController parameters.

pull/543/head
mcarare 2 years ago committed by mergify[bot]
parent 01a09c83fe
commit ffa1ecd300

@ -172,8 +172,8 @@ open class HomeActivity : LocaleAwareAppCompatActivity(), NavHostActivity {
private val externalSourceIntentProcessors by lazy {
listOf(
HomeDeepLinkIntentProcessor(this),
SpeechProcessingIntentProcessor(this, components.core.store, components.analytics.metrics),
StartSearchIntentProcessor(components.analytics.metrics),
SpeechProcessingIntentProcessor(this, components.core.store),
StartSearchIntentProcessor(),
OpenBrowserIntentProcessor(this, ::getIntentSessionId),
OpenSpecificTabIntentProcessor(this),
DefaultBrowserIntentProcessor(this)

@ -322,7 +322,6 @@ abstract class BaseBrowserFragment :
tabsUseCases = requireComponents.useCases.tabsUseCases,
activity = activity,
navController = findNavController(),
metrics = requireComponents.analytics.metrics,
readerModeController = readerMenuController,
engineView = binding.engineView,
homeViewModel = homeViewModel,
@ -360,7 +359,6 @@ abstract class BaseBrowserFragment :
store = store,
activity = activity,
navController = findNavController(),
metrics = requireComponents.analytics.metrics,
settings = context.settings(),
readerModeController = readerMenuController,
sessionFeature = sessionFeature,

@ -199,10 +199,7 @@ class Core(
RecentlyClosedMiddleware(recentlyClosedTabsStorage, RECENTLY_CLOSED_MAX),
DownloadMiddleware(context, DownloadService::class.java),
ReaderViewMiddleware(),
TelemetryMiddleware(
context.settings(),
metrics
),
TelemetryMiddleware(context.settings()),
ThumbnailsMiddleware(thumbnailStorage),
UndoMiddleware(context.getUndoDelay()),
RegionMiddleware(context, locationService),

@ -25,7 +25,6 @@ import org.mozilla.fenix.browser.BrowserAnimator.Companion.getToolbarNavOptions
import org.mozilla.fenix.browser.BrowserFragmentDirections
import org.mozilla.fenix.browser.browsingmode.BrowsingMode
import org.mozilla.fenix.browser.readermode.ReaderModeController
import org.mozilla.fenix.components.metrics.MetricController
import org.mozilla.fenix.components.toolbar.interactor.BrowserToolbarInteractor
import org.mozilla.fenix.ext.components
import org.mozilla.fenix.ext.nav
@ -55,7 +54,6 @@ class DefaultBrowserToolbarController(
private val tabsUseCases: TabsUseCases,
private val activity: HomeActivity,
private val navController: NavController,
private val metrics: MetricController,
private val readerModeController: ReaderModeController,
private val engineView: EngineView,
private val homeViewModel: HomeScreenViewModel,

@ -42,7 +42,6 @@ import org.mozilla.fenix.collections.SaveCollectionStep
import org.mozilla.fenix.components.FenixSnackbar
import org.mozilla.fenix.components.TabCollectionStorage
import org.mozilla.fenix.components.accounts.AccountState
import org.mozilla.fenix.components.metrics.MetricController
import org.mozilla.fenix.ext.components
import org.mozilla.fenix.ext.getRootView
import org.mozilla.fenix.ext.nav
@ -64,7 +63,6 @@ class DefaultBrowserToolbarMenuController(
private val store: BrowserStore,
private val activity: HomeActivity,
private val navController: NavController,
private val metrics: MetricController,
private val settings: Settings,
private val readerModeController: ReaderModeController,
private val sessionFeature: ViewBoundFeatureWrapper<SessionFeature>,

@ -13,7 +13,6 @@ import mozilla.components.browser.state.store.BrowserStore
import mozilla.components.feature.search.ext.waitForSelectedOrDefaultSearchEngine
import org.mozilla.fenix.BrowserDirection
import org.mozilla.fenix.HomeActivity
import org.mozilla.fenix.components.metrics.MetricController
import org.mozilla.fenix.components.metrics.MetricsUtils
import org.mozilla.fenix.ext.components
import org.mozilla.fenix.widget.VoiceSearchActivity.Companion.SPEECH_PROCESSING
@ -25,7 +24,6 @@ import org.mozilla.fenix.widget.VoiceSearchActivity.Companion.SPEECH_PROCESSING
class SpeechProcessingIntentProcessor(
private val activity: HomeActivity,
private val store: BrowserStore,
private val metrics: MetricController
) : HomeIntentProcessor {
override fun process(intent: Intent, navController: NavController, out: Intent): Boolean {

@ -12,7 +12,6 @@ import org.mozilla.fenix.GleanMetrics.SearchWidget
import org.mozilla.fenix.HomeActivity
import org.mozilla.fenix.NavGraphDirections
import org.mozilla.fenix.R
import org.mozilla.fenix.components.metrics.MetricController
import org.mozilla.fenix.components.metrics.MetricsUtils
import org.mozilla.fenix.ext.nav
@ -20,9 +19,7 @@ import org.mozilla.fenix.ext.nav
* When the search widget is tapped, Fenix should open to the search fragment.
* Tapping the private browsing mode launcher icon should also open to the search fragment.
*/
class StartSearchIntentProcessor(
private val metrics: MetricController
) : HomeIntentProcessor {
class StartSearchIntentProcessor : HomeIntentProcessor {
override fun process(intent: Intent, navController: NavController, out: Intent): Boolean {
val event = intent.extras?.getString(HomeActivity.OPEN_TO_SEARCH)

@ -77,9 +77,6 @@ class BookmarkFragment : LibraryPageFragment<BookmarkNode>(), UserInteractionHan
private var _binding: FragmentBookmarkBinding? = null
private val binding get() = _binding!!
private val metrics
get() = context?.components?.analytics?.metrics
override val selectedItems get() = bookmarkStore.state.mode.selectedItems
override fun onCreateView(
@ -107,8 +104,7 @@ class BookmarkFragment : LibraryPageFragment<BookmarkNode>(), UserInteractionHan
deleteBookmarkNodes = ::deleteMulti,
deleteBookmarkFolder = ::showRemoveFolderDialog,
showTabTray = ::showTabTray
),
metrics = metrics!!
)
)
bookmarkView = BookmarkView(binding.bookmarkLayout, bookmarkInteractor, findNavController())

@ -9,7 +9,6 @@ import mozilla.components.concept.storage.BookmarkNodeType
import mozilla.telemetry.glean.private.NoExtras
import org.mozilla.fenix.GleanMetrics.BookmarksManagement
import org.mozilla.fenix.browser.browsingmode.BrowsingMode
import org.mozilla.fenix.components.metrics.MetricController
import org.mozilla.fenix.utils.Do
/**
@ -19,12 +18,10 @@ import org.mozilla.fenix.utils.Do
* @property bookmarkStore bookmarks state
* @property viewModel view state
* @property bookmarksController view controller
* @property metrics telemetry controller
*/
@SuppressWarnings("TooManyFunctions")
class BookmarkFragmentInteractor(
private val bookmarksController: BookmarkController,
private val metrics: MetricController
) : BookmarkViewInteractor {
override fun onBookmarksChanged(node: BookmarkNode) {

@ -17,7 +17,6 @@ import org.mozilla.fenix.R
import org.mozilla.fenix.components.AppStore
import org.mozilla.fenix.components.appstate.AppAction
import org.mozilla.fenix.components.history.DefaultPagedHistoryProvider
import org.mozilla.fenix.components.metrics.MetricController
import org.mozilla.fenix.ext.components
import org.mozilla.fenix.ext.navigateSafe
import org.mozilla.fenix.GleanMetrics.History as GleanHistory
@ -56,7 +55,6 @@ class DefaultHistoryController(
delete: (Set<History>) -> suspend (context: Context) -> Unit
) -> Unit,
private val syncHistory: suspend () -> Unit,
private val metrics: MetricController
) : HistoryController {
override fun handleOpen(item: History) {

@ -108,7 +108,6 @@ class HistoryFragment : LibraryPageFragment<History>(), UserInteractionHandler {
invalidateOptionsMenu = ::invalidateOptionsMenu,
deleteSnackbar = :: deleteSnackbar,
syncHistory = ::syncHistory,
metrics = requireComponents.analytics.metrics
)
historyInteractor = DefaultHistoryInteractor(
historyController

@ -14,7 +14,6 @@ import org.mozilla.fenix.ext.components
class FenixOnboarding(context: Context) : PreferencesHolder {
private val metrics = context.components.analytics.metrics
private val strictMode = context.components.strictMode
override val preferences: SharedPreferences = strictMode.resetAfter(StrictMode.allowThreadDiskReads()) {
context.getSharedPreferences(

@ -23,7 +23,6 @@ import org.mozilla.fenix.GleanMetrics.Events
import org.mozilla.fenix.GleanMetrics.SearchShortcuts
import org.mozilla.fenix.HomeActivity
import org.mozilla.fenix.R
import org.mozilla.fenix.components.metrics.MetricController
import org.mozilla.fenix.components.metrics.MetricsUtils
import org.mozilla.fenix.crashes.CrashListActivity
import org.mozilla.fenix.ext.navigateSafe
@ -63,7 +62,6 @@ class SearchDialogController(
private val fragmentStore: SearchFragmentStore,
private val navController: NavController,
private val settings: Settings,
private val metrics: MetricController,
private val dismissDialog: () -> Unit,
private val clearToolbarFocus: () -> Unit,
private val focusToolbar: () -> Unit,

@ -180,7 +180,6 @@ class SearchDialogFragment : AppCompatDialogFragment(), UserInteractionHandler {
fragmentStore = store,
navController = findNavController(),
settings = requireContext().settings(),
metrics = requireComponents.analytics.metrics,
dismissDialog = {
dialogHandledAction = true
dismissAllowingStateLoss()

@ -25,7 +25,6 @@ import org.mozilla.fenix.collections.CollectionsDialog
import org.mozilla.fenix.collections.show
import org.mozilla.fenix.components.TabCollectionStorage
import org.mozilla.fenix.components.bookmarks.BookmarksUseCase
import org.mozilla.fenix.components.metrics.MetricController
import org.mozilla.fenix.home.HomeFragment
import org.mozilla.fenix.tabstray.ext.getTabSessionState
import org.mozilla.fenix.tabstray.ext.isActiveDownload
@ -102,7 +101,6 @@ class DefaultNavigationInteractor(
private val activity: HomeActivity,
private val browserStore: BrowserStore,
private val navController: NavController,
private val metrics: MetricController,
private val dismissTabTray: () -> Unit,
private val dismissTabTrayAndNavigateHome: (sessionId: String) -> Unit,
private val bookmarksUseCase: BookmarksUseCase,

@ -21,7 +21,6 @@ import org.mozilla.fenix.R
import org.mozilla.fenix.browser.browsingmode.BrowsingMode
import org.mozilla.fenix.browser.browsingmode.BrowsingModeManager
import org.mozilla.fenix.components.metrics.Event
import org.mozilla.fenix.components.metrics.MetricController
import org.mozilla.fenix.home.HomeFragment
import org.mozilla.fenix.ext.DEFAULT_ACTIVE_DAYS
import org.mozilla.fenix.ext.potentialInactiveTabs
@ -115,7 +114,6 @@ class DefaultTabsTrayController(
private val navigateToHomeAndDeleteSession: (String) -> Unit,
private val profiler: Profiler?,
private val navigationInteractor: NavigationInteractor,
private val metrics: MetricController,
private val tabsUseCases: TabsUseCases,
private val selectTabPosition: (Int, Boolean) -> Unit,
private val dismissTray: () -> Unit,

@ -43,7 +43,6 @@ import org.mozilla.fenix.databinding.FragmentTabTrayDialogBinding
import org.mozilla.fenix.databinding.TabsTrayTabCounter2Binding
import org.mozilla.fenix.databinding.TabstrayMultiselectItemsBinding
import org.mozilla.fenix.ext.components
import org.mozilla.fenix.ext.metrics
import org.mozilla.fenix.ext.requireComponents
import org.mozilla.fenix.ext.runIfFragmentIsAttached
import org.mozilla.fenix.ext.settings
@ -152,9 +151,7 @@ class TabsTrayFragment : AppCompatDialogFragment() {
focusGroupTabId = args.focusGroupTabId
),
middlewares = listOf(
TabsTrayMiddleware(
metrics = requireContext().metrics
)
TabsTrayMiddleware()
)
)
}
@ -194,7 +191,6 @@ class TabsTrayFragment : AppCompatDialogFragment() {
tabsTrayStore = tabsTrayStore,
browserStore = requireComponents.core.store,
navController = findNavController(),
metrics = requireComponents.analytics.metrics,
dismissTabTray = ::dismissTabsTray,
dismissTabTrayAndNavigateHome = ::dismissTabsTrayAndNavigateHome,
bookmarksUseCase = requireComponents.useCases.bookmarksUseCases,
@ -214,7 +210,6 @@ class TabsTrayFragment : AppCompatDialogFragment() {
navigateToHomeAndDeleteSession = ::navigateToHomeAndDeleteSession,
navigationInteractor = navigationInteractor,
profiler = requireComponents.core.engine.profiler,
metrics = requireComponents.analytics.metrics,
tabsUseCases = requireComponents.useCases.tabsUseCases,
selectTabPosition = ::selectTabPosition,
dismissTray = ::dismissTabsTray,

@ -10,16 +10,11 @@ import mozilla.components.lib.state.MiddlewareContext
import org.mozilla.fenix.GleanMetrics.Metrics
import org.mozilla.fenix.GleanMetrics.SearchTerms
import org.mozilla.fenix.GleanMetrics.TabsTray
import org.mozilla.fenix.components.metrics.MetricController
/**
* [Middleware] that reacts to various [TabsTrayAction]s.
*
* @property metrics reference to the configured [MetricController] to record general page load events.
*/
class TabsTrayMiddleware(
private val metrics: MetricController
) : Middleware<TabsTrayState, TabsTrayAction> {
class TabsTrayMiddleware : Middleware<TabsTrayState, TabsTrayAction> {
private var shouldReportInactiveTabMetrics: Boolean = true
private var shouldReportSearchGroupMetrics: Boolean = true

@ -22,7 +22,6 @@ import mozilla.components.support.base.android.Clock
import mozilla.components.support.base.log.logger.Logger
import org.mozilla.fenix.GleanMetrics.Events
import org.mozilla.fenix.GleanMetrics.Metrics
import org.mozilla.fenix.components.metrics.MetricController
import org.mozilla.fenix.utils.Settings
import org.mozilla.fenix.GleanMetrics.EngineTab as EngineMetrics
@ -31,11 +30,9 @@ import org.mozilla.fenix.GleanMetrics.EngineTab as EngineMetrics
*
* @property settings reference to the application [Settings].
* @property adsTelemetry reference to [AdsTelemetry] use to record search telemetry.
* @property metrics reference to the configured [MetricController] to record general page load events.
*/
class TelemetryMiddleware(
private val settings: Settings,
private val metrics: MetricController
) : Middleware<BrowserState, BrowserAction> {
private val logger = Logger("TelemetryMiddleware")

@ -49,7 +49,6 @@ import org.mozilla.fenix.browser.BrowserFragmentDirections
import org.mozilla.fenix.browser.browsingmode.BrowsingMode
import org.mozilla.fenix.browser.browsingmode.SimpleBrowsingModeManager
import org.mozilla.fenix.browser.readermode.ReaderModeController
import org.mozilla.fenix.components.metrics.MetricController
import org.mozilla.fenix.ext.components
import org.mozilla.fenix.ext.settings
import org.mozilla.fenix.helpers.FenixRobolectricTestRunner
@ -69,9 +68,6 @@ class DefaultBrowserToolbarControllerTest {
@MockK(relaxUnitFun = true)
private lateinit var engineView: EngineView
@RelaxedMockK
private lateinit var metrics: MetricController
@RelaxedMockK
private lateinit var searchUseCases: SearchUseCases
@ -377,7 +373,6 @@ class DefaultBrowserToolbarControllerTest {
tabsUseCases = tabsUseCases,
activity = activity,
navController = navController,
metrics = metrics,
engineView = engineView,
homeViewModel = homeViewModel,
customTabSessionId = customTabSessionId,

@ -72,7 +72,6 @@ import org.mozilla.fenix.collections.SaveCollectionStep
import org.mozilla.fenix.components.FenixSnackbar
import org.mozilla.fenix.components.TabCollectionStorage
import org.mozilla.fenix.components.accounts.AccountState
import org.mozilla.fenix.components.metrics.MetricController
import org.mozilla.fenix.ext.components
import org.mozilla.fenix.ext.directionsEq
import org.mozilla.fenix.helpers.FenixRobolectricTestRunner
@ -92,7 +91,6 @@ class DefaultBrowserToolbarMenuControllerTest {
@RelaxedMockK private lateinit var activity: HomeActivity
@RelaxedMockK private lateinit var navController: NavController
@RelaxedMockK private lateinit var openInFenixIntent: Intent
@RelaxedMockK private lateinit var metrics: MetricController
@RelaxedMockK private lateinit var settings: Settings
@RelaxedMockK private lateinit var searchUseCases: SearchUseCases
@RelaxedMockK private lateinit var sessionUseCases: SessionUseCases
@ -814,7 +812,6 @@ class DefaultBrowserToolbarMenuControllerTest {
store = store,
activity = activity,
navController = navController,
metrics = metrics,
settings = settings,
findInPageLauncher = findInPageLauncher,
browserAnimator = browserAnimator,

@ -64,7 +64,6 @@ import org.mozilla.fenix.components.AppStore
import org.mozilla.fenix.components.TabCollectionStorage
import org.mozilla.fenix.components.appstate.AppAction
import org.mozilla.fenix.components.appstate.AppState
import org.mozilla.fenix.components.metrics.MetricController
import org.mozilla.fenix.ext.components
import org.mozilla.fenix.ext.settings
import org.mozilla.fenix.gleanplumb.Message
@ -89,7 +88,6 @@ class DefaultSessionControlControllerTest {
private val activity: HomeActivity = mockk(relaxed = true)
private val appStore: AppStore = mockk(relaxed = true)
private val navController: NavController = mockk(relaxed = true)
private val metrics: MetricController = mockk(relaxed = true)
private val messageController: MessageController = mockk(relaxed = true)
private val engine: Engine = mockk(relaxed = true)
private val tabCollectionStorage: TabCollectionStorage = mockk(relaxed = true)
@ -154,7 +152,6 @@ class DefaultSessionControlControllerTest {
every { activity.components.settings } returns settings
every { activity.settings() } returns settings
every { activity.components.analytics } returns analytics
every { analytics.metrics } returns metrics
}
@After

@ -19,7 +19,6 @@ import org.junit.Test
import org.junit.runner.RunWith
import org.mozilla.fenix.GleanMetrics.Events
import org.mozilla.fenix.HomeActivity
import org.mozilla.fenix.components.metrics.MetricController
import org.mozilla.fenix.helpers.FenixRobolectricTestRunner
@RunWith(FenixRobolectricTestRunner::class)
@ -45,14 +44,12 @@ class DefaultBrowserIntentProcessorTest {
val navController: NavController = mockk(relaxed = true)
val out: Intent = mockk()
val activity: HomeActivity = mockk()
val metrics: MetricController = mockk()
val intent = Intent().apply {
putExtra("org.mozilla.fenix.default.browser.intent", true)
}
every { activity.startActivity(any()) } returns Unit
every { activity.applicationContext } returns testContext
every { metrics.track(any()) } returns Unit
assertFalse(Events.defaultBrowserNotifTapped.testHasValue())

@ -21,7 +21,6 @@ import org.junit.Test
import org.junit.runner.RunWith
import org.mozilla.fenix.BrowserDirection
import org.mozilla.fenix.HomeActivity
import org.mozilla.fenix.components.metrics.MetricController
import org.mozilla.fenix.ext.components
import org.mozilla.fenix.helpers.FenixRobolectricTestRunner
import org.mozilla.fenix.helpers.perf.TestStrictModeManager
@ -33,7 +32,6 @@ class SpeechProcessingIntentProcessorTest {
private val activity: HomeActivity = mockk(relaxed = true)
private val navController: NavController = mockk(relaxed = true)
private val out: Intent = mockk(relaxed = true)
private val metrics: MetricController = mockk(relaxed = true)
private val searchEngine = createSearchEngine(
name = "Test",
@ -62,13 +60,12 @@ class SpeechProcessingIntentProcessorTest {
@Test
fun `do not process blank intents`() {
val processor = SpeechProcessingIntentProcessor(activity, store, metrics)
val processor = SpeechProcessingIntentProcessor(activity, store)
processor.process(Intent(), navController, out)
verify { activity wasNot Called }
verify { navController wasNot Called }
verify { out wasNot Called }
verify { metrics wasNot Called }
}
@Test
@ -76,13 +73,12 @@ class SpeechProcessingIntentProcessorTest {
val intent = Intent().apply {
putExtra(HomeActivity.OPEN_TO_BROWSER_AND_LOAD, false)
}
val processor = SpeechProcessingIntentProcessor(activity, store, metrics)
val processor = SpeechProcessingIntentProcessor(activity, store)
processor.process(intent, navController, out)
verify { activity wasNot Called }
verify { navController wasNot Called }
verify { out wasNot Called }
verify { metrics wasNot Called }
}
@Test
@ -93,7 +89,7 @@ class SpeechProcessingIntentProcessorTest {
putExtra(SPEECH_PROCESSING, "hello world")
}
val processor = SpeechProcessingIntentProcessor(activity, store, metrics)
val processor = SpeechProcessingIntentProcessor(activity, store)
processor.process(intent, mockk(), mockk(relaxed = true))
verify {

@ -21,7 +21,6 @@ import org.mozilla.fenix.GleanMetrics.SearchWidget
import org.mozilla.fenix.HomeActivity
import org.mozilla.fenix.NavGraphDirections
import org.mozilla.fenix.R
import org.mozilla.fenix.components.metrics.MetricController
import org.mozilla.fenix.components.metrics.MetricsUtils
import org.mozilla.fenix.ext.nav
import org.mozilla.fenix.helpers.FenixRobolectricTestRunner
@ -32,15 +31,11 @@ class StartSearchIntentProcessorTest {
@get:Rule
val gleanTestRule = GleanTestRule(testContext)
private val metrics: MetricController = mockk(relaxed = true)
private val navController: NavController = mockk(relaxed = true)
private val out: Intent = mockk(relaxed = true)
@Test
fun `do not process blank intents`() {
StartSearchIntentProcessor(metrics).process(Intent(), navController, out)
verify { metrics wasNot Called }
verify { navController wasNot Called }
verify { out wasNot Called }
}
@ -50,9 +45,8 @@ class StartSearchIntentProcessorTest {
val intent = Intent().apply {
removeExtra(HomeActivity.OPEN_TO_SEARCH)
}
StartSearchIntentProcessor(metrics).process(intent, navController, out)
StartSearchIntentProcessor().process(intent, navController, out)
verify { metrics wasNot Called }
verify { navController wasNot Called }
verify { out wasNot Called }
}
@ -62,7 +56,7 @@ class StartSearchIntentProcessorTest {
val intent = Intent().apply {
putExtra(HomeActivity.OPEN_TO_SEARCH, StartSearchIntentProcessor.SEARCH_WIDGET)
}
StartSearchIntentProcessor(metrics).process(intent, navController, out)
StartSearchIntentProcessor().process(intent, navController, out)
val options = navOptions {
popUpTo = R.id.homeFragment
}

@ -29,8 +29,6 @@ import org.mozilla.fenix.BrowserDirection
import org.mozilla.fenix.GleanMetrics.RecentBookmarks
import org.mozilla.fenix.HomeActivity
import org.mozilla.fenix.R
import org.mozilla.fenix.components.metrics.MetricController
import org.mozilla.fenix.ext.components
import org.mozilla.fenix.helpers.FenixRobolectricTestRunner
import org.mozilla.fenix.home.HomeFragmentDirections
import org.mozilla.fenix.home.recentbookmarks.controller.DefaultRecentBookmarksController
@ -46,14 +44,12 @@ class DefaultRecentBookmarksControllerTest {
private val activity: HomeActivity = mockk(relaxed = true)
private val navController: NavController = mockk(relaxUnitFun = true)
private val metrics: MetricController = mockk(relaxed = true)
private lateinit var controller: DefaultRecentBookmarksController
@Before
fun setup() {
every { activity.openToBrowserAndLoad(any(), any(), any()) } just Runs
every { activity.components.core.metrics } returns metrics
every { navController.currentDestination } returns mockk {
every { id } returns R.id.homeFragment

@ -24,7 +24,6 @@ import org.junit.Test
import org.junit.runner.RunWith
import org.mozilla.fenix.GleanMetrics.Pings
import org.mozilla.fenix.GleanMetrics.TopSites
import org.mozilla.fenix.components.metrics.MetricController
import org.mozilla.fenix.databinding.TopSiteItemBinding
import org.mozilla.fenix.ext.components
import org.mozilla.fenix.helpers.FenixRobolectricTestRunner
@ -39,7 +38,6 @@ class TopSiteItemViewHolderTest {
private lateinit var binding: TopSiteItemBinding
private lateinit var interactor: TopSiteInteractor
private lateinit var lifecycleOwner: LifecycleOwner
private lateinit var metrics: MetricController
private val pocket = TopSite.Default(
id = 1L,
@ -53,10 +51,8 @@ class TopSiteItemViewHolderTest {
binding = TopSiteItemBinding.inflate(LayoutInflater.from(testContext))
interactor = mockk(relaxed = true)
lifecycleOwner = mockk(relaxed = true)
metrics = mockk(relaxed = true)
every { testContext.components.core.icons } returns BrowserIcons(testContext, mockk(relaxed = true))
every { testContext.components.analytics.metrics } returns metrics
}
@Test

@ -19,7 +19,6 @@ import org.junit.Test
import org.junit.runner.RunWith
import org.mozilla.fenix.GleanMetrics.BookmarksManagement
import org.mozilla.fenix.browser.browsingmode.BrowsingMode
import org.mozilla.fenix.components.metrics.MetricController
import org.mozilla.fenix.helpers.FenixRobolectricTestRunner
@SuppressWarnings("TooManyFunctions", "LargeClass")
@ -32,7 +31,6 @@ class BookmarkFragmentInteractorTest {
private lateinit var interactor: BookmarkFragmentInteractor
private val bookmarkController: DefaultBookmarkController = mockk(relaxed = true)
private val metrics: MetricController = mockk(relaxed = true)
private val item = BookmarkNode(BookmarkNodeType.ITEM, "456", "123", 0u, "Mozilla", "http://mozilla.org", 0, null)
private val separator = BookmarkNode(BookmarkNodeType.SEPARATOR, "789", "123", 1u, null, null, 0, null)
@ -44,10 +42,7 @@ class BookmarkFragmentInteractorTest {
@Before
fun setup() {
interactor =
BookmarkFragmentInteractor(
bookmarksController = bookmarkController,
metrics = metrics
)
BookmarkFragmentInteractor(bookmarksController = bookmarkController)
}
@Test

@ -20,7 +20,6 @@ import org.junit.runner.RunWith
import org.mozilla.fenix.R
import org.mozilla.fenix.components.AppStore
import org.mozilla.fenix.components.history.DefaultPagedHistoryProvider
import org.mozilla.fenix.components.metrics.MetricController
import org.mozilla.fenix.ext.navigateSafe
import org.mozilla.fenix.helpers.FenixRobolectricTestRunner
@ -38,7 +37,6 @@ class HistoryControllerTest {
private val appStore: AppStore = mockk(relaxed = true)
private val state: HistoryFragmentState = mockk(relaxed = true)
private val navController: NavController = mockk(relaxed = true)
private val metrics: MetricController = mockk(relaxed = true)
private val historyProvider: DefaultPagedHistoryProvider = mockk(relaxed = true)
@Before
@ -202,7 +200,6 @@ class HistoryControllerTest {
invalidateOptionsMenu,
{ items, _, _ -> deleteHistoryItems.invoke(items) },
syncHistory,
metrics
)
}
}

@ -21,7 +21,6 @@ import org.junit.runner.RunWith
import org.mozilla.fenix.BrowserDirection
import org.mozilla.fenix.GleanMetrics.History
import org.mozilla.fenix.HomeActivity
import org.mozilla.fenix.components.metrics.MetricController
import org.mozilla.fenix.helpers.FenixRobolectricTestRunner
@RunWith(FenixRobolectricTestRunner::class)
@ -32,7 +31,6 @@ class HistorySearchControllerTest {
@MockK(relaxed = true) private lateinit var activity: HomeActivity
@MockK(relaxed = true) private lateinit var store: HistorySearchFragmentStore
@MockK(relaxed = true) private lateinit var metrics: MetricController
@Before
fun setUp() {

@ -8,7 +8,6 @@ import androidx.navigation.NavController
import androidx.navigation.NavOptions
import io.mockk.mockk
import io.mockk.coEvery
import io.mockk.clearMocks
import io.mockk.every
import io.mockk.verify
import io.mockk.coVerify
@ -37,7 +36,6 @@ import org.mozilla.fenix.GleanMetrics.RecentlyClosedTabs
import org.mozilla.fenix.HomeActivity
import org.mozilla.fenix.R
import org.mozilla.fenix.browser.browsingmode.BrowsingMode
import org.mozilla.fenix.components.metrics.MetricController
import org.mozilla.fenix.ext.directionsEq
import org.mozilla.fenix.ext.optionsEq
import org.mozilla.fenix.helpers.FenixRobolectricTestRunner
@ -49,7 +47,6 @@ class DefaultRecentlyClosedControllerTest {
private val browserStore: BrowserStore = mockk(relaxed = true)
private val recentlyClosedStore: RecentlyClosedFragmentStore = mockk(relaxed = true)
private val tabsUseCases: TabsUseCases = mockk(relaxed = true)
private val metrics: MetricController = mockk(relaxed = true)
@get:Rule
val gleanTestRule = GleanTestRule(testContext)
@ -111,7 +108,6 @@ class DefaultRecentlyClosedControllerTest {
assertEquals(BrowsingMode.Normal, actualBrowsingModes[1])
assertTrue(RecentlyClosedTabs.menuOpenInNormalTab.testHasValue())
assertNull(RecentlyClosedTabs.menuOpenInNormalTab.testGetValue().last().extra)
clearMocks(metrics)
tabUrls.clear()
actualBrowsingModes.clear()

@ -24,8 +24,6 @@ import org.junit.runner.RunWith
import org.mozilla.experiments.nimbus.Branch
import org.mozilla.fenix.components.Components
import org.mozilla.fenix.components.FenixSnackbar
import org.mozilla.fenix.components.metrics.MetricController
import org.mozilla.fenix.ext.components
import org.mozilla.fenix.ext.getRootView
import org.mozilla.fenix.ext.settings
import org.mozilla.fenix.helpers.FenixRobolectricTestRunner
@ -44,7 +42,6 @@ class NimbusBranchesControllerTest {
private lateinit var settings: Settings
private lateinit var activity: Context
private lateinit var components: Components
private lateinit var metrics: MetricController
private lateinit var snackbar: FenixSnackbar
private lateinit var rootView: View
@ -52,7 +49,6 @@ class NimbusBranchesControllerTest {
fun setup() {
components = mockk(relaxed = true)
settings = mockk(relaxed = true)
metrics = mockk(relaxed = true)
snackbar = mockk(relaxed = true)
navController = mockk(relaxed = true)
@ -66,7 +62,6 @@ class NimbusBranchesControllerTest {
every { FenixSnackbar.make(any(), any(), any(), any()) } returns snackbar
every { activity.settings() } returns settings
every { activity.components.analytics.metrics } returns metrics
every { navController.currentDestination } returns mockk {
every { id } returns org.mozilla.fenix.R.id.nimbusBranchesFragment

@ -15,7 +15,6 @@ import org.junit.Assert.assertTrue
import org.junit.Before
import org.junit.Test
import org.junit.runner.RunWith
import org.mozilla.fenix.components.metrics.MetricController
import org.mozilla.fenix.ext.components
import org.mozilla.fenix.helpers.FenixRobolectricTestRunner
import org.mozilla.fenix.helpers.perf.TestStrictModeManager
@ -29,17 +28,13 @@ class FenixOnboardingTest {
private lateinit var onboarding: FenixOnboarding
private lateinit var preferences: SharedPreferences
private lateinit var preferencesEditor: SharedPreferences.Editor
private lateinit var metrics: MetricController
@Before
fun setup() {
preferences = mockk()
preferencesEditor = mockk(relaxed = true)
metrics = mockk()
val context = mockk<Context>()
every { preferences.edit() } returns preferencesEditor
every { metrics.track(any()) } returns Unit
every { context.components.analytics.metrics } returns metrics
every { context.components.strictMode } returns TestStrictModeManager() as StrictModeManager
every { context.getSharedPreferences(any(), MODE_PRIVATE) } returns preferences

@ -43,7 +43,6 @@ import org.mozilla.fenix.GleanMetrics.Events
import org.mozilla.fenix.GleanMetrics.SearchShortcuts
import org.mozilla.fenix.HomeActivity
import org.mozilla.fenix.R
import org.mozilla.fenix.components.metrics.MetricController
import org.mozilla.fenix.components.metrics.MetricsUtils
import org.mozilla.fenix.helpers.FenixRobolectricTestRunner
import org.mozilla.fenix.search.SearchDialogFragmentDirections.Companion.actionGlobalAddonsManagementFragment
@ -59,7 +58,6 @@ class SearchDialogControllerTest {
@MockK(relaxed = true) private lateinit var store: SearchDialogFragmentStore
@MockK(relaxed = true) private lateinit var navController: NavController
@MockK private lateinit var searchEngine: SearchEngine
@MockK(relaxed = true) private lateinit var metrics: MetricController
@MockK(relaxed = true) private lateinit var settings: Settings
private lateinit var middleware: CaptureActionsMiddleware<BrowserState, BrowserAction>
@ -418,7 +416,6 @@ class SearchDialogControllerTest {
fragmentStore = store,
navController = navController,
settings = settings,
metrics = metrics,
dismissDialog = dismissDialog,
clearToolbarFocus = clearToolbarFocus,
focusToolbar = focusToolbar,

@ -40,10 +40,8 @@ import org.junit.Test
import org.junit.runner.RunWith
import org.mozilla.fenix.GleanMetrics.TrackingProtection
import org.mozilla.fenix.components.PermissionStorage
import org.mozilla.fenix.components.metrics.MetricController
import org.mozilla.fenix.ext.components
import org.mozilla.fenix.ext.directionsEq
import org.mozilla.fenix.ext.metrics
import org.mozilla.fenix.helpers.FenixRobolectricTestRunner
import org.mozilla.fenix.settings.PhoneFeature
import org.mozilla.fenix.settings.quicksettings.ext.shouldBeEnabled
@ -310,12 +308,10 @@ class DefaultQuickSettingsControllerTest {
fun `handleTrackingProtectionToggled should call the right use cases`() {
val trackingProtectionUseCases: TrackingProtectionUseCases = mockk(relaxed = true)
val sessionUseCases: SessionUseCases = mockk(relaxed = true)
val metrics: MetricController = mockk(relaxed = true)
every { context.components.core.store } returns browserStore
every { context.components.useCases.trackingProtectionUseCases } returns trackingProtectionUseCases
every { context.components.useCases.sessionUseCases } returns sessionUseCases
every { context.metrics } returns metrics
every { store.dispatch(any()) } returns mockk()
var isEnabled = true

@ -34,15 +34,12 @@ import org.junit.Assert.assertEquals
import org.junit.Assert.assertNotEquals
import org.junit.Assert.assertNull
import org.junit.Assert.assertTrue
import org.junit.Before
import org.junit.Rule
import org.junit.Test
import org.junit.runner.RunWith
import org.mozilla.fenix.GleanMetrics.SyncAccount
import org.mozilla.fenix.R
import org.mozilla.fenix.components.FenixSnackbar
import org.mozilla.fenix.components.metrics.MetricController
import org.mozilla.fenix.ext.metrics
import org.mozilla.fenix.ext.nav
import org.mozilla.fenix.helpers.FenixRobolectricTestRunner
import org.mozilla.fenix.share.listadapters.AppShareOption
@ -51,7 +48,6 @@ import org.mozilla.fenix.share.listadapters.AppShareOption
class ShareControllerTest {
// Need a valid context to retrieve Strings for example, but we also need it to return our "metrics"
private val context: Context = spyk(testContext)
private val metrics: MetricController = mockk(relaxed = true)
private val shareSubject = "shareSubject"
private val shareData = listOf(
ShareData(url = "url0", title = "title0"),
@ -82,11 +78,6 @@ class ShareControllerTest {
recentAppStorage, testCoroutineScope, testDispatcher, dismiss
)
@Before
fun setUp() {
every { context.metrics } returns metrics
}
@After
fun cleanUp() {
testCoroutineScope.cleanupTestCoroutines()

@ -36,7 +36,6 @@ import org.junit.runner.RunWith
import org.mozilla.fenix.GleanMetrics.TabsTray
import org.mozilla.fenix.R
import org.mozilla.fenix.browser.browsingmode.BrowsingModeManager
import org.mozilla.fenix.components.metrics.MetricController
import org.mozilla.fenix.home.HomeFragment
import org.mozilla.fenix.ext.maxActiveTime
import org.mozilla.fenix.ext.potentialInactiveTabs
@ -62,9 +61,6 @@ class DefaultTabsTrayControllerTest {
@MockK(relaxed = true)
private lateinit var navigationInteractor: NavigationInteractor
@MockK(relaxed = true)
private lateinit var metrics: MetricController
@MockK(relaxed = true)
private lateinit var tabsUseCases: TabsUseCases
@ -551,7 +547,6 @@ class DefaultTabsTrayControllerTest {
navigateToHomeAndDeleteSession,
profiler,
navigationInteractor,
metrics,
tabsUseCases,
selectTabPosition,
dismissTray,

@ -42,7 +42,6 @@ import org.mozilla.fenix.collections.CollectionsDialog
import org.mozilla.fenix.collections.show
import org.mozilla.fenix.components.TabCollectionStorage
import org.mozilla.fenix.components.bookmarks.BookmarksUseCase
import org.mozilla.fenix.components.metrics.MetricController
import org.mozilla.fenix.helpers.FenixRobolectricTestRunner
import mozilla.components.browser.state.state.createTab as createStateTab
import mozilla.components.browser.storage.sync.Tab as SyncTab
@ -53,7 +52,6 @@ class NavigationInteractorTest {
private lateinit var tabsTrayStore: TabsTrayStore
private val testTab: TabSessionState = createStateTab(url = "https://mozilla.org")
private val navController: NavController = mockk(relaxed = true)
private val metrics: MetricController = mockk(relaxed = true)
private val bookmarksUseCase: BookmarksUseCase = mockk(relaxed = true)
private val context: Context = mockk(relaxed = true)
private val collectionStorage: TabCollectionStorage = mockk(relaxed = true)
@ -264,7 +262,6 @@ class NavigationInteractorTest {
activity,
browserStore,
navController,
metrics,
dismissTabTray,
dismissTabTrayAndNavigateHome,
bookmarksUseCase,

@ -44,7 +44,6 @@ import org.junit.runner.RunWith
import org.mozilla.fenix.GleanMetrics.TabsTray
import org.mozilla.fenix.NavGraphDirections
import org.mozilla.fenix.R
import org.mozilla.fenix.components.metrics.MetricController
import org.mozilla.fenix.databinding.ComponentTabstray2Binding
import org.mozilla.fenix.databinding.ComponentTabstrayFabBinding
import org.mozilla.fenix.databinding.FragmentTabTrayDialogBinding
@ -239,8 +238,6 @@ class TabsTrayFragmentTest {
try {
mockkStatic("org.mozilla.fenix.tabstray.ext.BrowserMenuKt")
val navigationInteractor: NavigationInteractor = mockk()
val metrics: MetricController = mockk(relaxed = true)
every { context.components.analytics.metrics } returns metrics
every { context.components.core.store } returns mockk()
every { fragment.tabsTrayStore } returns mockk()
val menu: BrowserMenu = mockk {
@ -351,8 +348,6 @@ class TabsTrayFragmentTest {
@Test
fun `WHEN dismissTabsTray is called THEN it dismisses the tray`() {
every { fragment.dismissAllowingStateLoss() } just Runs
val metrics: MetricController = mockk(relaxed = true)
every { context.components.analytics.metrics } returns metrics
fragment.dismissTabsTray()

@ -21,7 +21,6 @@ import org.junit.runner.RunWith
import org.mozilla.fenix.GleanMetrics.Metrics
import org.mozilla.fenix.GleanMetrics.SearchTerms
import org.mozilla.fenix.GleanMetrics.TabsTray
import org.mozilla.fenix.components.metrics.MetricController
import org.mozilla.fenix.helpers.FenixRobolectricTestRunner
@RunWith(FenixRobolectricTestRunner::class) // for gleanTestRule
@ -29,17 +28,13 @@ class TabsTrayMiddlewareTest {
private lateinit var store: TabsTrayStore
private lateinit var tabsTrayMiddleware: TabsTrayMiddleware
private lateinit var metrics: MetricController
@get:Rule
val gleanTestRule = GleanTestRule(testContext)
@Before
fun setUp() {
metrics = mockk(relaxed = true)
tabsTrayMiddleware = TabsTrayMiddleware(
metrics
)
tabsTrayMiddleware = TabsTrayMiddleware()
store = TabsTrayStore(
middlewares = listOf(tabsTrayMiddleware),
initialState = TabsTrayState()

@ -4,7 +4,6 @@
package org.mozilla.fenix.tabstray.browser
import io.mockk.mockk
import mozilla.components.service.glean.testing.GleanTestRule
import mozilla.components.support.test.robolectric.testContext
import org.junit.Assert.assertEquals
@ -14,14 +13,11 @@ import org.junit.Rule
import org.junit.Test
import org.junit.runner.RunWith
import org.mozilla.fenix.GleanMetrics.TabsTray
import org.mozilla.fenix.components.metrics.MetricController
import org.mozilla.fenix.helpers.FenixRobolectricTestRunner
@RunWith(FenixRobolectricTestRunner::class) // for gleanTestRule
class RemoveTabUseCaseWrapperTest {
val metricController = mockk<MetricController>(relaxed = true)
@get:Rule
val gleanTestRule = GleanTestRule(testContext)

@ -16,13 +16,11 @@ import org.junit.Rule
import org.junit.Test
import org.junit.runner.RunWith
import org.mozilla.fenix.GleanMetrics.TabsTray
import org.mozilla.fenix.components.metrics.MetricController
import org.mozilla.fenix.helpers.FenixRobolectricTestRunner
@RunWith(FenixRobolectricTestRunner::class) // for gleanTestRule
class SelectTabUseCaseWrapperTest {
val metricController = mockk<MetricController>(relaxed = true)
val selectUseCase: TabsUseCases.SelectTabUseCase = mockk(relaxed = true)
@get:Rule

@ -30,7 +30,6 @@ import org.junit.Test
import org.junit.runner.RunWith
import org.mozilla.fenix.GleanMetrics.Events
import org.mozilla.fenix.GleanMetrics.Metrics
import org.mozilla.fenix.components.metrics.MetricController
import org.mozilla.fenix.helpers.FenixRobolectricTestRunner
import org.mozilla.fenix.utils.Settings
import org.mozilla.fenix.GleanMetrics.EngineTab as EngineMetrics
@ -41,7 +40,6 @@ class TelemetryMiddlewareTest {
private lateinit var store: BrowserStore
private lateinit var settings: Settings
private lateinit var telemetryMiddleware: TelemetryMiddleware
private lateinit var metrics: MetricController
@get:Rule
val coroutinesTestRule = MainCoroutineRule()
@ -56,11 +54,7 @@ class TelemetryMiddlewareTest {
Clock.delegate = clock
settings = Settings(testContext)
metrics = mockk(relaxed = true)
telemetryMiddleware = TelemetryMiddleware(
settings,
metrics
)
telemetryMiddleware = TelemetryMiddleware(settings,)
store = BrowserStore(
middleware = listOf(telemetryMiddleware) + EngineMiddleware.create(engine = mockk()),
initialState = BrowserState()

@ -12,7 +12,6 @@ import org.junit.Assert.assertEquals
import org.junit.Assert.assertFalse
import org.junit.Assert.assertTrue
import org.junit.Test
import org.mozilla.fenix.components.metrics.MetricController
import org.mozilla.fenix.utils.Settings
import java.util.Calendar
import java.util.Date
@ -24,7 +23,6 @@ class WallpaperManagerTest {
private val fakeCalendar = Calendar.getInstance()
private val mockSettings: Settings = mockk()
private val mockMetrics: MetricController = mockk()
private val mockDownloader: WallpaperDownloader = mockk {
coEvery { downloadWallpaper(any()) } just runs
}
@ -34,8 +32,6 @@ class WallpaperManagerTest {
@Test
fun `WHEN wallpaper set THEN current wallpaper updated in settings`() {
every { mockMetrics.track(any()) } just runs
val currentCaptureSlot = slot<String>()
every { mockSettings.currentWallpaper } returns ""
every { mockSettings.currentWallpaper = capture(currentCaptureSlot) } just runs

@ -6,15 +6,15 @@
<ID>FunctionOnlyReturningConstant:MetricsUtils.kt$MetricsUtils$ @VisibleForTesting(otherwise = VisibleForTesting.PRIVATE) internal fun getHashingSalt(): String</ID>
<ID>FunctionOnlyReturningConstant:SupportUtils.kt$SupportUtils$fun getFirefoxAccountSumoUrl(): String</ID>
<ID>FunctionParameterNaming:FenixSnackbar.kt$FenixSnackbar.Companion$_view: View?</ID>
<ID>LongParameterList:BrowserToolbarController.kt$DefaultBrowserToolbarController$( private val store: BrowserStore, private val tabsUseCases: TabsUseCases, private val activity: HomeActivity, private val navController: NavController, private val metrics: MetricController, private val readerModeController: ReaderModeController, private val engineView: EngineView, private val homeViewModel: HomeScreenViewModel, private val customTabSessionId: String?, private val browserAnimator: BrowserAnimator, private val onTabCounterClicked: () -&gt; Unit, private val onCloseTab: (SessionState) -&gt; Unit )</ID>
<ID>LongParameterList:BrowserToolbarMenuController.kt$DefaultBrowserToolbarMenuController$( private val store: BrowserStore, private val activity: HomeActivity, private val navController: NavController, private val metrics: MetricController, private val settings: Settings, private val readerModeController: ReaderModeController, private val sessionFeature: ViewBoundFeatureWrapper&lt;SessionFeature&gt;, private val findInPageLauncher: () -&gt; Unit, private val browserAnimator: BrowserAnimator, private val swipeRefresh: SwipeRefreshLayout, private val customTabSessionId: String?, private val openInFenixIntent: Intent, private val bookmarkTapped: (String, String) -&gt; Unit, private val scope: CoroutineScope, private val tabCollectionStorage: TabCollectionStorage, private val topSitesStorage: DefaultTopSitesStorage, private val pinnedSiteStorage: PinnedSiteStorage, private val browserStore: BrowserStore )</ID>
<ID>LongParameterList:BrowserToolbarController.kt$DefaultBrowserToolbarController$( private val store: BrowserStore, private val tabsUseCases: TabsUseCases, private val activity: HomeActivity, private val navController: NavController, private val readerModeController: ReaderModeController, private val engineView: EngineView, private val homeViewModel: HomeScreenViewModel, private val customTabSessionId: String?, private val browserAnimator: BrowserAnimator, private val onTabCounterClicked: () -&gt; Unit, private val onCloseTab: (SessionState) -&gt; Unit )</ID>
<ID>LongParameterList:BrowserToolbarMenuController.kt$DefaultBrowserToolbarMenuController$( private val store: BrowserStore, private val activity: HomeActivity, private val navController: NavController, private val settings: Settings, private val readerModeController: ReaderModeController, private val sessionFeature: ViewBoundFeatureWrapper&lt;SessionFeature&gt;, private val findInPageLauncher: () -&gt; Unit, private val browserAnimator: BrowserAnimator, private val swipeRefresh: SwipeRefreshLayout, private val customTabSessionId: String?, private val openInFenixIntent: Intent, private val bookmarkTapped: (String, String) -&gt; Unit, private val scope: CoroutineScope, private val tabCollectionStorage: TabCollectionStorage, private val topSitesStorage: DefaultTopSitesStorage, private val pinnedSiteStorage: PinnedSiteStorage, private val browserStore: BrowserStore )</ID>
<ID>LongParameterList:CrashContentIntegration.kt$CrashContentIntegration$( private val browserStore: BrowserStore, private val appStore: AppStore, private val toolbar: BrowserToolbar, private val isToolbarPlacedAtTop: Boolean, private val crashReporterView: CrashContentView, private val components: Components, private val settings: Settings, private val navController: NavController, private val sessionId: String? )</ID>
<ID>LongParameterList:CustomTabsIntegration.kt$CustomTabsIntegration$( store: BrowserStore, useCases: CustomTabsUseCases, toolbar: BrowserToolbar, sessionId: String, activity: Activity, onItemTapped: (ToolbarMenu.Item) -&gt; Unit = {}, shouldReverseItems: Boolean, isPrivate: Boolean )</ID>
<ID>LongParameterList:DeleteBrowsingDataController.kt$DefaultDeleteBrowsingDataController$( private val removeAllTabs: TabsUseCases.RemoveAllTabsUseCase, private val removeAllDownloads: DownloadsUseCases.RemoveAllDownloadsUseCase, private val historyStorage: HistoryStorage, private val permissionStorage: PermissionStorage, private val store: BrowserStore, private val iconsStorage: BrowserIcons, private val engine: Engine, private val coroutineContext: CoroutineContext = Dispatchers.Main )</ID>
<ID>LongParameterList:HistoryController.kt$DefaultHistoryController$( private val store: HistoryFragmentStore, private val navController: NavController, private val scope: CoroutineScope, private val openToBrowser: (item: History.Regular) -&gt; Unit, private val displayDeleteAll: () -&gt; Unit, private val invalidateOptionsMenu: () -&gt; Unit, private val deleteHistoryItems: (Set&lt;History&gt;) -&gt; Unit, private val syncHistory: suspend () -&gt; Unit, private val metrics: MetricController )</ID>
<ID>LongParameterList:QuickSettingsController.kt$DefaultQuickSettingsController$( private val context: Context, private val quickSettingsStore: QuickSettingsFragmentStore, private val browserStore: BrowserStore, private val ioScope: CoroutineScope, private val navController: NavController, @VisibleForTesting internal val sessionId: String, @VisibleForTesting internal var sitePermissions: SitePermissions?, private val settings: Settings, private val permissionStorage: PermissionStorage, private val reload: ReloadUrlUseCase, private val requestRuntimePermissions: OnNeedToRequestPermissions = { }, private val displayPermissions: () -&gt; Unit, private val engine: Engine = context.components.core.engine, )</ID>
<ID>LongParameterList:ShareController.kt$DefaultShareController$( private val context: Context, private val shareSubject: String?, private val shareData: List&lt;ShareData&gt;, private val sendTabUseCases: SendTabUseCases, private val snackbar: FenixSnackbar, private val navController: NavController, private val recentAppsStorage: RecentAppsStorage, private val viewLifecycleScope: CoroutineScope, private val dispatcher: CoroutineDispatcher = Dispatchers.IO, private val dismiss: (ShareController.Result) -&gt; Unit )</ID>
<ID>LongParameterList:TabsTrayController.kt$DefaultTabsTrayController$( private val trayStore: TabsTrayStore, private val browserStore: BrowserStore, private val browsingModeManager: BrowsingModeManager, private val navController: NavController, private val navigateToHomeAndDeleteSession: (String) -&gt; Unit, private val profiler: Profiler?, private val navigationInteractor: NavigationInteractor, private val metrics: MetricController, private val tabsUseCases: TabsUseCases, private val selectTabPosition: (Int, Boolean) -&gt; Unit, private val dismissTray: () -&gt; Unit, private val showUndoSnackbarForTab: (Boolean) -&gt; Unit, @VisibleForTesting internal val showCancelledDownloadWarning: (downloadCount: Int, tabId: String?, source: String?) -&gt; Unit, )</ID>
<ID>LongParameterList:TabsTrayController.kt$DefaultTabsTrayController$( private val trayStore: TabsTrayStore, private val browserStore: BrowserStore, private val browsingModeManager: BrowsingModeManager, private val navController: NavController, private val navigateToHomeAndDeleteSession: (String) -&gt; Unit, private val profiler: Profiler?, private val navigationInteractor: NavigationInteractor, private val tabsUseCases: TabsUseCases, private val selectTabPosition: (Int, Boolean) -&gt; Unit, private val dismissTray: () -&gt; Unit, private val showUndoSnackbarForTab: (Boolean) -&gt; Unit, @VisibleForTesting internal val showCancelledDownloadWarning: (downloadCount: Int, tabId: String?, source: String?) -&gt; Unit, )</ID>
<ID>LongParameterList:ToolbarIntegration.kt$DefaultToolbarIntegration$( context: Context, toolbar: BrowserToolbar, toolbarMenu: ToolbarMenu, domainAutocompleteProvider: DomainAutocompleteProvider, historyStorage: HistoryStorage, lifecycleOwner: LifecycleOwner, sessionId: String? = null, isPrivate: Boolean, interactor: BrowserToolbarInteractor, engine: Engine )</ID>
<ID>UndocumentedPublicClass:AboutItem.kt$AboutItem</ID>
<ID>UndocumentedPublicClass:AboutItem.kt$AboutItem$Crashes : AboutItem</ID>

Loading…
Cancel
Save