17 Commits (1f633edd7d4436f20ead4ba657b1284b94cca0c6)

Author	SHA1	Message	Date
Brais Gabín	1f633edd7d	For #23046 - Align detekt config between Fenix and Android Components ... Co-authored-by: Gabriel Luong <gabriel.luong@gmail.com>	2 years ago
Mugurell	cb32b1437e	For #17917 - Remove the `kotlin-android-extensions` plugin ... This means no code will be generated by Kotlin Android Extensions for caching views and also for @Parcelize annotated classes. As recommended in the official documentation https://developer.android.com/topic/libraries/view-binding/migration#gradle we need to switch on using `kotlinx.parcelize.Parcelize` instead of `import kotlinx.android.parcel.Parcelize` For #17917 - Remove the `kotlin-android-extensions` plugin This means no code will be generated by Kotlin Android Extensions for caching views and also for @Parcelize annotated classes. As recommended in the official documentation https://developer.android.com/topic/libraries/view-binding/migration#gradle we need to switch on using `kotlinx.parcelize.Parcelize` instead of `import kotlinx.android.parcel.Parcelize`	3 years ago
Roger Yang	74c1cc82fb	Closes #19921: Update appcompat and fragment dependencies to 1.3.x	3 years ago
MarcLeclair	990bfa7e6d	16900 make navgraph inflation asynchronous (#18889) ... * For #16900: implement async navgraph inflation For #16900: removed nav graph from xml For #16900: inflate navGraph programatically For #16900: Made NavGraph inflation asynchronous For #16900: Changed to block with runBlocking For #16900: Refactored blocking call into a function For 16900: NavGraph inflation is now async We now attach the nav graph (or check if its attached) on every nav call ( an extension function for NavController). This is done by checking the value of the job stored in PerfNavController.map which keeps track of the job with the NavController as a Key. If the job hasn't been completed, it will block the main thread until the job is done. The job itself is responsible for attaching the navgraph to the navcontroller (and the inflation of the latter too) For 16900: rebased upstream master For 16900: Rebase on master For #16900: Fixed Async Navgraph navigation per review comments. 1)The Asynchronous method is now found in NavGraphProvider.kt. It creates a job on the IO dispatcher 2)The Job is tracked through a WeakHashMap from Controller --> NavGraph 3)The Coroutine scope doesn't use MainScope() anymore 4)The Coroutine is cancelled if the Activity is destroyed 5)The tests mockk the blockForNavGraphInflation method through the FenixReoboelectricTestApplication instead of calling the mock every setup() For #16900: inflateNavGraphAsync now takes navController For #16900: Pass lifecycleScope to NavGraphProvider For #16900: removed unused mock For #16900: Added linter rules for navigate calls We need linting rules to make sure no one calls the NavController.navigate() methods For #16900: Added TestRule to help abstract the mocks in the code For 16900: Fix linting problems For #16900: Cleaned duplicated code in tests For #16900: cleaned up NavGraphTestRule for finished test For #16900: had to revert an accidentally edited file For #16900: rebased master * For #16900: Review nits for async navgraph This is composed of squash commits, the original messages can be found below: -> DisableNavGraphProviderAssertionRule + kdoc. Use test rule in RobolectricApplication. Fix failing CrashReporterControllerTest Fix blame by -> navigate in tests. This commit was generated by the following commands only: ``` find app/src/test -type f -exec sed -i '' "/import org.mozilla.fenix.ext.navigateBlockingForAsyncNavGraph/d" {} \; find app/src/test -type f -exec sed -i "" "s/navigateBlockingForAsyncNavGraph/navigate/g" {} \; git checkout app/src/test/resources/mockito-extensions/org.mockito.plugins.MockMaker ``` Fix various blame This is expected to be squashed into the first commit so, if so, it'd fix the blame. Move test rule to helpers pkg. add missing license header Add import change I missed fix unused imports Replace robolectricTestrunner with test rule. Improve navGraphProvider docs Remove unnecessary rule as defined by robolectric. add clarifying comment to robolectric remove unnecessary space * For #16900: nit fixes for MozillaNavigateCheck and lint fixes 3 squash commits: *Changed violation message and fixed the lint rule for MozillaNavigateCheck *Added suppression to NavController.kt *Fixed detekt violations * For 16900: Fixed failing tests Co-authored-by: Michael Comella <michael.l.comella@gmail.com>	3 years ago
Michael Comella	0f770ca39b	For #15279: add MozillaUseLazyMonitored custom detekt rule.	4 years ago
MarcLeclair	7b1af41b40	15278 detekt rule runblocking (#15942) ... * For #15278: added CoroutineManager to count runBlocking calls * For #15278: Added actual detekt rule for runblocking and its config to the yaml * For #15278: Added unit test for RunblockingCounter * For #15278: renamed StrictModeStartupSuppressionCountTest.kt to PerformanceStartupTest.kt and added runBlockingCount test * Lint fix * For #15278: made runblocking a Long to prevent overflow * For #15278: fixed MozRunblocking name, description and moved RunBlockingCounter to perf package * For #15278:Renamed MozillaRunblockingCheck to MozillaRunBlockingCheck * For #15278: Added setup for unit test, since it failed without restting counter * For #15278: Fixed naming for RunBlocking lint check * For #15278: removed changes made to test to use runBlockingIncrement * For #15728: added test exclusion for runBlocking check * For #15278: changed null check and added Synchronized to count setter * For #15278: fix for nits * For #15278: added StartupExcessiveResourceUseTest to CODEOWNERS * For #15278: fixed for nits * For #15278: Moved increment function to extension function and fixed indentation * For #15278: Added tests for Atomic Integer extension and nit fix	4 years ago
Michael Comella	d2467f7541	For #13959 - post: ignore new StrictMode rule in tests.	4 years ago
Michael Comella	3b5d6d58d9	For #13959: add MozillaStrictModeSuppression detekt check.	4 years ago
Michael Comella	f690f8736d	No issue: replace LintUnitTestRunner with detekt implementation. ... This should be more performant and easier to maintain.	4 years ago
Kainalu Hagiwara	52d4ffdef0	For #13424 - Fix detekt config and warnings.	4 years ago
Tiger Oakes	61d6b333de	Update LongParameterList baseline	4 years ago
liuche	09d0688e64	CI for PR #9705 (#12748) ... * #3880. Update detekt to 1.9.1 * #3880. Use `AbsentOrWrongFileLicense` detekt rule * #3880. Update detekt baseline Co-authored-by: Denys M <dector9@gmail.com>	4 years ago
Emily Kager	b94ac93ce9	Upgrade to detekt 1.6.0 (#9306) ... Changelog: https://arturbosch.github.io/detekt/changelog.html Fixes #7360. Also use more exact test glob. Co-authored-by: Andrew Gaul <andrew@gaul.org>	4 years ago
Will Hawkins	f69009aa9e	No Issue: Add custom detekt rule to blacklist certain properties ... Add a custom detekt rule to blacklist certain properties. This is immediately useful for making sure that developers do not configure runtime behavior using the `BuildConfig.DEBUG` property but it is useful in a wider context.	4 years ago
Jeff Boek	68f5d211d3	For #4326 - Updates codebase to support latest version of detekt	5 years ago
Tiger Oakes	4994554576	No issue: Adds lint exception for when statement (#3685)	5 years ago
Colin Lee	b2b6a530d0	Make ktlint and detekt style changes	5 years ago