From 17014f9281b0aab04d6c0e8f64e4d0ff4e2d0bae Mon Sep 17 00:00:00 2001
From: poire-z <poire-z@users.noreply.github.com>
Date: Fri, 25 Aug 2017 18:55:44 +0200
Subject: [PATCH] Avoid settings double save when leaving Reader (#3131)

---
 frontend/apps/reader/readerui.lua | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/frontend/apps/reader/readerui.lua b/frontend/apps/reader/readerui.lua
index 3bdbee14e..cf4ec6841 100644
--- a/frontend/apps/reader/readerui.lua
+++ b/frontend/apps/reader/readerui.lua
@@ -547,7 +547,11 @@ end
 
 function ReaderUI:onClose()
     logger.dbg("closing reader")
-    self:saveSettings()
+    -- if self.dialog is us, we'll have our onFlushSettings() called
+    -- by UIManager:close() below, so avoid double save
+    if self.dialog ~= self then
+        self:saveSettings()
+    end
     if self.document ~= nil then
         logger.dbg("closing document")
         self:notifyCloseDocument()