From 2aa9d5d64e0e475e7ae8b97cfd5e7b20f2f16d5c Mon Sep 17 00:00:00 2001
From: Qingping Hou <dave2008713@gmail.com>
Date: Thu, 2 Feb 2017 03:13:13 -0800
Subject: [PATCH] test: add unit tests for docsettings

---
 Makefile                       | 2 +-
 frontend/docsettings.lua       | 2 ++
 spec/unit/docsettings_spec.lua | 9 +++++++++
 3 files changed, 12 insertions(+), 1 deletion(-)

diff --git a/Makefile b/Makefile
index 25df5fce7..3f90446bc 100644
--- a/Makefile
+++ b/Makefile
@@ -119,7 +119,7 @@ coverage: $(INSTALL_DIR)/koreader/.luacov
 			--coverage --exclude-tags=nocov
 	# coverage report summary
 	cd $(INSTALL_DIR)/koreader && tail -n \
-		+$$(($$(grep -nm1 Summary luacov.report.out|cut -d: -f1)-1)) \
+		+$$(($$(grep -nm1 -e "^Summary$$" luacov.report.out|cut -d: -f1)-1)) \
 		luacov.report.out
 
 fetchthirdparty:
diff --git a/frontend/docsettings.lua b/frontend/docsettings.lua
index 0a4396053..9b7d0a05e 100644
--- a/frontend/docsettings.lua
+++ b/frontend/docsettings.lua
@@ -2,6 +2,7 @@ local lfs = require("libs/libkoreader-lfs")
 local DataStorage = require("datastorage")
 local dump = require("dump")
 local purgeDir = require("ffi/util").purgeDir
+local logger = require("logger")
 
 local DocSettings = {}
 
@@ -24,6 +25,7 @@ function DocSettings:getSidecarDir(doc_path)
     end
     -- We shouldn't be called with anything but files with registered
     -- extensions, but in case we are, return something useful
+    logger.err("getSidecarFile called with unexpected path:", doc_path)
     return doc_path..".sdr"
 end
 
diff --git a/spec/unit/docsettings_spec.lua b/spec/unit/docsettings_spec.lua
index a887ee375..ccec9034f 100644
--- a/spec/unit/docsettings_spec.lua
+++ b/spec/unit/docsettings_spec.lua
@@ -14,6 +14,15 @@ describe("docsettings module", function()
         assert.Equals("baz.sdr", docsettings:getSidecarDir("baz.pdf"))
     end)
 
+    it("should generate sidecar metadata file", function()
+        assert.Equals("../../foo.sdr/metadata.pdf.lua",
+                      docsettings:getSidecarFile("../../foo.pdf"))
+        assert.Equals("/foo/bar.sdr/metadata.pdf.lua",
+                      docsettings:getSidecarFile("/foo/bar.pdf"))
+        assert.Equals("baz.sdr/metadata.epub.lua",
+                      docsettings:getSidecarFile("baz.epub"))
+    end)
+
     it("should read legacy history file", function()
         local file = "file.pdf"
         local d = docsettings:open(file)