From 37bab4fe8987bf18281b0717ef0f270914b09821 Mon Sep 17 00:00:00 2001 From: Frans de Jonge Date: Sat, 31 Aug 2019 12:43:19 +0200 Subject: [PATCH] [fix] Pass plain link to link:onGotoLink (#5286) Internal links carry more baggage than external ones. See . --- frontend/apps/reader/modules/readerhighlight.lua | 3 ++- frontend/ui/widget/dictquicklookup.lua | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/frontend/apps/reader/modules/readerhighlight.lua b/frontend/apps/reader/modules/readerhighlight.lua index c6ffec366..e7a848fa5 100644 --- a/frontend/apps/reader/modules/readerhighlight.lua +++ b/frontend/apps/reader/modules/readerhighlight.lua @@ -861,7 +861,8 @@ function ReaderHighlight:onHoldRelease() { text = _("Follow Link"), callback = function() - self.ui.link:onGotoLink(self.selected_link) + local link = self.selected_link.link or self.selected_link + self.ui.link:onGotoLink(link) self:onClose() end, }, diff --git a/frontend/ui/widget/dictquicklookup.lua b/frontend/ui/widget/dictquicklookup.lua index 9ecff9734..193f592db 100644 --- a/frontend/ui/widget/dictquicklookup.lua +++ b/frontend/ui/widget/dictquicklookup.lua @@ -457,8 +457,9 @@ function DictQuickLookup:update() UIManager:close(self) self:lookupWikipedia() else + local link = self.selected_link.link or self.selected_link + self.ui.link:onGotoLink(link) self:onClose() - self.ui.link:onGotoLink(self.selected_link) end end, },