From 39744d7642d267b92f4f1762a52f56bc57993b6e Mon Sep 17 00:00:00 2001 From: NiLuJe Date: Sat, 20 Jan 2024 04:08:36 +0100 Subject: [PATCH] TouchMenu: TouchMenuItem's UnderlineContainer should probably have its own dimen object The coordinates could wonky otherwise, as TouchMenuItem is an InputContainer. Mostly harmless in practice as that UC is its main widget. --- frontend/ui/widget/container/underlinecontainer.lua | 2 +- frontend/ui/widget/touchmenu.lua | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/frontend/ui/widget/container/underlinecontainer.lua b/frontend/ui/widget/container/underlinecontainer.lua index fc3d428c9..de130e34c 100644 --- a/frontend/ui/widget/container/underlinecontainer.lua +++ b/frontend/ui/widget/container/underlinecontainer.lua @@ -12,7 +12,7 @@ local WidgetContainer = require("ui/widget/container/widgetcontainer") local UnderlineContainer = WidgetContainer:extend{ linesize = Size.line.thick, padding = Size.padding.tiny, - --- @todo shouldn't this default to black instead? + -- We default to white to be invisible by default for FocusManager use-cases (only switching to black @ onFocus) color = Blitbuffer.COLOR_WHITE, vertical_align = "top", } diff --git a/frontend/ui/widget/touchmenu.lua b/frontend/ui/widget/touchmenu.lua index 913657bae..28cce7f49 100644 --- a/frontend/ui/widget/touchmenu.lua +++ b/frontend/ui/widget/touchmenu.lua @@ -145,8 +145,8 @@ function TouchMenuItem:init() self._underline_container = UnderlineContainer:new{ vertical_align = "center", - dimen = self.dimen, - self.item_frame + dimen = self.dimen:copy(), + self.item_frame, } self[1] = self._underline_container