From 568e8f667a42ba80dd519c7471e4c4b78b7c58aa Mon Sep 17 00:00:00 2001
From: Robert <robert.styla@gmail.com>
Date: Fri, 1 Sep 2017 23:17:35 +0200
Subject: [PATCH] Fix: Crash when highlight a word (#3155)

* Fix: Crash when highlight a word

* reorganize highlight strings

* Remove redundant var
---
 frontend/ui/widget/dictquicklookup.lua | 13 +++++++++----
 1 file changed, 9 insertions(+), 4 deletions(-)

diff --git a/frontend/ui/widget/dictquicklookup.lua b/frontend/ui/widget/dictquicklookup.lua
index 8388ceb93..ba541c69a 100644
--- a/frontend/ui/widget/dictquicklookup.lua
+++ b/frontend/ui/widget/dictquicklookup.lua
@@ -58,6 +58,11 @@ local DictQuickLookup = InputContainer:new{
     refresh_callback = nil,
 }
 
+local highlight_strings = {
+    highlight =_("Highlight"),
+    unhighlight = _("Unhighlight"),
+}
+
 function DictQuickLookup:init()
     self:changeToDefaultDict()
     if Device:hasKeys() then
@@ -330,7 +335,7 @@ function DictQuickLookup:update()
                     text = self:getHighlightText(),
                     enabled = true,
                     callback = function()
-                        if self:getHighlightText() == "Highlight" then
+                        if self:getHighlightText() == highlight_strings.highlight then
                             self.ui:handleEvent(Event:new("Highlight"))
                         else
                             self.ui:handleEvent(Event:new("Unhighlight"))
@@ -481,11 +486,11 @@ end
 function DictQuickLookup:getHighlightText()
     local item = self:getHighlightedItem()
     if not item then
-        return _("Highlight"), false
+        return highlight_strings.highlight, false
     elseif self.ui.bookmark:isBookmarkAdded(item) then
-        return _("Unhighlight"), false
+        return highlight_strings.unhighlight, false
     else
-        return _("Highlight"), true
+        return highlight_strings.highlight, true
     end
 end