From 5a7ecabaedc7f1b1b3322e82595921b001e980cb Mon Sep 17 00:00:00 2001 From: yparitcher Date: Sat, 15 Aug 2020 15:42:27 -0400 Subject: [PATCH] ReaderRolling: fix gotoPercent (#6503) Before it only worked in scroll mode not page mode & it used 10000 instead of 100% --- frontend/apps/reader/modules/readerrolling.lua | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/frontend/apps/reader/modules/readerrolling.lua b/frontend/apps/reader/modules/readerrolling.lua index daf30ff18..1634b7ea4 100644 --- a/frontend/apps/reader/modules/readerrolling.lua +++ b/frontend/apps/reader/modules/readerrolling.lua @@ -188,7 +188,7 @@ function ReaderRolling:onReadSettings(config) --- @fixme remove this branch with migration script elseif last_per then self.setupXpointer = function() - self:_gotoPercent(last_per) + self:_gotoPercent(last_per * 100) -- _gotoPercent calls _gotoPos, which only updates self.current_pos -- and self.view. -- we need to do a real pos change in self.ui.document._document @@ -896,7 +896,11 @@ function ReaderRolling:_gotoPos(new_pos, do_dim_area) end function ReaderRolling:_gotoPercent(new_percent) - self:_gotoPos(new_percent * self.ui.document.info.doc_height / 10000) + if self.view.view_mode == "page" then + self:_gotoPage(new_percent * self.ui.document:getPageCount() / 100) + else + self:_gotoPos(new_percent * self.ui.document.info.doc_height / 100) + end end function ReaderRolling:_gotoPage(new_page, free_first_page)