From 78fdce8e9fb2b0e1efc7a1ff5c4088b06f634bad Mon Sep 17 00:00:00 2001
From: zwim <36999612+zwim@users.noreply.github.com>
Date: Thu, 20 May 2021 19:23:34 +0200
Subject: [PATCH] Dispatcher: fix possible crash when no document (#7716)

---
 frontend/dispatcher.lua | 57 ++++++++++++++++++++++-------------------
 1 file changed, 30 insertions(+), 27 deletions(-)

diff --git a/frontend/dispatcher.lua b/frontend/dispatcher.lua
index e514a3e26..ac084e5c9 100644
--- a/frontend/dispatcher.lua
+++ b/frontend/dispatcher.lua
@@ -617,36 +617,39 @@ arguments are:
 function Dispatcher:execute(ui, settings, gesture)
     for k, v in pairs(settings) do
         if settingsList[k] ~= nil and (settingsList[k].conditions == nil or settingsList[k].conditions == true) then
-            if settingsList[k].category == "none" then
-                if settingsList[k].arg ~= nil then
-                    ui:handleEvent(Event:new(settingsList[k].event, settingsList[k].arg))
-                else
-                    ui:handleEvent(Event:new(settingsList[k].event))
+            -- Be sure we don't send a document setting event if there's not yet or no longer a document
+            if ui.document or (not settingsList[k].paging and not settingsList[k].rolling) then
+                if settingsList[k].category == "none" then
+                    if settingsList[k].arg ~= nil then
+                        ui:handleEvent(Event:new(settingsList[k].event, settingsList[k].arg))
+                    else
+                        ui:handleEvent(Event:new(settingsList[k].event))
+                    end
                 end
-            end
-            if settingsList[k].category == "absolutenumber"
-                or settingsList[k].category == "string"
-            then
-                ui:handleEvent(Event:new(settingsList[k].event, v))
-            end
-            -- the event can accept a gesture object or an argument
-            if settingsList[k].category == "arg" then
-                local arg = gesture or settingsList[k].arg
-                ui:handleEvent(Event:new(settingsList[k].event, arg))
-            end
-            -- the event can accept a gesture object or a number
-            if settingsList[k].category == "incrementalnumber" then
-                local arg = v ~= 0 and v or gesture or 0
-                ui:handleEvent(Event:new(settingsList[k].event, arg))
-            end
-            if ui.document and settingsList[k].configurable then
-                local value = v
-                if type(v) ~= "number" then
-                    for i, r in ipairs(settingsList[k].args) do
-                        if v == r then value = settingsList[k].configurable.values[i] break end
+                if settingsList[k].category == "absolutenumber"
+                    or settingsList[k].category == "string"
+                then
+                    ui:handleEvent(Event:new(settingsList[k].event, v))
+                end
+                -- the event can accept a gesture object or an argument
+                if settingsList[k].category == "arg" then
+                    local arg = gesture or settingsList[k].arg
+                    ui:handleEvent(Event:new(settingsList[k].event, arg))
+                end
+                -- the event can accept a gesture object or a number
+                if settingsList[k].category == "incrementalnumber" then
+                    local arg = v ~= 0 and v or gesture or 0
+                    ui:handleEvent(Event:new(settingsList[k].event, arg))
+                end
+                if ui.document and settingsList[k].configurable then
+                    local value = v
+                    if type(v) ~= "number" then
+                        for i, r in ipairs(settingsList[k].args) do
+                            if v == r then value = settingsList[k].configurable.values[i] break end
+                        end
                     end
+                    ui.document.configurable[settingsList[k].configurable.name] = value
                 end
-                ui.document.configurable[settingsList[k].configurable.name] = value
             end
         end
     end