From 7caa21a3fbb2b1cace7eee227f87650de9554a0e Mon Sep 17 00:00:00 2001 From: poire-z Date: Fri, 18 Oct 2019 17:23:15 +0200 Subject: [PATCH] [chore] Remove uneeded doc_settings:close() (#5504) When just reading settings, no need to close and write the file to disk. --- frontend/document/pdfdocument.lua | 1 - frontend/ui/screensaver.lua | 3 --- 2 files changed, 4 deletions(-) diff --git a/frontend/document/pdfdocument.lua b/frontend/document/pdfdocument.lua index a6b92b7f8..951df0c3b 100644 --- a/frontend/document/pdfdocument.lua +++ b/frontend/document/pdfdocument.lua @@ -69,7 +69,6 @@ function PdfDocument:convertKoptToReflowableFontSize(font_size) if DocSettings:hasSidecarFile(self.file) then local doc_settings = DocSettings:open(self.file) size = doc_settings:readSetting("kopt_font_size") - doc_settings:close() end if size then return size * default_font_size diff --git a/frontend/ui/screensaver.lua b/frontend/ui/screensaver.lua index d761cddad..f85426429 100644 --- a/frontend/ui/screensaver.lua +++ b/frontend/ui/screensaver.lua @@ -176,7 +176,6 @@ function Screensaver:excluded() if DocSettings:hasSidecarFile(lastfile) then local doc_settings = DocSettings:open(lastfile) exclude_ss = doc_settings:readSetting("exclude_screensaver") - doc_settings:close() end return exclude_ss or false end @@ -260,7 +259,6 @@ function Screensaver:show(event, fallback_message) if DocSettings:hasSidecarFile(lastfile) then local doc_settings = DocSettings:open(lastfile) exclude = doc_settings:readSetting("exclude_screensaver") - doc_settings:close() end if exclude ~= true then if lfs.attributes(lastfile, "mode") == "file" then @@ -306,7 +304,6 @@ function Screensaver:show(event, fallback_message) screensaver_type = "message" end doc:close() - doc_settings:close() else screensaver_type = "message" end