From ac15143c14393a9fbb78c09a561bb0253172013d Mon Sep 17 00:00:00 2001 From: Frans de Jonge Date: Fri, 2 Aug 2019 22:43:26 +0200 Subject: [PATCH] [lang] Rename 'Scroll Mode' to 'Continuous' (#5169) The current name causes people to think of scrolling, which is slightly awkward on E Ink. For example, see . > But this on LCD, not E-ink where the lag is unbearable, especially if you want to correct any scrolling over/undershoot. Scroll mode is a misnomer. It should be renamed continuous. I use "scroll mode" as the default, but I seldom or never scroll. Conversely, you can still scroll in paged mode if a page is longer than the screen. As far as I'm concerned if you're scrolling (panning) you may be doing it wrong, but to anyone reading: you do you. ;-) --- frontend/ui/data/koptoptions.lua | 4 ++-- frontend/ui/data/strings.lua | 3 +-- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/frontend/ui/data/koptoptions.lua b/frontend/ui/data/koptoptions.lua index 654ba2d24..6470451ff 100644 --- a/frontend/ui/data/koptoptions.lua +++ b/frontend/ui/data/koptoptions.lua @@ -45,8 +45,8 @@ local KoptOptions = { options = { { name = "page_scroll", - name_text = S.SCROLL_MODE, - toggle = {S.ON, S.OFF}, + name_text = S.VIEW_MODE, + toggle = {S.VIEW_SCROLL, S.VIEW_PAGE}, values = {1, 0}, default_value = DSCROLL_MODE, event = "SetScrollMode", diff --git a/frontend/ui/data/strings.lua b/frontend/ui/data/strings.lua index a93134212..2df9ee5a5 100644 --- a/frontend/ui/data/strings.lua +++ b/frontend/ui/data/strings.lua @@ -6,7 +6,6 @@ S.SCREEN_MODE = _("Orientation") S.DUAL_PAGES = _("Dual Pages") S.PAGE_CROP = _("Page Crop") S.FULL_SCREEN = _("Full Screen") -S.SCROLL_MODE = _("Scroll Mode") S.ZOOM_DPI = _("Zoom (dpi)") S.PAGE_MARGIN = _("Margin") S.H_PAGE_MARGINS = _("L/R Margins") @@ -72,7 +71,7 @@ S.PORTRAIT = _("portrait") S.LANDSCAPE = _("landscape") S.REGULAR = _("regular") S.BOLD = _("bold") -S.VIEW_SCROLL = _("scroll") +S.VIEW_SCROLL = _("continuous") S.VIEW_PAGE = _("page") S.LTR = _("LTR") S.RTL = _("RTL")