diff --git a/frontend/apps/reader/modules/readercropping.lua b/frontend/apps/reader/modules/readercropping.lua index ad69c67d9..b7a50b8ff 100644 --- a/frontend/apps/reader/modules/readercropping.lua +++ b/frontend/apps/reader/modules/readercropping.lua @@ -21,8 +21,6 @@ function ReaderCropping:onPageCrop(mode) -- backup original zoom mode as cropping use "page" zoom mode self.orig_zoom_mode = self.view.zoom_mode if mode == "auto" then - --- @fixme: This is weird. "auto" crop happens to be the default, yet the default zoom mode/genus is "page", not "content". - --- This effectively yields different results whether auto is enabled by default, or toggled at runtime... if self.document.configurable.text_wrap ~= 1 then self:setCropZoomMode(true) end diff --git a/frontend/apps/reader/modules/readerzooming.lua b/frontend/apps/reader/modules/readerzooming.lua index 9247242cd..50cd5b518 100644 --- a/frontend/apps/reader/modules/readerzooming.lua +++ b/frontend/apps/reader/modules/readerzooming.lua @@ -230,11 +230,10 @@ function ReaderZooming:onReadSettings(config) -- Otherwise, build it from the split genus & type settings local zoom_mode_genus = config:readSetting("kopt_zoom_mode_genus") or G_reader_settings:readSetting("kopt_zoom_mode_genus") + or 3 -- autocrop is default then pagewidth will be the default as well local zoom_mode_type = config:readSetting("kopt_zoom_mode_type") or G_reader_settings:readSetting("kopt_zoom_mode_type") - if zoom_mode_genus or zoom_mode_type then - zoom_mode = self:combo_to_mode(zoom_mode_genus, zoom_mode_type) - end + zoom_mode = self:combo_to_mode(zoom_mode_genus, zoom_mode_type) -- Validate it zoom_mode = self.zoom_mode_label[zoom_mode] and zoom_mode or self.DEFAULT_ZOOM_MODE diff --git a/spec/unit/readerhighlight_spec.lua b/spec/unit/readerhighlight_spec.lua index 3808b76c0..ae1ff4432 100644 --- a/spec/unit/readerhighlight_spec.lua +++ b/spec/unit/readerhighlight_spec.lua @@ -231,6 +231,7 @@ describe("Readerhighlight module", function() document = DocumentRegistry:openDocument(sample_pdf), _testsuite = true, } + readerui.document.configurable.trim_page = 3 readerui:handleEvent(Event:new("SetScrollMode", true)) end) teardown(function()