From c1f19e943ab5c6c0aa7f5ecb05263cdf0ae5a022 Mon Sep 17 00:00:00 2001 From: poire-z Date: Sun, 8 Mar 2020 20:22:12 +0100 Subject: [PATCH] Make xpointers migration ConfirmBox non-dismissable (#5931) Because dismissing it by tapping outside would have "not for this book" selected, which is the least welcome action. --- frontend/apps/reader/modules/readerrolling.lua | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/frontend/apps/reader/modules/readerrolling.lua b/frontend/apps/reader/modules/readerrolling.lua index 7df665126..808db761a 100644 --- a/frontend/apps/reader/modules/readerrolling.lua +++ b/frontend/apps/reader/modules/readerrolling.lua @@ -1276,6 +1276,10 @@ Note that %1 (out of %2) xpaths from your bookmarks and highlights have been nor UIManager:show(ConfirmBox:new{ text = text, + -- Given the layout of the buttons (Cancel|OK, and a big other button below + -- with "Not now"), we don't want cancel_callback to be called when dismissing + -- this ConfirmBox by taping outside. So, make it non dismissable. + dismissable = false, other_buttons = {{ { -- this is the real cancel/do nothing