From cfd1f07f0e287b4abe96150539ff88d3d414dda2 Mon Sep 17 00:00:00 2001 From: ciro Date: Fri, 8 Nov 2013 10:42:06 +0800 Subject: [PATCH] fixed issue: https://github.com/koreader/koreader/issues/354 --- frontend/apps/filemanager/filemanagerhistory.lua | 15 +++++++++------ 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/frontend/apps/filemanager/filemanagerhistory.lua b/frontend/apps/filemanager/filemanagerhistory.lua index 549eea46e..0174a6269 100644 --- a/frontend/apps/filemanager/filemanagerhistory.lua +++ b/frontend/apps/filemanager/filemanagerhistory.lua @@ -56,12 +56,15 @@ end function FileManagerHistory:updateItemTable() function readHistDir(order_arg, re) - local pipe_out = io.popen("ls "..order_arg.." -1 ./history") - for f in pipe_out:lines() do - table.insert(re, { - dir = DocSettings:getPathFromHistory(f), - name = DocSettings:getNameFromHistory(f), - }) + for f in lfs.dir("./history") do + local filemode = lfs.attributes(f, "mode") + + if filemode ~= "directory" then -- we can't use filemode == "file" here, when it should be "file" it is actually nil, weird + table.insert(re, { + dir = DocSettings:getPathFromHistory(f), + name = DocSettings:getNameFromHistory(f), + }) + end end end