From e44c170f59c2097e34973f620b1656f57ce5463d Mon Sep 17 00:00:00 2001 From: poire-z Date: Tue, 16 Feb 2021 13:20:32 +0100 Subject: [PATCH] Wikipedia results: fix images not updated across results Some results fields were forgotten by the "smarter update" from a38881a9. --- frontend/ui/widget/dictquicklookup.lua | 4 ++++ frontend/ui/widget/textboxwidget.lua | 1 + 2 files changed, 5 insertions(+) diff --git a/frontend/ui/widget/dictquicklookup.lua b/frontend/ui/widget/dictquicklookup.lua index 309fe6bf8..8e21e26a3 100644 --- a/frontend/ui/widget/dictquicklookup.lua +++ b/frontend/ui/widget/dictquicklookup.lua @@ -810,7 +810,11 @@ function DictQuickLookup:update() self.text_widget:resetScroll() elseif not self.is_html and self.stw_widget then -- Re-use our ScrollTextWidget (self.stw_widget) + -- Update properties that may change across results (as done in DictQuickLookup:_instantiateScrollWidget()) self.text_widget.text_widget.text = self.definition + self.text_widget.text_widget.lang = self.lang and self.lang:lower() + self.text_widget.text_widget.para_direction_rtl = self.rtl_lang + self.text_widget.text_widget.images = self.images -- NOTE: The recursive free via our WidgetContainer (self[1]) above already free'd us ;) self.text_widget.text_widget:init() -- Scroll back to top diff --git a/frontend/ui/widget/textboxwidget.lua b/frontend/ui/widget/textboxwidget.lua index 70df5271b..e340ad942 100644 --- a/frontend/ui/widget/textboxwidget.lua +++ b/frontend/ui/widget/textboxwidget.lua @@ -244,6 +244,7 @@ end -- Split the text into logical lines to fit into the text box. function TextBoxWidget:_splitToLines() self.vertical_string_list = {} + self.line_num_to_image = nil local idx = 1 local size = #self.charlist