From eb1e084d931d13a7faafb447c2a7cad352765656 Mon Sep 17 00:00:00 2001 From: Roygbyte <82218266+roygbyte@users.noreply.github.com> Date: Mon, 7 Nov 2022 13:21:50 -0400 Subject: [PATCH] NewsDownloader: avoid some crashes (#9697) Keep nil reference from being passed to UIManager. --- plugins/newsdownloader.koplugin/main.lua | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/plugins/newsdownloader.koplugin/main.lua b/plugins/newsdownloader.koplugin/main.lua index c056469d0..a84c903cb 100644 --- a/plugins/newsdownloader.koplugin/main.lua +++ b/plugins/newsdownloader.koplugin/main.lua @@ -678,7 +678,7 @@ function NewsDownloader:viewFeedList() } ) -- Show the list of feeds. - if #self.kv ~= 0 then + if self.kv then UIManager:close(self.kv) end self.kv = KeyValuePage:new{ @@ -693,7 +693,7 @@ function NewsDownloader:viewFeedList() end function NewsDownloader:viewFeedItem(data) - if #self.kv ~= 0 then + if self.kv then UIManager:close(self.kv) end self.kv = KeyValuePage:new{ @@ -802,7 +802,7 @@ function NewsDownloader:updateFeedConfig(id, key, value) -- Because this method is called at the menu, -- we might not have an active view. So this conditional -- statement avoids closing a null reference. - if #self.kv ~= 0 then + if self.kv then UIManager:close(self.kv) end -- It's possible that we will get a null value.