Browse Source

Bug report changes (#7709)

* android: dump logcat to file
* Update .github/ISSUE_TEMPLATE/bug_report.md

Co-authored-by: Frans de Jonge <fransdejonge@gmail.com>
reviewable/pr7741/r1
Martín Fernández 5 months ago
committed by GitHub
parent
commit
fdb0539aae
No known key found for this signature in database GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 22 additions and 6 deletions
  1. +2
    -2
      .github/ISSUE_TEMPLATE/bug_report.md
  2. +19
    -3
      frontend/ui/elements/common_info_menu_table.lua
  3. +1
    -1
      platform/android/luajit-launcher

+ 2
- 2
.github/ISSUE_TEMPLATE/bug_report.md View File

@ -23,8 +23,8 @@ normally be found in the KOReader directory:
* `.adds/koreader/` directory for Kobo
* `applications/koreader/` directory for Pocketbook
Android won't have a crash.log file because Google restricts what apps can log, so you'll need to obtain logs using `adb logcat KOReader:I ActivityManager:* AndroidRuntime:* DEBUG:* *:F`.
Android logs are kept in memory. Please go to Help → Bug Report to save these logs to a file.
Please try to include the relevant sections in your issue description.
You can upload the whole `crash.log` file on GitHub by dragging and
@ -33,7 +33,7 @@ dropping it onto this textbox.
If you instead opt to inline it, please do so behind a spoiler tag:
<details>
<summary>crash.log</summary>
```
<Paste crash.log content here>
```

+ 19
- 3
frontend/ui/elements/common_info_menu_table.lua View File

@ -53,10 +53,26 @@ common_info.about = {
common_info.report_bug = {
text = _("Report a bug"),
keep_menu_open = true,
callback = function()
callback_func = function()
local DataStorage = require("datastorage")
local log_path = string.format("%s/%s", DataStorage:getDataDir(), "crash.log")
local common_msg = T(_("Please report bugs to \nhttps://github.com/koreader/koreader/issues\n\nVersion:\n%1\n\nDetected device:\n%2"),
Version:getCurrentRevision(), Device:info())
local log_msg = T(_("Attach %1 to your bug report."), log_path)
if Device:isAndroid() then
local android = require("android")
android.dumpLogs(log_path)
end
local msg
if lfs.attributes(log_path, "mode") == "file" then
msg = string.format("%s\n\n%s", common_msg, log_msg)
else
msg = common_msg
end
UIManager:show(InfoMessage:new{
text = T(_("Please report bugs to \nhttps://github.com/koreader/koreader/issues\n\nVersion:\n%1\n\nDetected device:\n%2"),
Version:getCurrentRevision(), Device:info()),
text = msg,
})
end
}

+ 1
- 1
platform/android/luajit-launcher

@ -1 +1 @@
Subproject commit 76f10d206a8b07924630598667872b0cd7ede64c
Subproject commit b1697e48fa87077ede7455b10fa212a43dfdde11

Loading…
Cancel
Save