Commit Graph

37 Commits (850be52177a08114013fa6af11a36f1e4081918a)

Author SHA1 Message Date
poire-z 850be52177
Keep some menus open when Tap or Hold (#4189)
TouchMenu: added options to menu items with the following defaults:
    keep_menu_open = false
    hold_keep_menu_open = true
So, default for Tap callback is to close menu, and for Hold callback
to keep menu open.
In both cases, provide the TouchMenu instance as the 1st argument to
the callback functions (instead of a refresh_menu_func I added in #3941)
so the callback can do more things, like closing, refreshing,
changing menu items text and re-ordering...

ReaderZooming: show symbol for default (like it was done for
ReaderFont, ReaderHyphenation...)
TextEditor plugin: update the previously opened files list in real
time, so the menu can be kept open and used as the TextEditor main
interface.
SSH plugin: keep menu open and update the Start/Stop state in real time
ReadTimer plugin: tried to do what feels right (but I don't use it)

Also remove forgotten cp in the move/paste file code
6 years ago
poire-z 8c9fe9b589
Allow following links to local files (#4064)
Also use the new ReaderUI:switchDocument(new_file) when
already in ReaderUI in the other cases we switch document.
6 years ago
poire-z 8ee741f538
Fix occasional incoherent back xpointer when following a link (#4061)
In rare cases, the origin xpointer when following a link
was detected as incoherent, and not used when going back,
so no left margin marker was shown.
6 years ago
poire-z 9b6b91b743
TouchMenu: added hook to show help text on long-press (#3980)
When Hold and there is no hold callback attached to a menu item, a help_text
attribute, when present, is shown in an InfoMessage.
6 years ago
Robert 136a72f316 [UX] Notification are displayed too short (#3962)
Changed from 1 second to 2.

I also fixed the problem with blocking the UI when displaying the message. Now notification box is closed after taping anywhere (like InfoMessage).
6 years ago
poire-z 2473ebce01
Wikipedia link: check if previously saved as EPUB (#3837)
Also makes MultiConfirmBox movable, like ConfirmBox is.
6 years ago
Frans de Jonge 82ca050a17 [fix, lang] ReaderLink: change location stack to location history (#3671) 6 years ago
poire-z 59496c1d46 Show vertical marker at original position when back from link (#3669)
ReaderLink: make all links be a table (they were a table for PDF,
but a string for CRE) for clearer code. Also have location_stack
store them as tables, with additional properties.
Get original position of link source (and verify it is valid)
so we can show a marker there.

Also:
Hold on "Go back to previous location" to clear location stack.
Resists "Swipe to go back" when previous locations stack has just
become empty, and show a notification.
Fix wrong links with Swipe to follow nearest link on PDF documents.
6 years ago
poire-z a3e2a8073f Full text search: when Go back, go back to initial page
Only add the initial page to the location stack - and not
every search result's page - so we can easily go back to it.
6 years ago
poire-z e615345ffa TOC, bookmarks: remember current page so we can go back to it 6 years ago
Frans de Jonge acacd7a7f8
[UX] Move "Go back to previous location" up one menu level (#3615) 6 years ago
poire-z f5a6e32887 Fix wrong page when tap on link (#3217)
Closes #3216
7 years ago
poire-z 991b56664f Added Swipe to follow nearest link/to jump to latest bookmark (#3207) 7 years ago
Frans de Jonge 7310937219 [fix] "Follow Link" popup issues (#3198)
* Add current location to location stack from follow link popup
  See https://github.com/koreader/koreader/pull/3190#issuecomment-328332771
* Word highlight not removed
* "Follow Link" not translated
* Typo in docs
7 years ago
Frans de Jonge f439ca0e8d [UX] Add "Follow Link" in hold/highlight dialog (#3190)
* This way you can disable "tap to follow links" on single tap yet still follow links.
* Change menu as well as per @poire-z's suggestion.
7 years ago
poire-z 3b813c761f Fix crash on Swipe to follow links with DJVU documents 7 years ago
Frans de Jonge a970a1f034 MenuSorter: fix outside testability (for potential unit tests) 7 years ago
Frans de Jonge b7b5950e98 MenuSorter: review comments and various bug fixes
* fixed wrongful retention of submenus variable and added return to MenuSorter:findById
* fixed readerfooter_spec.lua error
* fixed review comments
7 years ago
Frans de Jonge 5b20106db7 MenuSorter: initial implementation
* Menus are now sanely configurable
* Custom separator placement for clearer menus
7 years ago
Frans de Jonge 3ea18208d7 Removed deprecated Confirmbox option cancel_on_tap_outside = true 7 years ago
Frans de Jonge 67a6eb271d Language: Would you like to read this Wikipedia %1 article?
Discussion on https://www.transifex.com/houqp/koreader/translate/#nb_NO/koreader/106518021

@Frenzie Second option is I came to too. Very consistent and nice.
by kingu, 6 minutes ago

Let's see, I'm not entirely happy with the phrase. Here are a couple of brainstorms.

Would you like to read the full version of this Wikipedia EN article?

Would you like to read this Wikipedia EN article?
by Frenzie, an hour ago

@kingu It's the language code, such as EN, FR, etc.

http://imgur.com/u1q6tT4l.png
by Frenzie, an hour ago

ISSUE
What is %1 here?
by kingu, 3 days ago
7 years ago
poire-z 97d34c5bb0 Better handling of tap on invalid/external links
Tap on external urls or invalid links would jump to
document's 1st page. We check first the validity of the
link, and deal with wikipedia links or just show the external
url.
ConfirmBox: allow dismissing/cancelling by taping outside,
to keep UX consistent.
7 years ago
poire-z efd6c7f556 Added "Swipe to follow first link" option (#2392)
Allow swipe west to jump to current page's first link (easier than clicking on small links)
Also fixed existing function names to comply with style guide.
8 years ago
chrox 2fa8ebb7c4 don't consume swipe gesture event in readerlink
if location stack is empty
8 years ago
Qingping Hou 11d5b5c0a1 fix(readerlink): restore reader view context on go back 8 years ago
Qingping Hou 11ee8d6fcc refactor: use new KeyValuePage widget for displaying statistics 8 years ago
chrox 96dc338812 fix #1570 to disable swipe to go back by default 9 years ago
chrox 263309d0f3 Add option to disable swipe to go back
and add a menu entry "Go back".
This should fix #1443.
9 years ago
chrox 5b76805911 disable follow link by default because it may cause trouble in reflowing mode 9 years ago
chrox b767394fc2 fix #1150 by adding FOLLOW_LINK_TIMEOUT variable 10 years ago
Hans-Werner Hilse 3066c86e38 Refactoring hardware abstraction
This is a major overhaul of the hardware abstraction layer.
A few notes:

General platform distinction happens in
  frontend/device.lua
which will delegate everything else to
  frontend/device/<platform_name>/device.lua
which should extend
  frontend/device/generic/device.lua

Screen handling is implemented in
  frontend/device/screen.lua
which includes the *functionality* to support device specifics.
Actually setting up the device specific functionality, however,
is done in the device specific setup code in the relevant
device.lua file.

The same goes for input handling.
10 years ago
chrox 1462d382d9 fix #1013 10 years ago
chrox e34ad5ffe5 refactoring module registration in readerui
now every module can be looked up in readerui so that
unit test of these modules is possible.
10 years ago
chrox 492a36a7da add follow links option in navigation tab of reader menu
If "Follow links" options is not checked links won't be followed.
The "Follow links" option is checked by default.
This option affect both PDF and EPUB documents.
10 years ago
chrox 8f982faa7b fix page to screen rect transform for highlighting 10 years ago
chrox e1527611c5 show a box indicator when tapping on a link
only for PDF/DJVU docs for now since there is no easy way
to get link box from crengine
10 years ago
Qingping Hou 4b357c1466 move reader code into frontend/apps/reader
it makes more sense to completely separate the UI framework and
application code

also move frontend/ui/configurable.lua to frontend/configurable.lua
10 years ago