Commit Graph

4146 Commits (98515a2210ba1de50dcb3e36c6335b2d71fb4079)
 

Author SHA1 Message Date
chrox 4f35834b2e wrap computation intensive functions in hook free env when makeing coverage test
so that Travis CI job won't fail because of timeout.
10 years ago
Huang Xin 0a94696213 Merge pull request #1324 from variousvirgil/patch-1
Fix #1299
10 years ago
variousvirgil 9c69c1f14e Fix #1299 10 years ago
Huang Xin d9b661ffa7 Merge pull request #1323 from hwhw/master
only open frontlight device on Kobo devices that actually have light
10 years ago
Hans-Werner Hilse 3d73ff5ae7 only open frontlight device on Kobo devices that actually have light 10 years ago
HW 4fb6eae358 Merge pull request #1320 from chrox/master
fix filemanager cannot remember sorting order
10 years ago
chrox eea6f97796 fix #1319 10 years ago
chrox aa9566205b fix filemanager cannot remember sorting order 10 years ago
Huang Xin a505ac2e54 Merge pull request #1316 from hwhw/master
killling/shrinking refreshes
10 years ago
Hans-Werner Hilse ff0fbbdb4b fix widget closing 10 years ago
Hans-Werner Hilse 844c1babf7 UIManager:_refresh(): no more default refresh
If no refresh type is specified, don't do a refresh.
There should be now refresh types specified in all relevant places.
10 years ago
Hans-Werner Hilse 94ce08937a clean up refreshes
This is a larger clean-up of the refresh situation.
The general shift is that refreshes are now mainly triggered by
the (top-level) widgets when they get shown or closed via UIManager.

All refreshes for the widgets when they are in use were handled by
themselves before. This adds the case of showing/closing.

It is the desired result of not having UIManager:show()/:close()
do (full screen) refreshes on its own.
10 years ago
Hans-Werner Hilse 9c4088a3ac small change of UIManager:show(): No more automatic refresh
This eliminates the API difference between the extra parameters of
UIManager:show() and setDirty(). They work the same now.
Note that this also eliminates the automatic refresh that took place
before when using show() without refresh options. It always refreshed
the full screen, which led to too big refresh regions all over the
place. Thus, refresh has now explicitly to be asked for, hopefully
encouraging to implement it in the widget that gets shown (and is
aware about the screen region it covers).

Also add an event that is triggered when a widget is closed:
CloseWidget. So a widget can implement "onCloseWidget()" to trigger
actions upon closing - most commonly, this is a refresh for the area
previously taken by the widget. That way, the widget's user does not
have to take measures to ensure that the area is refreshed later.
10 years ago
Frans de Jonge 2c1eacdbf5 Merge pull request #1314 from chrox/master
make coverage in after_success stage
10 years ago
chrox 20fd6f902e fix #1175 10 years ago
chrox d6c4465c47 fix coverage test fails on OPDS browser module
for some reason luxl.lua has problem when being set hook for luacov
10 years ago
chrox 6a0554f226 make coverage in after_success stage
So that if the coverage job is timeout it won't fail the
CI result.
10 years ago
Huang Xin ddae003925 Merge pull request #1310 from hwhw/master
fixes for scrolling, fix for double-refresh, misc stuff
10 years ago
Hans-Werner Hilse e8642fbad7 use API for refresh when closing widgets in message popups 10 years ago
Hans-Werner Hilse 1091a8a3b9 add refresh control to UIManager:close() 10 years ago
Hans-Werner Hilse e7f7417cd3 refresh only dialog part of the screen for multi-word selection window 10 years ago
Hans-Werner Hilse 143c56c48c record ButtonDialog.dimen 10 years ago
Hans-Werner Hilse 8376e2f821 dictionary window triggers refresh itself, not via show() 10 years ago
Hans-Werner Hilse afb59667c0 allow for more control on refreshes when show()ing widgets
for now, we have show() automatically call setDirty() for the new
widget, as before. However, now show() takes two arguments for
refresh configuration that will get passed on to setDirty().

For compatibility, the default is here in show() to do a partial
refresh. So if you want no refresh triggered (via this show() call),
add a function that doesn't return anything.
10 years ago
HW 33e93342f7 Merge pull request #1312 from Frenzie/master
OPDS: refactored unit test and fixed a minor bug with undefined image_rel
10 years ago
Frans de Jonge 47d7a48555 OPDS: refactored unit test and fixed a minor bug with undefined image_rel 10 years ago
Hans-Werner Hilse 3f9dc46315 fix dict window refresh
was still using old API
also, move this to another place.
10 years ago
Hans-Werner Hilse c4a9903162 on finish of pan gesture when scrolling, do partial refresh
it was set to a full refresh. However, we want to behave as if in
non-scrolling mode and issue a partial refresh. That might get
updated to a full refresh if the full-refresh counter has reached
the limit - which is configurable.
10 years ago
Hans-Werner Hilse 745e3837e0 updating the screen in tap handler of readerfooter is not needed
Was a hack anyway, c.f.
https://github.com/koreader/koreader/pull/1306#discussion_r21057461

Seems to be not needed anymore. If some areas are now not refreshed
anymore, that ought to be fixed in another place.

This also gets rid of redundant screen flashes.
10 years ago
HW b451b10dde Merge pull request #1311 from Frenzie/master
OPDS: embryonic unit test for OPDS browser
10 years ago
Frans de Jonge c25254a7ec OPDS: embryonic unit test for OPDS browser
This initial seed specifically tests against what recently broke in Gutenberg and FeedBooks.
10 years ago
Huang Xin 24daab0420 Merge pull request #1309 from hwhw/master
update base: fixes for tests, libk2pdfopt without mupdf linkage
10 years ago
Hans-Werner Hilse 328169065d update base: fixes for tests, libk2pdfopt without mupdf linkage 10 years ago
Huang Xin a485141324 Merge pull request #1306 from hwhw/master
Refresh refactoring, frontend/UIManager side
10 years ago
Hans-Werner Hilse f02be20a65 refresh fixes for the menus
this will only refresh the areas that actually need to be refreshed.
10 years ago
Hans-Werner Hilse 6793a4fee1 reader config dialog: properly refresh config pane
This serves as a good example for the way refreshes are done:
setDirty("all", function() ... end)
* the "all" will have all widgets on screen repainted.
  In this case that is needed because the config pane has
  different sizes, covering different parts of underlying
  widgets. So they need to be repainted every time.
* the function will return the area to refresh and is evaluated
  after painting. In this example, we take the area that is covered
  by the config pane before switching it (if present at all), and
  hand it to the refresh area function as an upvalue.
  When the function is called later after painting, it will
  use that saved area and combine it with the area that is covered
  then by the widget. That way, parts that are covered no more are
  included in the refresh area, too.
10 years ago
Hans-Werner Hilse bc3ef46fbf update base: use new refresh wait queue
also pull refresh emulation improvement for emulator.
10 years ago
Hans-Werner Hilse 82c26b1f18 adapt widgets to new refresh/repaint API 10 years ago
Hans-Werner Hilse 229c5ad61c change setDirty/refresh API
See documentation in the code.
In short: There is now one single method, setDirty(), that triggers
repaints and/or refreshes.
All variables in UIManager are gone - at least from an external
perspective. Everything is done through setDirty().
This also allows for easier debugging, since all requests come
in via function calls.
10 years ago
Hans-Werner Hilse 2f9386cd69 move refresh menu table out of UIManager
no need to clutter a core file of the whole UI concept with definitions
of UI elements
10 years ago
HW d793d73182 Merge pull request #1304 from Frenzie/master
Added some instruction about the translation of variables
10 years ago
Frans de Jonge daccda42d8 Added some instruction about the translation of variables
Simplified building prerequisites
10 years ago
HW abcb94d946 Merge pull request #1303 from Frenzie/language
Add missing util.template definition to readerfrontlight.lua
10 years ago
Frans de Jonge 7fd8f4d2f1 Add missing util.template definition to readerfrontlight.lua
Fixes #1302.
10 years ago
Frans de Jonge d182810292 Merge pull request #1300 from erosennin/opds-ignore-unknown-rels
OPDS: ignore links with unknown rel values, treat empty rel as rel="subsection"
10 years ago
Andrey Golovizin 296f63b22a OPDS: ignore links with unknown rel values, treat empty rel as rel="subsection". 10 years ago
HW cceac98180 Merge pull request #1298 from Frenzie/master
Language: prevent spaces from disappearing in localizations with util.template
10 years ago
Frans de Jonge 73a6f71a0b Prevent spaces from being eaten by Transifex
Fixes #1276
10 years ago
HW d44c014a7f Merge pull request #1297 from Frenzie/language
OPDS catalog: auto-fill http:// if no protocol given and revert #1106
10 years ago
Frans de Jonge 7a87b66fa1 OPDS catalog: auto-fill http:// if no protocol given and revert #1106
This fixes #1259.
10 years ago