mirror of https://github.com/koreader/koreader
You cannot select more than 25 topics
Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
fadee1f5dc
Basically: * Use `extend` for class definitions * Use `new` for object instantiations That includes some minor code cleanups along the way: * Updated `Widget`'s docs to make the semantics clearer. * Removed `should_restrict_JIT` (it's been dead code since https://github.com/koreader/android-luajit-launcher/pull/283) * Minor refactoring of LuaSettings/LuaData/LuaDefaults/DocSettings to behave (mostly, they are instantiated via `open` instead of `new`) like everything else and handle inheritance properly (i.e., DocSettings is now a proper LuaSettings subclass). * Default to `WidgetContainer` instead of `InputContainer` for stuff that doesn't actually setup key/gesture events. * Ditto for explicit `*Listener` only classes, make sure they're based on `EventListener` instead of something uselessly fancier. * Unless absolutely necessary, do not store references in class objects, ever; only values. Instead, always store references in instances, to avoid both sneaky inheritance issues, and sneaky GC pinning of stale references. * ReaderUI: Fix one such issue with its `active_widgets` array, with critical implications, as it essentially pinned *all* of ReaderUI's modules, including their reference to the `Document` instance (i.e., that was a big-ass leak). * Terminal: Make sure the shell is killed on plugin teardown. * InputText: Fix Home/End/Del physical keys to behave sensibly. * InputContainer/WidgetContainer: If necessary, compute self.dimen at paintTo time (previously, only InputContainers did, which might have had something to do with random widgets unconcerned about input using it as a baseclass instead of WidgetContainer...). * OverlapGroup: Compute self.dimen at *init* time, because for some reason it needs to do that, but do it directly in OverlapGroup instead of going through a weird WidgetContainer method that it was the sole user of. * ReaderCropping: Under no circumstances should a Document instance member (here, self.bbox) risk being `nil`ed! * Kobo: Minor code cleanups. |
2 years ago | |
|---|---|---|
| .. | ||
| apps | 2 years ago | |
| device | 2 years ago | |
| document | 2 years ago | |
| ui | 2 years ago | |
| cache.lua | 2 years ago | |
| cacheitem.lua | 2 years ago | |
| configurable.lua | 3 years ago | |
| dbg.lua | 2 years ago | |
| depgraph.lua | 4 years ago | |
| device.lua | 3 years ago | |
| dispatcher.lua | 2 years ago | |
| docsettings.lua | 2 years ago | |
| dump.lua | 2 years ago | |
| fontlist.lua | 2 years ago | |
| gettext.lua | 2 years ago | |
| httpclient.lua | 8 years ago | |
| languagesupport.lua | 2 years ago | |
| logger.lua | 2 years ago | |
| luadata.lua | 2 years ago | |
| luadefaults.lua | 2 years ago | |
| luasettings.lua | 2 years ago | |
| luxl.lua | 4 years ago | |
| optmath.lua | 2 years ago | |
| persist.lua | 3 years ago | |
| pluginloader.lua | 2 years ago | |
| pluginshare.lua | 2 years ago | |
| random.lua | 5 years ago | |
| readcollection.lua | 4 years ago | |
| readhistory.lua | 2 years ago | |
| socketutil.lua | 2 years ago | |
| userpatch.lua | 2 years ago | |
| util.lua | 2 years ago | |
| version.lua | 2 years ago | |