Delete llarp::util::memFn

It's unnecessary abstraction that barely simplifies anything, and is now
only used in one single place anyway, which is easily replaced with a
(unabstracted) lambda.

llarp/ev/libuv.hpp

@@ -2,7 +2,6 @@
 #include "ev.hpp"
 #include "udp_handle.hpp"
 
-#include <llarp/util/meta/memfn.hpp>
 #include <llarp/util/thread/queue.hpp>
 
 // #include <uvw.hpp>

llarp/router/router.cpp

@@ -11,7 +11,6 @@
 #include <llarp/net/net.hpp>
 #include <llarp/nodedb.hpp>
 #include <llarp/util/logging.hpp>
-#include <llarp/util/meta/memfn.hpp>
 #include <llarp/util/status.hpp>
 
 #include <cstdlib>
@@ -692,7 +691,7 @@ namespace llarp
         _contacts,
         _node_db,
         _loop,
-        util::memFn(&Router::queue_work, this),
+        [this](std::function<void(void)> work) { queue_work(std::move(work)); },
         &_link_manager,
         &_hidden_service_context,
         strictConnectPubkeys,

llarp/service/async_key_exchange.cpp

@@ -4,7 +4,6 @@
 
 #include <llarp/crypto/crypto.hpp>
 #include <llarp/crypto/types.hpp>
-#include <llarp/util/meta/memfn.hpp>
 
 #include <utility>
 

llarp/util/meta/memfn.hpp

@@ -1,72 +0,0 @@
-#ifndef LLARP_UTIL_MEMFN
-#define LLARP_UTIL_MEMFN
-
-#include <memory>
-#include <type_traits>
-#include <utility>
-
-namespace llarp::util
-{
-  // Wraps a member function and instance into a callable object that invokes
-  // the method (non-const overload).
-  template <
-      typename Return,
-      typename Class,
-      typename Derived,
-      typename... Arg,
-      typename = std::enable_if_t<std::is_base_of<Class, Derived>::value>>
-  auto
-  memFn(Return (Class::*f)(Arg...), Derived* self)
-  {
-    return [f, self](Arg... args) -> Return { return (self->*f)(std::forward<Arg>(args)...); };
-  }
-
-  // Wraps a member function and instance into a lambda that invokes the
-  // method (const overload).
-  template <
-      typename Return,
-      typename Class,
-      typename Derived,
-      typename... Arg,
-      typename = std::enable_if_t<std::is_base_of<Class, Derived>::value>>
-  auto
-  memFn(Return (Class::*f)(Arg...) const, const Derived* self)
-  {
-    return [f, self](Arg... args) -> Return { return (self->*f)(std::forward<Arg>(args)...); };
-  }
-
-  // Wraps a member function and shared pointer to an instance into a lambda
-  // that invokes the method.
-  template <
-      typename Return,
-      typename Class,
-      typename Derived,
-      typename... Arg,
-      typename = std::enable_if_t<std::is_base_of<Class, Derived>::value>>
-  auto
-  memFn(Return (Class::*f)(Arg...), std::shared_ptr<Derived> self)
-  {
-    return [f, self = std::move(self)](Arg... args) -> Return {
-      return (self.get()->*f)(std::forward<Arg>(args)...);
-    };
-  }
-
-  // Wraps a member function and shared pointer to an instance into a lambda
-  // that invokes the method (const method overload).
-  template <
-      typename Return,
-      typename Class,
-      typename Derived,
-      typename... Arg,
-      typename = std::enable_if_t<std::is_base_of<Class, Derived>::value>>
-  auto
-  memFn(Return (Class::*f)(Arg...) const, std::shared_ptr<Derived> self)
-  {
-    return [f, self = std::move(self)](Arg... args) -> Return {
-      return (self.get()->*f)(std::forward<Arg>(args)...);
-    };
-  }
-
-}  // namespace llarp::util
-
-#endif