fix dns for smaller domains

5 years ago · 241dba0476
parent b1b6076742
commit 241dba0476
2 changed files with 3 additions and 1 deletions
--- a/llarp/dns/question.cpp
+++ b/llarp/dns/question.cpp
@ -68,7 +68,7 @@ namespace llarp
    bool
    Question::HasTLD(const std::string& tld) const
    {
-      return qname.rfind(tld) == (qname.size() - tld.size()) - 1;
+      return qname.find(tld) != std::string::npos && qname.rfind(tld) == (qname.size() - tld.size()) - 1;
    }

    std::ostream&
--- a/test/dns/test_llarp_dns_dns.cpp
+++ b/test/dns/test_llarp_dns_dns.cpp
@ -43,6 +43,8 @@ TEST_F(DNSLibTest, TestHasTLD)
  ASSERT_FALSE(question.HasTLD(tld));
  question.qname = "a.boki.";
  ASSERT_FALSE(question.HasTLD(tld));
+  question.qname = "t.co.";
+  ASSERT_FALSE(question.HasTLD(tld));
 };

 TEST_F(DNSLibTest, TestPTR)