diff --git a/llarp/config/config.cpp b/llarp/config/config.cpp index 02b0ce196..22b826be2 100644 --- a/llarp/config/config.cpp +++ b/llarp/config/config.cpp @@ -166,12 +166,12 @@ namespace llarp conf.defineOption( "network", "reachable", false, ReachableDefault, AssignmentAcceptor(m_reachable)); - conf.defineOption("network", "hops", false, HopsDefault, [this](int arg) { + conf.defineOption("network", "hops", false, HopsDefault, [](int arg) { if (arg < 1 or arg > 8) throw std::invalid_argument("[endpoint]:hops must be >= 1 and <= 8"); }); - conf.defineOption("network", "paths", false, PathsDefault, [this](int arg) { + conf.defineOption("network", "paths", false, PathsDefault, [](int arg) { if (arg < 1 or arg > 8) throw std::invalid_argument("[endpoint]:paths must be >= 1 and <= 8"); }); diff --git a/llarp/dht/context.cpp b/llarp/dht/context.cpp index d579b92c3..db409b30b 100644 --- a/llarp/dht/context.cpp +++ b/llarp/dht/context.cpp @@ -141,7 +141,7 @@ namespace llarp uint64_t txid, const service::EncryptedIntroSet& introset, const Key_t& tellpeer, - uint64_t relayOrder); + uint64_t relayOrder) override; /// send introset to peer from source with S counter and excluding peers void @@ -150,7 +150,7 @@ namespace llarp uint64_t txid, const service::EncryptedIntroSet& introset, const Key_t& tellpeer, - uint64_t relayOrder); + uint64_t relayOrder) override; /// initialize dht context and explore every exploreInterval milliseconds void diff --git a/llarp/net/exit_info.cpp b/llarp/net/exit_info.cpp index 6e37f2513..c12220d97 100644 --- a/llarp/net/exit_info.cpp +++ b/llarp/net/exit_info.cpp @@ -92,7 +92,8 @@ namespace llarp } std::ostream& - ExitInfo::print(std::ostream& stream, int level, int spaces) const + ExitInfo::print( + std::ostream& stream, [[maybe_unused]] int level, [[maybe_unused]] int spaces) const { /* // TODO: derive these from ipAdress diff --git a/llarp/rpc/rpc.cpp b/llarp/rpc/rpc.cpp index 2d67870e7..4c78957ea 100644 --- a/llarp/rpc/rpc.cpp +++ b/llarp/rpc/rpc.cpp @@ -258,7 +258,7 @@ namespace llarp handler({}, false); return false; } - for (const auto item : itr.value()) + for (const auto& item : itr.value()) { if (not item.is_object()) continue; diff --git a/llarp/service/endpoint.cpp b/llarp/service/endpoint.cpp index 8095df70b..fab2d090b 100644 --- a/llarp/service/endpoint.cpp +++ b/llarp/service/endpoint.cpp @@ -43,7 +43,7 @@ namespace llarp } bool - Endpoint::Configure(const NetworkConfig& conf, const DnsConfig& dnsConf) + Endpoint::Configure(const NetworkConfig& conf, [[maybe_unused]] const DnsConfig& dnsConf) { if (conf.m_paths > 0) numPaths = conf.m_paths; diff --git a/llarp/service/endpoint.hpp b/llarp/service/endpoint.hpp index 059fffd1d..efa45b26a 100644 --- a/llarp/service/endpoint.hpp +++ b/llarp/service/endpoint.hpp @@ -256,7 +256,7 @@ namespace llarp MarkAddressOutbound(const Address&) override; bool - ShouldBundleRC() const + ShouldBundleRC() const override { return false; } diff --git a/test/test_libabyss.cpp b/test/test_libabyss.cpp index 34f166b8c..588deee11 100644 --- a/test/test_libabyss.cpp +++ b/test/test_libabyss.cpp @@ -116,7 +116,7 @@ struct ServerHandler : public abyss::httpd::IRPCHandler } Response - HandleJSONRPC(Method_t method, const Params& /*params*/) + HandleJSONRPC(Method_t method, const Params& /*params*/) override { test->AssertMethod(method); test->called = true; diff --git a/test/util/thread/test_llarp_util_queue_manager.cpp b/test/util/thread/test_llarp_util_queue_manager.cpp index aaeca1421..d548bb25e 100644 --- a/test/util/thread/test_llarp_util_queue_manager.cpp +++ b/test/util/thread/test_llarp_util_queue_manager.cpp @@ -89,7 +89,7 @@ class IntQueue } else { - return {}; + return std::nullopt; } }