address issue #510

llarp/dns/message.cpp

@@ -152,8 +152,7 @@ namespace llarp
       return true;
     }
 
-    void
-    Message::AddServFail(RR_TTL_t ttl)
+    void Message::AddServFail(RR_TTL_t)
     {
       if(questions.size())
       {
@@ -162,15 +161,6 @@ namespace llarp
         hdr_fields |= flags_QR | flags_AA | flags_RA;
         // don't allow recursion on this request
         hdr_fields &= ~flags_RD;
-        answers.emplace_back();
-        const auto& question = questions[0];
-        auto& nx             = answers.back();
-        nx.rr_name           = question.qname;
-        nx.rr_type           = question.qtype;
-        nx.rr_class          = question.qclass;
-        nx.ttl               = ttl;
-        nx.rData.resize(1);
-        nx.rData.data()[0] = 0;
       }
     }
 
@@ -294,8 +284,7 @@ namespace llarp
             nx.rr_type  = question.qtype;
             nx.rr_class = question.qclass;
             nx.ttl      = ttl;
-            nx.rData.resize(1);
-            nx.rData.data()[0] = 0;
+            nx.rData.resize(0);
           }
         }
       }