I have no words. (#1438)

So apparently dnsConfig in Router was never set.
Router::networkConfig was set, but only used in the function
which set it and otherwise only passed to another function once.
dnsConfig was only used in one place.

both member variables have been removed in favor of just
referencing Router::m_Config.

Co-authored-by: Thomas Winget <tewinget@gmail.com>
pull/1439/head
Jeff 4 years ago committed by GitHub
parent 3e5dcb34cf
commit 3ec727d844
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

@ -461,7 +461,7 @@ namespace llarp
m_isServiceNode = conf.router.m_isRelay;
networkConfig = conf.network;
auto& networkConfig = conf.network;
/// build a set of strictConnectPubkeys (
/// TODO: make this consistent with config -- do we support multiple strict connections
@ -1218,7 +1218,7 @@ namespace llarp
LogInfo("accepting transit traffic");
paths.AllowTransit();
llarp_dht_allow_transit(dht());
_exitContext.AddExitEndpoint("default-connectivity", networkConfig, dnsConfig);
_exitContext.AddExitEndpoint("default-connectivity", m_Config->network, m_Config->dns);
return true;
}

@ -263,9 +263,6 @@ namespace llarp
void
PumpLL() override;
NetworkConfig networkConfig;
DnsConfig dnsConfig;
const lokimq::address DefaultRPCBindAddr = lokimq::address::tcp("127.0.0.1", 1190);
bool enableRPCServer = false;
lokimq::address rpcBindAddr = DefaultRPCBindAddr;

Loading…
Cancel
Save