From 6e5db4f560241669f2494e177d062cb87b6c86ee Mon Sep 17 00:00:00 2001 From: Jason Rhinelander Date: Tue, 30 Aug 2022 15:57:02 -0300 Subject: [PATCH] Set up sign target dependencies always; mark unsigned package Even if we aren't codesigning, things like the `package` target expect to be able to depend on `notarize` (and thus implicitly sign -> assemble) to require a built package. Also add a `-UNSIGNED` into the built dmg filename. --- cmake/macos.cmake | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/cmake/macos.cmake b/cmake/macos.cmake index 2f15a02fc..1ca3aa0d9 100644 --- a/cmake/macos.cmake +++ b/cmake/macos.cmake @@ -74,6 +74,9 @@ message(STATUS "Using ${CODESIGN_EXT_PROFILE} extension provisioning profile") set(lokinet_installer "${PROJECT_BINARY_DIR}/Lokinet ${PROJECT_VERSION}") +if(NOT CODESIGN) + set(lokinet_installer "${lokinet_installer}-UNSIGNED") +endif() set(lokinet_app "${lokinet_installer}/Lokinet.app") @@ -203,9 +206,9 @@ function(macos_target_setup) COMMAND cp -a "${mac_icon}" "${lokinet_app}/Contents/Resources/icon.icns" ) - if(CODESIGN AND BUILD_GUI) + if(BUILD_GUI) add_dependencies(sign assemble_gui) - elseif(CODESIGN) + else() add_dependencies(sign assemble) endif() endfunction()