Hard code RPC's expectedHostname to 'localhost'

llarp/net/ip_address.cpp

@@ -20,6 +20,8 @@ namespace llarp
     uint16_t port = addr.getPort();
     if (port > 0)
       m_port = port;
+
+    m_empty = addr.isEmpty();
   }
 
   IpAddress&
@@ -32,6 +34,8 @@ namespace llarp
     if (port > 0)
       m_port = port;
 
+    m_empty = addr.isEmpty();
+
     return *this;
   }
 
@@ -57,6 +61,8 @@ namespace llarp
     uint16_t port = addr.getPort();
     if (port > 0)
       m_port = port;
+
+    m_empty = addr.isEmpty();
   }
 
   void
@@ -67,6 +73,8 @@ namespace llarp
 
     m_ipAddress = std::string(str);
     m_port = port;
+
+    m_empty = addr.isEmpty();
   }
 
   bool
@@ -78,7 +86,7 @@ namespace llarp
   bool
   IpAddress::isEmpty() const
   {
-    throw std::runtime_error("FIXME");
+    return m_empty;
   }
 
   SockAddr

llarp/net/ip_address.hpp

@@ -136,6 +136,7 @@ namespace llarp
     };
 
    private:
+    bool m_empty = true;
     std::string m_ipAddress;
     std::optional<uint16_t> m_port = std::nullopt;
   };

llarp/rpc/rpc.cpp

@@ -461,28 +461,7 @@ namespace llarp
       bool
       Start(const IpAddress& addr)
       {
-        // NOTE/TODO: RPC on HTTP here can assume 127.0.0.1 or localhost, this isn't safe to expose
-        //       externally anyway
-        throw std::runtime_error("FIXME: replace with lokimq, or fix this stuff");
-        /*
-        sockaddr_in saddr;
-        saddr.sin_addr.s_addr = htonl(INADDR_LOOPBACK);
-        saddr.sin_family = AF_INET;
-        saddr.sin_port = 1190;
-
-        auto idx = addr.find_first_of(':');
-        if (idx != std::string::npos)
-        {
-          _handler.expectedHostname = addr.substr(0, idx);
-          Addr netaddr{addr.substr(0, idx), addr.substr(1 + idx)};
-          saddr.sin_addr.s_addr = netaddr.ton();
-          saddr.sin_port = htons(netaddr.port());
-        }
-        else
-        {
-          _handler.expectedHostname = addr;
-        }
-        */
+        _handler.expectedHostname = "localhost";
         return _handler.ServeAsync(router->netloop(), router->logic(), addr.createSockAddr());
       }
     };