freebsd set ifname, p sure the solaris version is also borked

ryan: try this

vendor/libtuntap-master/tuntap-unix-freebsd.c

@@ -186,6 +186,7 @@ tuntap_sys_set_ipv4_tap(struct device *dev, t_tun_in_addr *s4, uint32_t bits) {
 	struct ifaliasreq ifrq;
 	struct sockaddr_in mask;
 	struct sockaddr_in addr;
+    struct ifreq ifr;
 
 	(void)memset(&ifrq, 0, sizeof(ifrq));
 	(void)strlcpy(ifrq.ifra_name, dev->if_name, sizeof(ifr.ifr_name));
@@ -284,16 +285,26 @@ tuntap_sys_set_descr(struct device *dev, const char *descr, size_t len) {
 }
 
 int
-tuntap_sys_set_ifname(struct device *dev, const char *ifname, size_t len) {
-	struct ifreq ifr;
-
-	(void)strncpy(ifr.ifr_name, dev->if_name, IF_NAMESIZE);
-	(void)strncpy(ifr.ifr_newname, ifname, len);
-
-	if (ioctl(dev->ctrl_sock, SIOCSIFNAME, &ifr) == -1) {
-		perror(NULL);
-		tuntap_log(TUNTAP_LOG_ERR, "Can't set interface name");
-		return -1;
-	}
-	return 0;
+tuntap_sys_set_ifname(struct device *dev, const char *ifname, size_t len)
+{
+  struct ifreq ifr;
+  char *newname;
+  strlcpy(ifr.ifr_name, dev->ifname, IF_NAMESIZE);
+
+  newname = strdup(ifname);
+  if(newname == NULL)
+  {
+    tuntap_log(TUNTAP_LOG_ERR, "no memory to set ifname");
+    return -1;
+  }
+
+  ifr.ifr_data = newname;
+  if(ioctl(dev->ctrl_sock, SIOCSIFNAME, &ifr) == -1)
+  {
+    free(newname);
+    tuntap_log(TUNTAP_LOG_ERR, "Can't set interface name");
+    return -1;
+  }
+  free(newname);
+  return 0;
 }