Commit Graph

42 Commits (ebd2142114a46d10ad002223fac4c491f008fce0)

Author SHA1 Message Date
Jason Rhinelander ebd2142114 Don't use std::optional::value() because f u macos
This replaces all use of std::optional's `opt.value()` with `*opt`
because macOS is great and the ghost of Steve Jobs says that actually
supporting std::optional's value() method is not for chumps before macOS
10.14.  So don't use it because Apple is great.

Pretty much all of our use of it actually is done better with operator*
anyway (since operator* doesn't do a check that the optional has a
value).

Also replaced *most* of the `has_value()` calls with direct bool
context, except for one in the config section which looked really
confusing at a glance without a has_value().
4 years ago
Jason Rhinelander e470a6d73e C++17 niceties
- class template argument deduction lets us write `std::unique_lock
  foo{mutex}` instead of `std::unique_lock<mutex_type> foo{mutex}` which
  makes the `unique_lock` and `shared_lock` functions unnecessary.

- Replace GNU-specific warn_unused_result attribute with C++17-standard
  [[nodiscard]]

- Remove pre-C++17 workaround code for fold expressions, void_t
4 years ago
Stephen Shelton 273270916e
The Great Wall of Blame
This commit reflects changes to clang-format rules. Unfortunately,
these rule changes create a massive change to the codebase, which
causes an apparent rewrite of git history.

Git blame's --ignore-rev flag can be used to ignore this commit when
attempting to `git blame` some code.
4 years ago
Jeff Becker d2d109e92c
llarp_time_t is now using std::chrono 4 years ago
Jason Rhinelander b4440094b0 De-abseil, part 2: mutex, locks, (most) time
- util::Mutex is now a std::shared_timed_mutex, which is capable of
  exclusive and shared locks.

- util::Lock is still present as a std::lock_guard<util::Mutex>.

- the locking annotations are preserved, but updated to the latest
  supported by clang rather than using abseil's older/deprecated ones.

- ACQUIRE_LOCK macro is gone since we don't pass mutexes by pointer into
  locks anymore (WTF abseil).

- ReleasableLock is gone.  Instead there are now some llarp::util helper
  methods to obtain unique and/or shared locks:
    - `auto lock = util::unique_lock(mutex);` gets an RAII-but-also
      unlockable object (std::unique_lock<T>, with T inferred from
      `mutex`).
    - `auto lock = util::shared_lock(mutex);` gets an RAII shared (i.e.
      "reader") lock of the mutex.
    - `auto lock = util::unique_locks(mutex1, mutex2, mutex3);` can be
      used to atomically lock multiple mutexes at once (returning a
      tuple of the locks).
  This are templated on the mutex which makes them a bit more flexible
  than using a concrete type: they can be used for any type of lockable
  mutex, not only util::Mutex.  (Some of the code here uses them for
  getting locks around a std::mutex).  Until C++17, using the RAII types
  is painfully verbose:

  ```C++
  // pre-C++17 - needing to figure out the mutex type here is annoying:
  std::unique_lock<util::Mutex> lock(mutex);
  // pre-C++17 and even more verbose (but at least the type isn't needed):
  std::unique_lock<decltype(mutex)> lock(mutex);
  // our compromise:
  auto lock = util::unique_lock(mutex);
  // C++17:
  std::unique_lock lock(mutex);
  ```

  All of these functions will also warn (under gcc or clang) if you
  discard the return value.  You can also do fancy things like
  `auto l = util::unique_lock(mutex, std::adopt_lock)` (which lets a
  lock take over an already-locked mutex).

- metrics code is gone, which also removes a big pile of code that was
  only used by metrics:
  - llarp::util::Scheduler
  - llarp:🧵:TimerQueue
  - llarp::util::Stopwatch
4 years ago
Jeff Becker a7a101e33c
more intellegent path failure profiling using LRSM 4 years ago
Jeff Becker ba6f9ed2d7
continue using llarp::openfilestream 5 years ago
Michael 3f53965b71
Remove all use of IBEncodeMessage 5 years ago
Jeff Becker 34533db620
add urgent build that builds over an existing path for an endpoint 5 years ago
Jeff Becker 4bda489437
add explicit enable/disable profiling option, try to always maintain outbound connections. 5 years ago
Jeff Becker 2be3401e08
* refactor profiling function names
* utp link layer make ping less active, pre-emptive pump faster
5 years ago
Jeff Becker 05dc2fb679
decay profiles unconditionally 5 years ago
Jeff Becker 76c5601894
decay profiles faster 5 years ago
Jeff Becker d5161d3d9a
i hate profiling 5 years ago
Jeff Becker 9503cc66f0
add disk worker based file flusher logger
make format

remove package.json
5 years ago
Jeff Becker a45d6db0e0
better profiling 5 years ago
Jeff Becker 5861f4aafa
* less vigorous profiling
* don't spam connections to bootstrap
5 years ago
Jeff Becker c910a2a2fb
more 5 years ago
Jeff Becker 169d8beded
clear profiles on removal 5 years ago
Jeff Becker d4cb6808ec
more 5 years ago
Jeff Becker 07d1f32d0a
tweak timing of decay 5 years ago
Michael 8dfe72cbc9
Fix deadlock in profiling 5 years ago
Jeff Becker 5d3833ef1a
fix dumb as shit path building that causes premature termiantion because of duplicate hops 5 years ago
Jeff Becker 2218749134
Merge remote-tracking branch 'origin/staging' into staging 5 years ago
Jeff Becker eceb55623c
more 5 years ago
sachaaaaa 608efeaa96 Add missing reference operator in profiling.cpp 5 years ago
Jeff cf9d6a1793
Merge pull request #380 from majestrate/staging
Staging
5 years ago
Jeff 1a09a12ee0
Merge branch 'staging' into absl_mutex 5 years ago
Jeff Becker a1bd26a165
update profiling code to decay instead of clearing all stats 5 years ago
Jeff Becker 8331449ab9
update profiles on path build 5 years ago
Michael 61f3273dc4
Add threading annotations and fix potential deadlocks 5 years ago
Michael c5a129ddff
Convert to use abseil synchronisation primitives 5 years ago
Michael 887fb4ac62
Replace insert(make_pair()) with emplace() 5 years ago
Michael f3b0af9d2f
Create CopyableBuffer type 5 years ago
Michael 2de621b0ad
Disable copy constructing llarp_buffer_t 5 years ago
Jeff Becker 41e8691702
make format 5 years ago
Michael 9658c80b48
Minor build fixes 5 years ago
Michael 85dde7b6b0
Move remaining include/llarp headers to llarp/ 6 years ago
Jeff 11753f5d7e clarification for path transfer 6 years ago
Jeff Becker 7027ba2cf1
more agressive network exploration
add install target for makefile
6 years ago
Jeff Becker f5b8d552e1
path peer profiling
propagate introsets better
6 years ago
Jeff Becker 6986f04418
basic router profiling and fix ip rewrite 6 years ago