25 Commits (ffe9bbc984da2f0c48dde2883718bfe7db38f543)

Author	SHA1	Message	Date
Jeff Becker	df4ea34a56	nodedb refactor ... * bump zmq static dep * lokimq -> oxenmq * llarp_nodedb -> llarp::NodeDB * remove all crufty api parts of NodeDB * make NodeDB rc selection api not suck * make path builder api not suck * propagate all above changes so that unit tests work and it all compiles	3 years ago
Jeff	12eb32a816	add conf.d directory for config overrides (#1410) ... * add conf.d directory for config overrides * refactor llarp::Config * add explicit constructor with datadir as parameter * have all config files be passed as std::optional * make Config::LoadDefault private and use std::optional in Config::Load to remove ambiguity * update rest of codebase to reflect above changes * fix pybind * rename bootstrap config skipBootstrap to seednode as it's more descriptive * make seednode configurable * make pybind layer compile * make pybind layer run	4 years ago
Jason Rhinelander	af6caf776a	Config file improvements (#1397) ... * Config file API/comment improvements API improvements: ================= Make the config API use position-independent tag parameters (Required, Default{123}, MultiValue) rather than a sequence of bools with overloads. For example, instead of: conf.defineOption<int>("a", "b", false, true, 123, [] { ... }); you now write: conf.defineOption<int>("a", "b", MultiValue, Default{123}, [] { ... }); The tags are: - Required - MultiValue - Default{value} plus new abilities (see below): - Hidden - RelayOnly - ClientOnly - Comment{"line1", "line2", "line3"} Made option definition more powerful: ===================================== - `Hidden` allows you to define an option that won't show up in the generated config file if it isn't set. - `RelayOnly`/`ClientOnly` sets up an option that is only accepted and only shows up for relay or client configs. (If neither is specified the option shows up in both modes). - `Comment{...}` lets the option comments be specified as part of the defineOption. Comment improvements ==================== - Rewrote comments for various options to expand on details. - Inlined all the comments with the option definitions. - Several options that were missing comments got comments added. - Made various options for deprecated and or internal options hidden by default so that they don't show up in a default config file. - show the section comment (but not option comments) *after* the [section] tag instead of before it as it makes more sense that way (particularly for the [bind] section which has a new long comment to describe how it works). Disable profiling by default ============================ We had this weird state where we use and store profiling by default but never *load* it when starting up. This commit makes us just not use profiling at all unless explicitly enabled. Other misc changes: =================== - change default worker threads to 0 (= num cpus) instead of 1, and fix it to allow 0. - Actually apply worker-threads option - fixed default data-dir value erroneously having quotes around it - reordered ifname/ifaddr/mapaddr (was previously mapaddr/ifaddr/ifname) as mapaddr is a sort of specialization of ifaddr and so makes more sense to come after it (particularly because it now references ifaddr in its help message). - removed peer-stats option (since we always require it for relays and never use it for clients) - removed router profiles filename option (this doesn't need to be configurable) - removed defunct `service-node-seed` option - Change default logging output file to "" (which means stdout), and also made "-" work for stdout. * Router hive compilation fixes * Comments for SNApp SRV settings in ini file * Add extra blank line after section comments * Better deprecated option handling Allow {client,relay}-only options in {relay,client} configs to be specified as implicitly deprecated options: they warn, and don't set anything. Add an explicit `Deprecated` tag and move deprecated option handling into definition.cpp. * Move backwards compat options into section definitions Keep the "addBackwardsCompatibleConfigOptions" only for options in sections that no longer exist. * Fix INI parsing issues & C++17-ify - don't allow inline comments because it seems they aren't allowed in ini formats in general, and is going to cause problems if there is a comment character in a value (e.g. an exit auth string). Additionally it was breaking on a line such as: # some comment; see? because it was treating only `; see?` as the comment and then producing an error message about the rest of the line being invalid. - make section parsing stricter: the `[` and `]` have to be at the beginning at end of the line now (after stripping whitespace). - Move whitespace stripping to the top since everything in here does it. - chop off string_view suffix/prefix rather than maintaining position values - fix potential infinite loop/segfault when given a line such as `]foo[` * Make config parsing failure fatal Load() LogError's and returns false on failure, so we weren't aborting on config file errors. * Formatting: allow `{}` for empty functions/structs Instead of using two lines when empty: { } * Make default dns bind 127.0.0.1 on non-Linux * Don't show empty section; fix tests We can conceivably have sections that only make sense for clients or relays, and so want to completely omit that section if we have no options for the type of config being generated. Also fixes missing empty lines between tests. Co-authored-by: Thomas Winget <tewinget@gmail.com>	4 years ago
Jeff Becker	5b4b1f7aee	disable whitelist in unit test	4 years ago
jeff	75f550434c	change assert to throw an exception instead when service node has no peer stats enable. ... update unit tests so it passes on debian sid	4 years ago
jeff	b6d63968c4	* correct unit tests for exit context so they pass ... * when providing an ip address for inbound links dont throw if they are valid	4 years ago
Stephen Shelton	0f074cff8c	Remove ambguity WRT loading and passing of Config	4 years ago
Stephen Shelton	f607b99dbe	Fixes to Context::Configure with default config	4 years ago
Stephen Shelton	97c14d81fd	Refactor test_llarp_exit_context.cpp to remove C API usage	4 years ago
Jeff Becker	0787b6e2fd	load config differently for unit tests because they run as root in CI for some reason	4 years ago
Jeff Becker	98a3b45f16	disable logging to see why ci tests die like a sucka	4 years ago
Jeff Becker	b6a7b5ccfb	only run catch2 tests in gdb and add assert to unit test	4 years ago
Jeff Becker	456f9d4ba1	remove GNU-ism	4 years ago
Jeff Becker	e95b9d530e	fix unit tests, make them pass	4 years ago
Jeff Becker	f4971a88fd	use lokimq workers instead of llarp:🧵:ThreadPool	4 years ago
Jeff Becker	1780e86faa	fix up unit tests, make them all pass	4 years ago
Stephen Shelton	779658edd0	Refactor ExitEndpoint's config, mv dns ops from [network] to [dns]	4 years ago
Stephen Shelton	21ad442b55	Remove NetConfig_t	4 years ago
Michael	a2326efa37	Revert "Merge pull request #679 from tewinget/revert-config-refactor" ... This reverts commit 2996a7f29c, reversing changes made to 10df3bd4b3.	5 years ago
Thomas Winget	d044d60101	Reverts #678 #677 and #669 with hashes: ... 10df3bd 766ece8 979f095 See those commits for further details	5 years ago
Michael	8c2d67f8f1	Fix tests	5 years ago
Michael	9ee525a006	Fix shadowing warnings	5 years ago
Michael	048fa83c39	Finish replacement of Router with AbstractRouter	5 years ago
Michael	da6cdfc0b2	More refactoring to continue to make dependency graph acylic	5 years ago
Michael	fa2b466ffe	Reorganise tests to mirror source layout	5 years ago