From afca558817a3954e2b4b8a9e22dcb508722833da Mon Sep 17 00:00:00 2001 From: George Tsagkarelis Date: Wed, 14 Jun 2023 15:49:49 +0300 Subject: [PATCH] liquidity: add false-positive checks on autoloop tests --- liquidity/autoloop_testcontext_test.go | 36 ++++++++++++++++++++++++++ 1 file changed, 36 insertions(+) diff --git a/liquidity/autoloop_testcontext_test.go b/liquidity/autoloop_testcontext_test.go index bbaf2b5..681e825 100644 --- a/liquidity/autoloop_testcontext_test.go +++ b/liquidity/autoloop_testcontext_test.go @@ -344,6 +344,24 @@ func (c *autoloopTestCtx) autoloop(step *autoloopStep) { return c.manager.numActiveStickyLoops() == 0 }, defaultEventuallyTimeout, defaultEventuallyInterval, "failed to"+ " wait for sticky loop counter") + + // Since we're checking if any false-positive swaps were dispatched we + // need to give some time to autoloop to possibly dispatch them. + select { + case <-c.outRequest: + c.t.Fatal("expected no more loopout requests") + + case <-c.inRequest: + c.t.Fatal("expected no more loopin requests") + + case <-c.quoteRequestIn: + c.t.Fatal("expected no more loopout quote requests") + + case <-c.quoteRequest: + c.t.Fatal("expected no more loopin quote requests") + + case <-time.After(500 * time.Millisecond): + } } // easyautoloop walks our test context through the process of triggering our @@ -383,6 +401,24 @@ func (c *autoloopTestCtx) easyautoloop(step *easyAutoloopStep, noop bool) { actual.OutgoingChanSet, ) } + + // Since we're checking if any false-positive swaps were dispatched we + // need to give some time to autoloop to possibly dispatch them. + select { + case <-c.outRequest: + c.t.Fatal("expected no more loopout requests") + + case <-c.inRequest: + c.t.Fatal("expected no more loopin requests") + + case <-c.quoteRequestIn: + c.t.Fatal("expected no more loopout quote requests") + + case <-c.quoteRequest: + c.t.Fatal("expected no more loopin quote requests") + + case <-time.After(500 * time.Millisecond): + } } // matchLoopOuts checks that the actual loop out requests we got match the