Archives
/
readability
2
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Don't use data-old- prefix if old img attr not exists

Browse Source
pull/607/head
Radhi Fadlillah 4 years ago committed by Gijs
parent 7d74395b7b
commit 3976fa34e9
2 changed files with 13 additions and 17 deletions
Show Stats Download Patch File Download Diff File

28
Readability.js
Unescape Escape View File

@ -1390,27 +1390,23 @@ Readability.prototype = {
}
var newImg = tmp.getElementsByTagName("img")[0];
var newImgSrc = newImg.getAttribute("src");
var newImgSrcset = newImg.getAttribute("srcset");
var prevImgSrc = prevImg.getAttribute("src");
var prevImgSrcset = prevImg.getAttribute("srcset");
if (prevImgSrc && prevImgSrc !== newImgSrc) {
newImg.setAttribute("data-old-src", prevImgSrc);
}
if (prevImgSrcset && prevImgSrcset !== newImgSrcset) {
newImg.setAttribute("data-old-srcset", prevImgSrcset);
}
for (var i = 0; i < prevImg.attributes.length; i++) {
var attr = prevImg.attributes[i];
if (attr.name == "src" || attr.name == "srcset" || newImg.hasAttribute(attr.name)) {
if (attr.value === "") {
continue;
}
if (/\.(jpg|jpeg|png|webp)/i.test(attr.value)) {
newImg.setAttribute(attr.name, attr.value);
if (attr.name === "src" || attr.name === "srcset" || /\.(jpg|jpeg|png|webp)/i.test(attr.value)) {
if (newImg.getAttribute(attr.name) === attr.value) {
continue;
}
var attrName = attr.name;
if (newImg.hasAttribute(attrName)) {
attrName = "data-old-" + attrName;
}
newImg.setAttribute(attrName, attr.value);
}
}

2
test/test-pages/citylab-1/expected.html
Unescape Escape View File

@ -12,7 +12,7 @@
<meta itemprop="width" content="300" />
<meta itemprop="url" content="https://cdn.citylab.com/media/img/citylab/2019/04/mr1/300.jpg?mod=1556645448" />
<picture>
<source srcset="https://cdn.citylab.com/media/img/citylab/2019/04/mr1/300.jpg?mod=1556645448" media="(max-width: 575px)" /><img src="https://cdn.citylab.com/media/img/citylab/2019/04/mr1/300.jpg?mod=1556645448" alt="" data-old-srcset="https://cdn.citylab.com/media/img/citylab/2019/04/mr1/300.jpg?mod=1556645448" /></picture>
<source srcset="https://cdn.citylab.com/media/img/citylab/2019/04/mr1/300.jpg?mod=1556645448" media="(max-width: 575px)" /><img src="https://cdn.citylab.com/media/img/citylab/2019/04/mr1/300.jpg?mod=1556645448" alt="" srcset="https://cdn.citylab.com/media/img/citylab/2019/04/mr1/300.jpg?mod=1556645448" /></picture>
<figcaption>
<span itemprop="caption">The Moulin Rouge cabaret in Paris</span> <span itemprop="creator">Benoit Tessier/Reuters</span>
</figcaption>

Write Preview
Loading…
Cancel
Save