From eb091aec545af957b1a466bc59912c8b0e7edec2 Mon Sep 17 00:00:00 2001 From: Mariano Cano Date: Wed, 10 Aug 2022 17:44:14 -0700 Subject: [PATCH] Simplify field names for ProvisionerInfo --- authority/tls.go | 6 +++--- cas/apiv1/requests.go | 6 +++--- cas/stepcas/stepcas.go | 6 +++--- cas/stepcas/stepcas_test.go | 2 +- 4 files changed, 10 insertions(+), 10 deletions(-) diff --git a/authority/tls.go b/authority/tls.go index 24cd86c5..2238f849 100644 --- a/authority/tls.go +++ b/authority/tls.go @@ -100,9 +100,9 @@ func (a *Authority) Sign(csr *x509.CertificateRequest, signOpts provisioner.Sign case provisioner.Interface: prov = k pInfo = &casapi.ProvisionerInfo{ - ProvisionerID: prov.GetID(), - ProvisionerType: prov.GetType().String(), - ProvisionerName: prov.GetName(), + ID: prov.GetID(), + Type: prov.GetType().String(), + Name: prov.GetName(), } // Adds new options to NewCertificate case provisioner.CertificateOptions: diff --git a/cas/apiv1/requests.go b/cas/apiv1/requests.go index 3dfbbc9d..6124f3ba 100644 --- a/cas/apiv1/requests.go +++ b/cas/apiv1/requests.go @@ -63,9 +63,9 @@ type CreateCertificateRequest struct { // ProvisionerInfo contains information of the provisioner used to authorize a // certificate. type ProvisionerInfo struct { - ProvisionerID string - ProvisionerType string - ProvisionerName string + ID string + Type string + Name string } // CreateCertificateResponse is the response to a create certificate request. diff --git a/cas/stepcas/stepcas.go b/cas/stepcas/stepcas.go index ffcbeab9..5cedebe3 100644 --- a/cas/stepcas/stepcas.go +++ b/cas/stepcas/stepcas.go @@ -79,9 +79,9 @@ func (s *StepCAS) CreateCertificate(req *apiv1.CreateCertificateRequest) (*apiv1 if p := req.Provisioner; p != nil { info = &raInfo{ AuthorityID: s.authorityID, - ProvisionerID: p.ProvisionerID, - ProvisionerType: p.ProvisionerType, - ProvisionerName: p.ProvisionerName, + ProvisionerID: p.ID, + ProvisionerType: p.Type, + ProvisionerName: p.Name, } } diff --git a/cas/stepcas/stepcas_test.go b/cas/stepcas/stepcas_test.go index 8312589a..9999e9c1 100644 --- a/cas/stepcas/stepcas_test.go +++ b/cas/stepcas/stepcas_test.go @@ -667,7 +667,7 @@ func TestStepCAS_CreateCertificate(t *testing.T) { {"ok with provisioner", fields{jwk, client, testRootFingerprint}, args{&apiv1.CreateCertificateRequest{ CSR: testCR, Lifetime: time.Hour, - Provisioner: &apiv1.ProvisionerInfo{ProvisionerID: "provisioner-id", ProvisionerType: "ACME"}, + Provisioner: &apiv1.ProvisionerInfo{ID: "provisioner-id", Type: "ACME"}, }}, &apiv1.CreateCertificateResponse{ Certificate: testCrt, CertificateChain: []*x509.Certificate{testIssCrt},